From: Joe Perches <joe@perches.com>
To: "Niklas Söderlund" <niklas.soderlund@corigine.com>
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Andy Whitcroft <apw@canonical.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Philippe Schenker <philippe.schenker@toradex.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
oss-drivers@corigine.com,
Simon Horman <simon.horman@corigine.com>,
Louis Peens <louis.peens@corigine.com>
Subject: Re: [PATCH v7] checkpatch: warn for non-standard fixes tag style
Date: Wed, 21 Sep 2022 09:56:07 -0700 [thread overview]
Message-ID: <aac5ee76680d9ea445f09894e161fa1fb66884a8.camel@perches.com> (raw)
In-Reply-To: <Yyse1XvsdiIJ3dun@oden.dyn.berto.se>
On Wed, 2022-09-21 at 16:25 +0200, Niklas Söderlund wrote:
> Hello Joe,
Hello Niklas
> Just wanted to check on my misunderstanding below before posting a v8.
I think v7 is ok, unless you found something else better.
> > > One grep pattern to verify the non canonical fixes format that
> > > are mistakenly used is:
> > >
> > > $ git log --since=5-years-ago --no-merges --grep='^\s*fixes' -i --format=email -P | \
> > > grep -P -i '^\s*fixes' | \
> > > grep -P -v '^Fixes: [0-9a-f]{12,12}\s*\(".*")'
> > > There are many different styles.
> > > Parentheses are sometimes not used.
> >
> > I understand this, and I did have a look at it.
Good enough for me. Thanks.
next prev parent reply other threads:[~2022-09-21 16:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 10:02 [PATCH v7] checkpatch: warn for non-standard fixes tag style Niklas Söderlund
2022-09-14 16:09 ` Joe Perches
2022-09-15 9:14 ` Niklas Söderlund
2022-09-21 14:25 ` Niklas Söderlund
2022-09-21 16:56 ` Joe Perches [this message]
2022-09-21 16:57 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aac5ee76680d9ea445f09894e161fa1fb66884a8.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=corbet@lwn.net \
--cc=dwaipayanray1@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.peens@corigine.com \
--cc=lukas.bulwahn@gmail.com \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=philippe.schenker@toradex.com \
--cc=sfr@canb.auug.org.au \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox