From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26B193659E1; Fri, 6 Mar 2026 11:53:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772798049; cv=none; b=XVLq9LEaUZalJsmla9v4k1Bx0UqTieshl9LfWWEoD/iOHZF1ADRaVHV7rTHNbzug7xlpx9rFsFtGSQl42GPqdEtJRzOFW/VEu93slmFWtKtKlrlLkqWKTtGMMYQ1fu56Tnew1a3x1VjG1JZXU1IYo+wIA5MwlCVJpOUBqukH/ZU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772798049; c=relaxed/simple; bh=gxY2HteUlEPwtGAhzmFFS7SvKb27QN/7kHK5ETDjuv8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EFikE2xC/WXcFpHXM01gTH7q50WlFIFTqBJjnJNjfc75kXeyttFE2DZ//TUjGiMlQEDwwrBVocPGZ1343yWthCABM1NLQfEHpw8rnnaFWBeRfwhN+etmvgCg9wI3JlWt4UgQIGo545L4HSgwLDm9R6LNTv1sIL+icDjI7/Zjmyw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=cxFDStwM; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cxFDStwM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772798037; x=1804334037; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=gxY2HteUlEPwtGAhzmFFS7SvKb27QN/7kHK5ETDjuv8=; b=cxFDStwMjTcsrQSUOWjlhJ/TWOXOgJbMxDTINmXYZysJ8rrSZ1VO2O7J zo8UVkKNr1PKPwkeeQtxMVIHuhQSX/OCxhgIh3YzcnFvqhAsnksVtq/w5 2CV+g8L/GpAgz9dhUjRkOZd6xut+3bIU3dzm2Ay9JLTNdEnr42WSRrO6E rnYHRAIb1LXtOBFwYFhuFzGTUvzq2UPfsVX84omuEq+NX93uQXkRQtwQI CCIo59IKF83ZjR1U1bV7OwRQ/4glHjVc35UnyJuljNore+scGU5QvuY4+ lBADobV763yV1Qv6/3qBgQEnDhfHOisciK1ef5RekYaMmRwxjBTpmIasd w==; X-CSE-ConnectionGUID: KEoE6wxVRh6i45RCdX7J0g== X-CSE-MsgGUID: w13mqQ5cSpCMq+QaUVFoew== X-IronPort-AV: E=McAfee;i="6800,10657,11720"; a="74020367" X-IronPort-AV: E=Sophos;i="6.23,104,1770624000"; d="scan'208";a="74020367" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2026 03:53:51 -0800 X-CSE-ConnectionGUID: EwWNBUmeSwO6ezV8ekzYDw== X-CSE-MsgGUID: eZsczoX6Q3CYsfBXL7YygA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,104,1770624000"; d="scan'208";a="249460615" Received: from abityuts-desk.ger.corp.intel.com (HELO localhost) ([10.245.245.1]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2026 03:53:46 -0800 Date: Fri, 6 Mar 2026 13:53:43 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Bartosz Golaszewski , Geert Uytterhoeven , Frank Rowand , Mika Westerberg , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Russell King , Jonathan Corbet , Shuah Khan , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH 2/6] gpio: move hogs into GPIO core Message-ID: References: <20260305-gpio-hog-fwnode-v1-0-97d7df6bbd17@oss.qualcomm.com> <20260305-gpio-hog-fwnode-v1-2-97d7df6bbd17@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260305-gpio-hog-fwnode-v1-2-97d7df6bbd17@oss.qualcomm.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Mar 05, 2026 at 10:51:27AM +0100, Bartosz Golaszewski wrote: > Refactor line hogging code by moving the parts duplicated in > gpiolib-acpi-core.c and gpiolib-of.c into gpiolib.c, leaving just the > OF-specific bits in the latter. > > This makes fwnode the primary API for setting up hogs and allows to use > software nodes in addition to ACPI and OF nodes. ... > +int gpiochip_add_hog(struct gpio_chip *gc, struct fwnode_handle *fwnode) > +{ > + struct fwnode_handle *gc_node = dev_fwnode(&gc->gpiodev->dev); > + struct of_phandle_args gpiospec; > + enum gpiod_flags dflags; > + struct gpio_desc *desc; > + unsigned long lflags; > + const char *name; > + int ret, argc; > + u32 gpios[3]; /* We support up to three-cell bindings. */ > + u32 cells; > + > + lflags = GPIO_LOOKUP_FLAGS_DEFAULT; > + dflags = GPIOD_ASIS; > + name = NULL; > + > + argc = fwnode_property_count_u32(fwnode, "gpios"); > + if (argc < 0) > + return ret; As LKP noticed this perhaps needs to be changed to return argc; > + if (argc > 3) > + return -EINVAL; > + > + ret = fwnode_property_read_u32_array(fwnode, "gpios", gpios, argc); > + if (ret < 0) > + return ret; > + > + if (is_of_node(fwnode)) { > + /* > + * OF-nodes need some additional special handling for > + * translating of devicetree flags. > + */ > + ret = fwnode_property_read_u32(gc_node, "#gpio-cells", &cells); > + if (ret) > + return ret; > + if (cells && argc != cells) > + return -EINVAL; Hmm... So, when cells is 0 we don't care about argc not being 0? > + memset(&gpiospec, 0, sizeof(gpiospec)); > + gpiospec.np = to_of_node(fwnode); > + gpiospec.args_count = argc; > + memcpy(&gpiospec.args, gpios, argc * sizeof(u32)); > + > + ret = of_gpiochip_get_lflags(gc, &gpiospec, &lflags); I prefer to see less OF things here, id est we may use struct fwnode_reference_args. > + if (ret) > + return ret; > + } else { > + /* > + * GPIO_ACTIVE_LOW is currently the only lookup flag > + * supported for non-OF firmware nodes. > + */ > + if (gpios[1]) > + lflags |= GPIO_ACTIVE_LOW; > + } > + > + if (fwnode_property_present(fwnode, "input")) > + dflags |= GPIOD_IN; > + else if (fwnode_property_present(fwnode, "output-low")) > + dflags |= GPIOD_OUT_LOW; > + else if (fwnode_property_present(fwnode, "output-high")) > + dflags |= GPIOD_OUT_HIGH; > + else > + return -EINVAL; > + > + fwnode_property_read_string(fwnode, "line-name", &name); > + > + desc = gpiochip_get_desc(gc, gpios[0]); > + if (IS_ERR(desc)) > + return PTR_ERR(desc); > + ret = gpiod_hog(desc, name, lflags, dflags); > + if (ret) > + return ret; > + > + return 0; Can be return gpiod_hog(desc, name, lflags, dflags); > +} -- With Best Regards, Andy Shevchenko