From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8CBBC41513 for ; Mon, 31 Jul 2023 11:45:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230350AbjGaLpv (ORCPT ); Mon, 31 Jul 2023 07:45:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231169AbjGaLpt (ORCPT ); Mon, 31 Jul 2023 07:45:49 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61C2DE65 for ; Mon, 31 Jul 2023 04:45:47 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-68706b39c4cso2316251b3a.2 for ; Mon, 31 Jul 2023 04:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690803946; x=1691408746; h=content-transfer-encoding:in-reply-to:from:cc:references:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=eixVz+lC2CT7QVfWGuIxIWOZy5K4rUiP49mRPzTth6c=; b=VT13zwPYUAOAfBEH3rgUxFldZISumpumgvx/iD+w+BPKXFCSw3sb4v14W/QgLOOhbW Y4qIeqO4CObDAuwhvipQAF/Nxwdfy7bhGuyOdCPdgvA74GZiUNA7YMGM2eJh0mgKpjun mbuYrgNQg2POZNYGwztFta3wBsE1ysU2dL3o/0F2XgHLPdsBU4kATSfglaZu9LdweHrO bc9/9LGBiT2538a98gFqSDRWXk4QjqRgfxoau2+N8CLFE5sgcBFdagXToM/WS7YhLx40 aAfi3jZsaDNavimHFkfpKR1AsIE9HlF8UzHi7DX9PX+WONweh99kzIdKxsN7CAlxRgQ/ uYwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690803946; x=1691408746; h=content-transfer-encoding:in-reply-to:from:cc:references:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=eixVz+lC2CT7QVfWGuIxIWOZy5K4rUiP49mRPzTth6c=; b=R8uTI68lMuefICOsPPgI83NxytTUSrfS9epRGWK5jr+QxFyyjgki2q5QBR31aZ+AAt /nLVWKa9oNWnB+0ZmKuBtQ5U8+9/sXBBnyhp5p9jH+/xXc48kkeojIpmEd8oZjvpcVJV ByGNHDencqfuJZlwGq1qIP9T8IpBHNyumZQx0pUT9V/meC4WjaR8Tx/SO5/SNCyvMZlG QnvpKcVUiVW75cg/xUBtPn9Vtc0izw1uEdv6h5agHU4Gtq17qMYvgdAMoPavrPc8j8/g cSjh8d2mtFRFQR+JvdaSaGZ3PAmNqY5bjgHoUKxuSaTfcLSjtW64d4IPkBu8iFQwLnBC gMfA== X-Gm-Message-State: ABy/qLb7gtV5VEk233UlXd9tdstHgwDWOuVojJtEhfEMQS+jYW7tNX9A UXfoVQl9hqaFGOnGhv4L3RT6wg== X-Google-Smtp-Source: APBJJlGydmwkyBJiOoqdphaZJq4iW3Nm7CDrOuaHl7TUuebUj9EajXLsR+UqO8/g3DIuDKwJOE5j+Q== X-Received: by 2002:a05:6a00:194b:b0:677:c5bf:dccc with SMTP id s11-20020a056a00194b00b00677c5bfdcccmr10108630pfk.19.1690803946336; Mon, 31 Jul 2023 04:45:46 -0700 (PDT) Received: from [10.90.34.137] ([203.208.167.147]) by smtp.gmail.com with ESMTPSA id n9-20020aa78a49000000b00668652b020bsm7440809pfa.105.2023.07.31.04.45.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jul 2023 04:45:46 -0700 (PDT) Message-ID: Date: Mon, 31 Jul 2023 19:45:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH 03/11] maple_tree: Add some helper functions To: Matthew Wilcox , "Liam R. Howlett" References: <20230726080916.17454-1-zhangpeng.00@bytedance.com> <20230726080916.17454-4-zhangpeng.00@bytedance.com> <20230726150252.x56owgz3ikujzicu@revolver> Cc: mathieu.desnoyers@efficios.com, npiggin@gmail.com, Peng Zhang , corbet@lwn.net, akpm@linux-foundation.org, michael.christie@oracle.com, peterz@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, avagin@gmail.com, surenb@google.com, brauner@kernel.org From: Peng Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org 在 2023/7/26 23:08, Matthew Wilcox 写道: > On Wed, Jul 26, 2023 at 11:02:52AM -0400, Liam R. Howlett wrote: >> * Peng Zhang [230726 04:10]: >>> static inline >>> -enum maple_type mas_parent_type(struct ma_state *mas, struct maple_enode *enode) >>> +enum maple_type ma_parent_type(struct maple_tree *mt, struct maple_node *node) >> >> I was trying to keep ma_* prefix to mean the first argument is >> maple_node and mt_* to mean maple_tree. I wasn't entirely successful >> with this and I do see why you want to use ma_, but maybe reverse the >> arguments here? > > I think your first idea is better. Usually we prefer to order the > arguments by "containing thing" to "contained thing". So always use > (struct address_space *, struct folio *), for example. Or (struct > mm_struct *, struct vm_area_struct *). There are disagreements here, so how to decide? But I don't know if the new version still has this helper. >