linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yanteng Si <si.yanteng@linux.dev>
To: Pengyu Zhang <zpenya1314@gmail.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	yaxin_wang_uestc@163.com
Subject: Re: [PATCH v4] Docs/zh_CN: Translate page_tables.rst to Simplified Chinese
Date: Sat, 12 Oct 2024 17:19:43 +0800	[thread overview]
Message-ID: <ac6fda5e-52cc-4d64-974d-594d8c20a15e@linux.dev> (raw)
In-Reply-To: <20241011154913.2808-1-zpenya1314@gmail.com>

Hi, Pengyu


在 2024/10/11 23:49, Pengyu Zhang 写道:
> Hi, Yanteng
>
>> 在 2024/10/11 09:47, Yanteng Si 写道:
>>> Hi Pengyu,
>>>
>>> 在 2024/10/8 23:38, Pengyu Zhang 写道:
>>>> This patch provides a Simplified Chinese translation of the
>>>> "page_tables.rst" document, aimed at improving accessibility
>>>> for Chinese-speaking developers and users.
>>>>
>>>> The translation prioritizes technical accuracy and readability,
>>>> ensuring that the content remains clear and informative for
>>>> its intended audience.
>>> Let's add a commit tag so that the scripts/checktransupdate.py can
>>> recognize it. just like:
>>>
>>> Subject:[PATCH v3] docs/zh_CN: add the translation of kbuild/gcc-plugins.rst <https://lore.kernel.org/linux-doc/20240907070244.206808-1-dzm91@hust.edu.cn/#r>
>>> Date: Sat,  7 Sep 2024 15:02:08 +0800
>>>
>>> Finish the translation of kbuild/gcc-plugins.rst and move gcc-plugins
>>> from TODO to the main body.
>>>
>>> Update to commit 3832d1fd84b6 ("docs/core-api: expand Fedora instructions
>>> for GCC plugins")
>>>
>>>
>>> Thanks,
>>> Yanteng
>>>
>> Sorry, my email client sent an HTML email and I have fixed it. Now resend
>> to the mailing list.
>>
>>
>> Thanks,
>> Yanteng
> We discovered a pfn calculation error during the translation of the
> page_tables.rst. I have submitted another patch to fix it, and it had been
> reviewed by three maintainers, but it has not yet been merged into the mainline.
> https://lore.kernel.org/all/20241009144135.12453-1-zpenya1314@gmail.com/
>
> So I have a question: should the commit tag be based on the fix patch
> I submitted, or the tag of the original page_tables.rst?
Hmm, I think you can ignore this tag in the next version and specify the
reason in the commit message, which will also be helpful for future
updates. Of course, there may be a better way, which is to modify this
tag when Jon applies the patch, but I'm not sure if this will work.

Of course, there is another great method, which is to still ignore this
tag and split your translation patch into two patch:

Patch 1 :only translates English documents (with tag);
Patch 2 :fixes the pfn calculation error in the Chinese document.

put them into a patch sets.

git am <Patch 1>
git am 
<https://lore.kernel.org/all/20241009144135.12453-1-zpenya1314@gmail.com/> 
## Remember to pick up the review tag
git am <Patch 2>
git format-patch -3 -v 5 --cover-letter
vim 0000-cover-letterxxx.patch
git send-email   v5*


Thanks,
Yanteng

> Thanks,
> Pengyu
>


  reply	other threads:[~2024-10-12  9:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-11 15:49 [PATCH v4] Docs/zh_CN: Translate page_tables.rst to Simplified Chinese Pengyu Zhang
2024-10-12  9:19 ` Yanteng Si [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-10-08 15:38 Pengyu Zhang
2024-10-09 16:13 ` Jonathan Corbet
     [not found] ` <023c4378-7625-41fc-a671-5db60311b3b8@linux.dev>
2024-10-11  2:01   ` Yanteng Si

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac6fda5e-52cc-4d64-974d-594d8c20a15e@linux.dev \
    --to=si.yanteng@linux.dev \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yaxin_wang_uestc@163.com \
    --cc=zpenya1314@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).