From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C05082765F5; Mon, 23 Mar 2026 17:21:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774286494; cv=none; b=fE7rluz5bdhG0ZDtnOliARDYIqbVqfsEgsHxBFB9rzueznXWd8On7RLFlI22eNzm9hEqaf0hnBmfhY9Yw9FK2cUFBKdY4tIvjVpwOGw0nTLgZf3sKT1oDjAT8ps4Gs/wHd3NEeD+RDXtvCZRaVxKLYXQj5uKVSU4TT3fGs8xOvo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774286494; c=relaxed/simple; bh=cK5crSIbq3v6eBqTicknSYTbc2z0ScWMd5hriD/IKUc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pEt2oem6NImUoC8mrzq5aqhscvKfSyQio/mE5fM8PpOxQglFZFSnFWtje8IgiJlmTPEv0afQdf+9rNIpli8qr4xyGgk8okbSBvsnUP6O2GU/zkC5Blv2RsrZtXYQ9zL+FrZ0QvJL2BM21zluSTiFXuC5m6PnFW7dtV6NHIoSlUs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=groves.net; spf=pass smtp.mailfrom=groves.net; arc=none smtp.client-ip=216.40.44.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=groves.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=groves.net Received: from omf08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 04404160614; Mon, 23 Mar 2026 17:21:22 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: john@groves.net) by omf08.hostedemail.com (Postfix) with ESMTPA id 4B16C20028; Mon, 23 Mar 2026 17:21:11 +0000 (UTC) Date: Mon, 23 Mar 2026 12:21:09 -0500 From: John Groves To: Jonathan Cameron Cc: Miklos Szeredi , Dan Williams , Bernd Schubert , Alison Schofield , John Groves , Jonathan Corbet , Shuah Khan , Vishal Verma , Dave Jiang , Matthew Wilcox , Jan Kara , Alexander Viro , David Hildenbrand , Christian Brauner , "Darrick J . Wong" , Randy Dunlap , Jeff Layton , Amir Goldstein , Stefan Hajnoczi , Joanne Koong , Josef Bacik , Bagas Sanjaya , Chen Linxuan , James Morse , Fuad Tabba , Sean Christopherson , Shivank Garg , Ackerley Tng , Gregory Price , Aravind Ramesh , Ajay Joshi , venkataravis@micron.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH V8 3/8] dax: add fsdev.c driver for fs-dax on character dax Message-ID: References: <20260318202737.4344.dax@groves.net> <20260319012837.4443-1-john@groves.net> <20260319122057.00004503@huawei.com> <20260323121250.00004402@huawei.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260323121250.00004402@huawei.com> X-Rspamd-Queue-Id: 4B16C20028 X-Stat-Signature: bxdg8a6ie1w9ircu3df6dzukx13pabjz X-Rspamd-Server: rspamout03 X-Session-Marker: 6A6F686E4067726F7665732E6E6574 X-Session-ID: U2FsdGVkX1809opFCnBO7f651BPCBxwJ49nYJRohtOQ= X-HE-Tag: 1774286471-505091 X-HE-Meta: U2FsdGVkX18TNbiNbjQAlQ4GJFRHGyldIttWpgr1j2rn5VyzyRd0i4qZeR9hoDHZQrdYZOJsFUs7jBmX0NYdmy9tTcx06VRGCaHpJJs4XTh8Jn0HmLGTXgasXh9eeCPDB0C1DZToGpaBktv/5DIvVHzJ98Fw6r20OUNvOn0seum3ZxpleT06MJ5yW2bE4tn/un93ch7n4iWUxOKSd928b+Pmpd6PQzeplKif+4UHE1m0W4VgErxI0jFkID+MJlzoj5u9kg1P6xVcqrmYoM1Fc+Gc7T4/4TxKxsyF1jTZPZAIbFiSEjEXJC9n3l/Ittkb On 26/03/23 12:12PM, Jonathan Cameron wrote: > > > > > diff --git a/drivers/dax/Makefile b/drivers/dax/Makefile > > > > index 5ed5c39857c8..3bae252fd1bf 100644 > > > > --- a/drivers/dax/Makefile > > > > +++ b/drivers/dax/Makefile > > > > @@ -5,10 +5,16 @@ obj-$(CONFIG_DEV_DAX_KMEM) += kmem.o > > > > obj-$(CONFIG_DEV_DAX_PMEM) += dax_pmem.o > > > > obj-$(CONFIG_DEV_DAX_CXL) += dax_cxl.o > > > > > > > > +# fsdev_dax: fs-dax compatible devdax driver (needs DEV_DAX and FS_DAX) > > > > +ifeq ($(CONFIG_FS_DAX),y) > > > > +obj-$(CONFIG_DEV_DAX) += fsdev_dax.o > > > > +endif > > > > > > Why not throw in a new CONFIG_FSDAX_DEV and handle the dependencies > > > in Kconfig? > > > > At one point I had another config parameter, but I'm trying not to > > gratuitously add them. The fsdev driver is pretty small, and including it > > whenever FS_DAX is enabled felt reasonable to me. I'm willing to change it > > if there's a consensus that way. > > You can make the build do exactly the same thing with a separate Kconfig > option. Just moves where the dependency tracking is. I'd prefer Kconfig > because that's generally where I'd look for something like this. > > > Jonathan OK, will do. It will be CONFIG_DEV_DAX_FSDEV for naming consistency. V9 coming within 24 hours... John