From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Francesco Lavra <flavra@baylibre.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v8 2/6] iio: Replace 'sign' field with union in struct iio_scan_type
Date: Mon, 23 Mar 2026 18:49:34 +0200 [thread overview]
Message-ID: <acFvHgTo-3cxH_UP@ashevche-desk.local> (raw)
In-Reply-To: <af2128c68d2a14e1eb664ce9dc075ed02b640407.camel@baylibre.com>
On Mon, Mar 23, 2026 at 05:04:10PM +0100, Francesco Lavra wrote:
> On Sat, 2026-03-21 at 12:22 -0500, David Lechner wrote:
> > On 3/17/26 10:04 AM, Francesco Lavra wrote:
...
> > > + * @IIO_SCAN_FORMAT_SIGNED_INT: Signed integer (two's complement).
> > > + * @IIO_SCAN_FORMAT_UNSIGNED_INT: Unsigned integer.
> > We could make this proper kernel doc format with one comment per macro.
>
> Actually, a set of related #defines can be documented with a single
> comment. I see a few examples doing that in include/linux/gfp_types.h and
> include/linux/fpga/fpga-mgr.h
>
> > > +#define IIO_SCAN_FORMAT_SIGNED_INT 's'
> > > +#define IIO_SCAN_FORMAT_UNSIGNED_INT 'u'
...or use enum
/**
* ...kernel-doc for enum...
*/
enum {
IIO_SCAN_FORMAT_SIGNED_INT = 's',
IIO_SCAN_FORMAT_UNSIGNED_INT = 'u',
};
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-23 16:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260317150316.3878107-1-flavra@baylibre.com>
2026-03-17 15:04 ` [PATCH v8 2/6] iio: Replace 'sign' field with union in struct iio_scan_type Francesco Lavra
2026-03-21 17:22 ` David Lechner
2026-03-23 16:04 ` Francesco Lavra
2026-03-23 16:08 ` David Lechner
2026-03-23 16:49 ` Andy Shevchenko [this message]
2026-03-23 17:37 ` Francesco Lavra
2026-03-24 11:04 ` Andy Shevchenko
2026-03-24 11:42 ` Francesco Lavra
2026-03-24 11:52 ` Andy Shevchenko
2026-03-17 15:04 ` [PATCH v8 4/6] iio: ABI: Add support for floating-point numbers in buffer scan elements Francesco Lavra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acFvHgTo-3cxH_UP@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=corbet@lwn.net \
--cc=dlechner@baylibre.com \
--cc=flavra@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox