From: Lukas Wunner <lukas@wunner.de>
To: Maciej Grochowski <mx2pg@pm.me>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-pci@vger.kernel.org, linux-doc@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Ilpo Jarvinen <ilpo.jarvinen@linux.intel.com>,
Kai-Heng Feng <kaihengf@nvidia.com>
Subject: Re: [PATCH] Documentation: PCI: Document decoding of TLP Header in AER messages
Date: Tue, 24 Mar 2026 11:09:35 +0100 [thread overview]
Message-ID: <acJi32zgSVvDPVyK@wunner.de> (raw)
In-Reply-To: <jlpBGxAZL6_8dQI417NowB0RVfrnwcnuaNvBlTN035buqP4dRBJaaX3fwqtYxZu2evmcNCAJVzj2suZKDA5iriUSrpj_ziWQVWxZS3nEkEg=@pm.me>
On Tue, Mar 24, 2026 at 05:53:30AM +0000, mx2pg@pm.me wrote:
> One thing worth calling out: starting with PCIe 6.0, Flit Mode is
> mandatory at 64.0 GT/s and supported at all PCIe link speeds, so a
> Flit-capable PCIe 6.x link may operate below 64.0 GT/s and still be
> in Flit Mode. The raw TLP Header bytes do not encode the framing —
> the same four bytes decode to entirely different packet types in
> non-Flit vs Flit framing. The negotiated mode can be read from the
> Flit Mode Status bit in Link Status 2, or via lspci -vv on a recent
> pciutils build.
Thanks Maciej for chiming in.
Ilpo (who is cc'ed) amended the kernel last year with commit
7e077e6707b3 ("PCI/ERR: Handle TLP Log in Flit mode") to suffix
the hexdump with " (Flit)" in Flit Mode:
https://git.kernel.org/linus/7e077e6707b3
Any chance you could amend tlp-tool to auto-detect Flit Mode
if the suffix is present?
As an aside: Prior to that, commit f68ea779d98a ("PCI: Add
pcie_print_tlp_log() to print TLP Header and Prefix Log")
changed the log message to prefix each dword with "0x".
But I tested it and it seems that tlp-tool groks both the
old and the new format without any code change:
https://git.kernel.org/linus/f68ea779d98a
But we need to be careful going forward not to break user space
tooling that might rely on the syntax.
Thanks,
Lukas
next prev parent reply other threads:[~2026-03-24 10:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 6:52 [PATCH] Documentation: PCI: Document decoding of TLP Header in AER messages Lukas Wunner
2026-03-23 11:03 ` Mika Westerberg
2026-03-23 16:50 ` Bjorn Helgaas
2026-03-24 5:53 ` mx2pg
2026-03-24 10:09 ` Lukas Wunner [this message]
2026-03-24 10:22 ` Lukas Wunner
2026-03-24 11:18 ` Ilpo Järvinen
2026-03-25 5:18 ` mx2pg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acJi32zgSVvDPVyK@wunner.de \
--to=lukas@wunner.de \
--cc=corbet@lwn.net \
--cc=helgaas@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kaihengf@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mx2pg@pm.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox