public inbox for linux-doc@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>,
	 Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Andy Whitcroft <apw@canonical.com>,
	 Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	 workflows@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: allow correctly handle full files on stdin
Date: Thu, 26 Mar 2026 16:04:44 -0700	[thread overview]
Message-ID: <acW6Iar6XOzO9IfN@google.com> (raw)
In-Reply-To: <34318752a257b0f6b530eacf53d565de1ac84485.camel@perches.com>

On Thu, Mar 26, 2026 at 03:56:27PM -0700, Joe Perches wrote:
> On Thu, 2026-03-26 at 14:42 -0700, Dmitry Torokhov wrote:
> > > > Because when I am editing a file I am not saving it all that often. I
> > > > want to have buffer diagnostic updated when I leave insert mode in vim.
> > > 
> > > I believe you are able to keep your own version of checkpatch.
> > 
> > As well as my version of the kernel, gcc, clang, editor, git and so on.
> > 
> > Do you have any constructive feedback?
> 
> I gave you feedback.  You elided it.

Could you please point me to it? All I saw is "just save it" and "keep
your own copy". Neither of this suggestions are particularly useful.

> 
> > Right now checkpatch is broken
> > when using "-f" with stdin and I offer a fix. If you have a better way
> > in mind by all means share it.
> 
> Note the name.  Feed it a patch.  It works fine.  It's not broken.

This option is a bug then and should be removed:

"-f, --file                 treat FILE as regular source file"

right?

In all seriousness, if you will not make use of this mode it's fine. But
it allows keeping the source cleaner as one makes edits, so why not
enable this?

-- 
Dmitry

  reply	other threads:[~2026-03-26 23:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26  6:20 [PATCH] checkpatch: allow correctly handle full files on stdin Dmitry Torokhov
2026-03-26  8:46 ` Joe Perches
2026-03-26 14:53   ` Dmitry Torokhov
2026-03-26 21:36     ` Joe Perches
2026-03-26 21:42       ` Dmitry Torokhov
2026-03-26 22:56         ` Joe Perches
2026-03-26 23:04           ` Dmitry Torokhov [this message]
2026-03-26 23:10             ` Joe Perches
2026-03-26 23:19               ` Dmitry Torokhov
2026-03-26 23:27                 ` Joe Perches
2026-03-26 23:19             ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acW6Iar6XOzO9IfN@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=apw@canonical.com \
    --cc=corbet@lwn.net \
    --cc=dwaipayanray1@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=skhan@linuxfoundation.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox