From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9C3B3F65F9 for ; Fri, 8 May 2026 14:56:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778252206; cv=none; b=JR3aQkcP+rg1W+pRLWHTYTRX0Y/tPKzkV21hKVN8ArazF3MjdSQC0YXAUdrk3Ay47ynv5GS8VjxvO7a2EqQBLvJ31WxakwoHnR+6t92K6xqHeJ7w2VX4IZihZMBpFWKnvFyaKwKFwZhFo77vGcQmy9sg1oo2Jtxs45K4YnkxpU8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778252206; c=relaxed/simple; bh=ST5lkWfuyXox1p/2s668Qu5NvhdlAzM4i+LjigyNGwY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R8J6diWQ7+TallD+VaHo7NSyhZ1Lz9Qb3hm9brGzbn16D8bHnbP598P3ltaPNrNPypLBc8SVJZOw9Osk0BWBSq8c8oYrgzMdCvXBNFNQgJGDKfENP4n+we1Rih9GgLzWacTjymvGVrA1zKIb6rZjDHKThB5Kh2eDnzMpofl3Pbs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EJi9pnPw; arc=none smtp.client-ip=209.85.210.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EJi9pnPw" Received: by mail-pf1-f194.google.com with SMTP id d2e1a72fcca58-8354461da74so1034627b3a.1 for ; Fri, 08 May 2026 07:56:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778252204; x=1778857004; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=eSWJGa1a8P8ytmqmY0bXOJYZ37jgE6xppZF6e45wgEA=; b=EJi9pnPwCM0Fj4/nh1cAAEl+iwcxt9GixmhXKLamW2OWananPT03KhbOBCMgpXKmXq cdfWlERyxEOgtA4fMzlroijZ3BA8fOpMKruFISgfqQnlV9B608RjULm7DoIBRzq6l9iz hy2Pah6XuFZlrWWRu9OX/BxP4d6cGVQvuf+2jNMSfgcfvl++RNJ8bfV3IcgvUC/usl5C z0MCTH0lGyRAAO3oJH+1cXs1c03p2+yidjCY/yWMlQgJcQdRso5Vbonv071/jwMs8vb1 WV37vHkZQ4CAPIHIy3SuI0QgGMUDtspNECNwOkRsXCcO1CKHyD6k2NHkZ5DrCT5q54Ig uZJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778252204; x=1778857004; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eSWJGa1a8P8ytmqmY0bXOJYZ37jgE6xppZF6e45wgEA=; b=sMibeP+NZg8Z0CBUHmQ2IdjSHHGxDOVsFb8vO4mC8iQY09yysgIvQ0YbPTJFg0HoRp XAEAql95akN/LnVbh81LbQTWT+C2BYLgr37vnesFSuKEJgmojk+Z/giqM1eWJ7mvtxAv jMDMxf5VgT7EJzmlvwsriTTou8e+uGpDFgmWF+wXSEpLuC50xNsMguhdn8IkMMHOUc6L qn//qN6QEYEmKCg9OMZrk8Wg8fIyTRFTNkREXtuSSim4UXhRtup0WdakUTSdo6IX6Zki ajes6Wco2+yqTZFat935o1RUlD8BmY1KUYpSVQbnFliNnPwAHHhAoPctMElbdQfco9in Uqig== X-Forwarded-Encrypted: i=1; AFNElJ9vV2l8lJvyJ2hM+JqdKv5yMBY+lSsPuRSfV0SiSW8TJK12IhGrADeheWCKGqpB3NbTGvvWrvLvZz0=@vger.kernel.org X-Gm-Message-State: AOJu0YxvSw0RR1XM3QUfMqkNCFvnnJb8eyAHtJ8jzKxGAjCx72kEbwzq BWHxI9A+gpvcrlSwbEof/RC8yIAvuPcr78KWqo9hXJF5EGOIuPj6tAnG X-Gm-Gg: Acq92OE1Ga7rPMSwjgi7NxvnKdoXrP7q6YC2p/KPSixJRoUVXM314J73iHh6q9Y3AFY dKTAz9mSo+TyTCnpoXOeRNM1JB+Gy1RTfScpsscbo+CE81rrXvVex2fP7ZhHsvUQIh1dKVpFes4 zD5ct2HI5/BYoDMTHT3bCiGeghxg4NdIwcoBITx9h1soOLReK0c4J569HnmiErd7Xh34jShUcKp AHzvj7hNbh7XBhGWvJKwFqdUzgyQ1wcuiYNu/SfRQv2cb517P3ISAuiOp3yW1wTR3qHhD/SFtDN FFz9/rYaZC7SlU42TV9hRzoQ0Z+vPj3saZnq/oS2rzJevMUjMfWm1Z2DQHHqgQ8QZ1qluVpwJqh nu/eTZKltbU3SxBZ7bvlbpwVBDhXxCy+VmgVaCfLAaaSbsAlQtX1atqQgRtTR9g++Dzr+T9qgc5 6/0GG3YfehnmakflYJ X-Received: by 2002:a05:6a00:124d:b0:835:7c0e:b529 with SMTP id d2e1a72fcca58-83a5bcd244cmr12592060b3a.12.1778252204005; Fri, 08 May 2026 07:56:44 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:50::]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-839682a272asm12835763b3a.54.2026.05.08.07.56.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 07:56:43 -0700 (PDT) Date: Fri, 8 May 2026 07:56:42 -0700 From: Stanislav Fomichev To: Bobby Eshleman Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan , Alex Shi , Yanteng Si , Dongliang Mu , Michael Chan , Pavan Chebbi , Joshua Washington , Harshitha Ramamurthy , Saeed Mahameed , Tariq Toukan , Mark Bloch , Leon Romanovsky , Alexander Duyck , kernel-team@meta.com, Daniel Borkmann , Nikolay Aleksandrov , Shuah Khan , dw@davidwei.uk, mohsin.bashr@gmail.com, willemb@google.com, jiang.kun2@zte.com.cn, xu.xin16@zte.com.cn, wang.yaxin@zte.com.cn, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Stanislav Fomichev , Mina Almasry , Bobby Eshleman Subject: Re: [PATCH net-next v3 1/8] net: convert netmem_tx flag to enum Message-ID: References: <20260507-tcp-dm-netkit-v3-0-52821445867c@meta.com> <20260507-tcp-dm-netkit-v3-1-52821445867c@meta.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260507-tcp-dm-netkit-v3-1-52821445867c@meta.com> On 05/07, Bobby Eshleman wrote: > From: Bobby Eshleman > > Devices that support netmem TX previously set dev->netmem_tx = true. > This was checked in validate_xmit_unreadable_skb() to drop unreadable > skbs (skbs with dmabuf-backed frags) before they reach drivers that > would mishandle them or devices that would not have the iommu mappings > for them. > > A subsequent patch will introduce a third state for virtual devices > that forward unreadable skbs without ever performing DMA on them. To > prepare for that, convert the boolean dev->netmem_tx into an enum: > > NETMEM_TX_NONE - no netmem TX support (drop unreadable skbs) > NETMEM_TX_DMA - full support, device does DMA > > Update the existing NIC drivers (bnxt, gve, mlx5, fbnic) and the > validators in net/core to use the new enum. No functional change. > > Acked-by: Harshitha Ramamurthy > Signed-off-by: Bobby Eshleman > --- > Changes in v3: > - Split NO_DMA changes into subsequent commit (Jakub) > - Move !netdev->netmem_tx -> netdev->netmem_tx == > NETMEM_TX_NONE conversions to this patch (Jakub) > > Changes in v2: > - Squash driver conversion patches (2-5) into patch 1 (Jakub) > --- > Documentation/networking/netmem.rst | 5 ++++- > Documentation/translations/zh_CN/networking/netmem.rst | 4 +++- > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- > drivers/net/ethernet/google/gve/gve_main.c | 2 +- > drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +- > drivers/net/ethernet/meta/fbnic/fbnic_netdev.c | 2 +- > include/linux/netdevice.h | 8 +++++++- > net/core/dev.c | 2 +- > net/core/netdev-genl.c | 2 +- > 9 files changed, 20 insertions(+), 9 deletions(-) > > diff --git a/Documentation/networking/netmem.rst b/Documentation/networking/netmem.rst > index b63aded46337..5ccadba4f373 100644 > --- a/Documentation/networking/netmem.rst > +++ b/Documentation/networking/netmem.rst > @@ -95,4 +95,7 @@ Driver TX Requirements > netdev@, or reach out to the maintainers and/or almasrymina@google.com for > help adding the netmem API. > > -2. Driver should declare support by setting `netdev->netmem_tx = true` > +2. Driver should declare support by setting `netdev->netmem_tx` to the > + appropriate mode: > + > + - `NETMEM_TX_DMA`: for physical devices that perform DMA. > diff --git a/Documentation/translations/zh_CN/networking/netmem.rst b/Documentation/translations/zh_CN/networking/netmem.rst > index fe351a240f02..9c84423b7528 100644 > --- a/Documentation/translations/zh_CN/networking/netmem.rst > +++ b/Documentation/translations/zh_CN/networking/netmem.rst > @@ -89,4 +89,6 @@ dma-mapping API 去处理。 > 使用某个还不存在的 netmem API，你可以自行添加并提交到 netdev@，也可以联系维护 > 人员或者发送邮件至 almasrymina@google.com 寻求帮助。 > > -2. 驱动程序应通过设置 netdev->netmem_tx = true 来表明自身支持 netmem 功能。 > +2. 驱动程序应将 `netdev->netmem_tx` 设置为适当的模式： > + > + - `NETMEM_TX_DMA`：适用于执行 DMA 的物理设备。 > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c > index 8c55874f44ca..ed9c22dc4a5a 100644 > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c > @@ -17120,7 +17120,7 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) > dev->queue_mgmt_ops = &bnxt_queue_mgmt_ops_unsupp; > if (BNXT_SUPPORTS_QUEUE_API(bp)) > dev->queue_mgmt_ops = &bnxt_queue_mgmt_ops; > - dev->netmem_tx = true; > + dev->netmem_tx = NETMEM_TX_DMA; > > rc = register_netdev(dev); > if (rc) > diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c > index 424d973c97f2..dd2b8f087163 100644 > --- a/drivers/net/ethernet/google/gve/gve_main.c > +++ b/drivers/net/ethernet/google/gve/gve_main.c > @@ -2894,7 +2894,7 @@ static int gve_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > goto abort_with_wq; > > if (!gve_is_gqi(priv) && !gve_is_qpl(priv)) > - dev->netmem_tx = true; > + dev->netmem_tx = NETMEM_TX_DMA; > > err = register_netdev(dev); > if (err) > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > index 5a46870c4b74..fc49aae38807 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c > @@ -5924,7 +5924,7 @@ static void mlx5e_build_nic_netdev(struct net_device *netdev) > > netdev->priv_flags |= IFF_UNICAST_FLT; > > - netdev->netmem_tx = true; > + netdev->netmem_tx = NETMEM_TX_DMA; > > netif_set_tso_max_size(netdev, GSO_MAX_SIZE); > mlx5e_set_xdp_feature(priv); > diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c b/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c > index c406a3b56b37..138e522ef9b9 100644 > --- a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c > +++ b/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c > @@ -752,7 +752,7 @@ struct net_device *fbnic_netdev_alloc(struct fbnic_dev *fbd) > netdev->netdev_ops = &fbnic_netdev_ops; > netdev->stat_ops = &fbnic_stat_ops; > netdev->queue_mgmt_ops = &fbnic_queue_mgmt_ops; > - netdev->netmem_tx = true; > + netdev->netmem_tx = NETMEM_TX_DMA; > > fbnic_set_ethtool_ops(netdev); > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 0e1e581efc5a..580bccb118a0 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -1788,6 +1788,11 @@ enum netdev_stat_type { > NETDEV_PCPU_STAT_DSTATS, /* struct pcpu_dstats */ > }; > > +enum netmem_tx_mode { > + NETMEM_TX_NONE, /* no netmem TX support */ > + NETMEM_TX_DMA, /* DMA-capable netmem TX (real HW) */ > +}; > + > enum netdev_reg_state { > NETREG_UNINITIALIZED = 0, > NETREG_REGISTERED, /* completed register_netdevice */ > @@ -1809,7 +1814,8 @@ enum netdev_reg_state { > * @lltx: device supports lockless Tx. Deprecated for real HW > * drivers. Mainly used by logical interfaces, such as > * bonding and tunnels > - * @netmem_tx: device support netmem_tx. > + * @netmem_tx: device netmem TX mode (NETMEM_TX_NONE or > + * NETMEM_TX_DMA). nit: if you happen to repost, listing enum values here seems too much? "device netmem TX mode" should be enough Acked-by: Stanislav Fomichev