From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 164643CB91E for ; Thu, 21 May 2026 17:07:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779383226; cv=none; b=bCcnvUfmDIFSRXTEszX3Nfb4SIYzWbhx1HEbcpkQzb5krb9KPRXFs1qqofoEPAEeV66DJAylb1g0A212i8ZtLfiHkY1OB+fgd+k3ZaUXKlUyZgmecSlBRK0+KnvjHbxEFd4oJW0gysMcZGQnkPLtAK+RLvmHfzG7qfcoGUPxs8g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779383226; c=relaxed/simple; bh=n73Py4tX0x6CbDtrVaVKUT6jP8Hb5QmRT3SSw45fPfc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=b8Zt3BLKcwVilYsh9iXYD50zyvz7TEzKadgBLD00U4mJLcGnCdaPGWgNRUaUVCGBjMAVQ5uJLrApy5nhI87fvqEItt1RLGPX2aE4OXnWgUMzGF50i0rwKC7Ku1Dx5iU1rcwD2ENNns51ZEIA9T7oVL8PGhJmmtbV2twowilYnps= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZGLiUCmB; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZGLiUCmB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779383224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aqtx7/ZgZtJqtGmUDilhAq3QEZVyLamVBnXprfT/w7Y=; b=ZGLiUCmB4ka6ubeGgG6ez7SjuN0KmGjR4kuz8JuNg3eblfNtOBS/SQPHgyNasD1EcbWp+J MBQtAJfhWLstnsWhkWh//0h8qqOJXmz2M+1bxBZCFnj1REYIdX1wdQOdmWyMrHOhEru0dp nlGVwtuZkwfnEJgTg8UPqagP5JvfrA8= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-304-Si519SFBP5myV1KRA88w4Q-1; Thu, 21 May 2026 13:06:57 -0400 X-MC-Unique: Si519SFBP5myV1KRA88w4Q-1 X-Mimecast-MFC-AGG-ID: Si519SFBP5myV1KRA88w4Q_1779383215 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 41B4219560A3; Thu, 21 May 2026 17:06:54 +0000 (UTC) Received: from thinkpad (headnet01.pony-001.prod.iad2.dc.redhat.com [10.2.32.101]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E07CA1685; Thu, 21 May 2026 17:06:47 +0000 (UTC) Date: Thu, 21 May 2026 19:06:44 +0200 From: Felix Maurer To: Jakub Kicinski Cc: MD Danish Anwar , Luka Gejak , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan , Roger Quadros , Andrew Lunn , Meghana Malladi , Jacob Keller , David Carlier , Vadim Fedorenko , Kevin Hao , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vladimir Oltean Subject: Re: [PATCH net-next v2 2/2] net: ti: icssg: Add HSR and LRE PA statistics Message-ID: References: <20260514075605.850674-1-danishanwar@ti.com> <20260514075605.850674-3-danishanwar@ti.com> <20260518184506.694c584e@kernel.org> <20260519165646.09b0783f@kernel.org> <1d8ab51a-6943-4978-88cf-adda8cc57f7e@ti.com> <20260520153303.33692fe3@kernel.org> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260520153303.33692fe3@kernel.org> X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 On Wed, May 20, 2026 at 03:33:03PM -0700, Jakub Kicinski wrote: > On Wed, 20 May 2026 15:30:24 +0530 MD Danish Anwar wrote: > > What should be the next steps here? Is there any existing defined set of > > stats where I could populate stats from ICSSG firmware for HSR (similar > > to ndo_get_stats64 callback). Or de we need to implement a new callback > > that will do this for HSR. > > I'd try to plumb this thru ndo_get_offload_stats > Close enough for my taste, let's see if anyone objects. I'm not super well versed with the different options for stats we have at the moment, so I'm definitely not going to object. I'm just going to note that the stats I listed are applicable to all HSR/PRP interfaces, not just the ones with hardware offloads. Therefore, it would IMHO be nice if the two didn't diverge too much in the end and (best case) userspace can ask for either the one or the other but get the same structure back (no need to implement it for the software-only interfaces in this patch series, I can do that afterwards as well). Thanks, Felix