From: Nicolas Schier <nsc@kernel.org>
To: "Mario Limonciello (AMD)" <superm1@kernel.org>
Cc: mario.limonciello@amd.com, nathan@kernel.org, corbet@lwn.net,
skhan@linuxfoundation.org, linux-kbuild@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] kbuild: deb-pkg: Allow setting package name at build
Date: Sun, 17 May 2026 08:57:32 +0200 [thread overview]
Message-ID: <aglm3IFmnCPInJqH@levanger> (raw)
In-Reply-To: <20260505152957.695641-1-superm1@kernel.org>
On Tue, May 05, 2026 at 10:29:54AM -0500, Mario Limonciello (AMD) wrote:
> Users can change the source package by setting variable `KDEB_SOURCENAME`,
> but the binary package name is hardcoded.
>
> Add support for setting binary package name by using `KDEB_PACKAGENAME`
> and let it affect both kernel image and debug image packages.
>
> Update kbuild documentation to include defaults and mention both
> `KDEB_PACKAGENAME` and `KDEB_SOURCENAME`.
>
> Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
> ---
> Documentation/kbuild/kbuild.rst | 10 ++++++++++
> scripts/package/mkdebian | 6 ++++--
> 2 files changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/kbuild/kbuild.rst b/Documentation/kbuild/kbuild.rst
> index 5a9013bacfb75..cbdd2224c3a55 100644
> --- a/Documentation/kbuild/kbuild.rst
> +++ b/Documentation/kbuild/kbuild.rst
> @@ -177,6 +177,16 @@ the UTS_MACHINE variable, and on some architectures also the kernel config.
> The value of KBUILD_DEBARCH is assumed (not checked) to be a valid Debian
> architecture.
>
> +KDEB_SOURCENAME
> +----------------
> +For the deb-pkg target, allows overriding the default source package name.
> +The default package name is "linux-upstream".
> +
> +KDEB_PACKAGENAME
> +----------------
> +For the deb-pkg target, allows overriding the default binary package name.
> +The default package name is "linux-image".
Do you see a real need for that? (We should prevent adding
complexity when it's not neccessary.)
> +
> KDOCFLAGS
> ---------
> Specify extra (warning/error) flags for kernel-doc checks during the build,
> diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
> index d4b007b38a475..cbe4266fac732 100755
> --- a/scripts/package/mkdebian
> +++ b/scripts/package/mkdebian
> @@ -166,7 +166,9 @@ else
> fi
> sourcename=${KDEB_SOURCENAME:-linux-upstream}
>
> -if [ "$ARCH" = "um" ] ; then
> +if [ "${KDEB_PACKAGENAME:+set}" ]; then
> + packagename=$KDEB_PACKAGENAME
> +elif [ "$ARCH" = "um" ]; then
> packagename=user-mode-linux
> else
> packagename=linux-image
> @@ -252,7 +254,7 @@ fi
> if is_enabled CONFIG_DEBUG_INFO; then
> cat <<EOF >> debian/control
>
> -Package: linux-image-${KERNELRELEASE}-dbg
> +Package: $packagename-${KERNELRELEASE}-dbg
> Section: debug
> Architecture: $debarch
> Build-Profiles: <!pkg.${sourcename}.nokerneldbg>
> --
> 2.53.0
>
Did you test that patch?
These changes are not enough, as scripts/package/builddeb does not pick
up the non-standard binary package name in its final 'case', and thus,
_no_ binary package will be generated if KDEB_PACKAGENAME !=
"linux-image".
Kind regards,
Nicolas
prev parent reply other threads:[~2026-05-17 6:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 15:29 [PATCH] kbuild: deb-pkg: Allow setting package name at build Mario Limonciello (AMD)
2026-05-17 6:57 ` Nicolas Schier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aglm3IFmnCPInJqH@levanger \
--to=nsc@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=nathan@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=superm1@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox