From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C02613C98AE; Fri, 22 May 2026 10:33:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779446008; cv=none; b=pRMy+BONDyWphj6rwwCi4ulx9IYOy7kJ86AFbWj9J6wX3ItKgadQ9GDOLEKWirpIqbRr77+mdpi9mM8puyMkozDJpAHHsM9SIuyiaFlxfSG9drLT31b3/U0OhTqPEWNhCkJKiIv7q7lgO+rXt43MSdCDpEJXyduZKBxkMikMoeI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779446008; c=relaxed/simple; bh=OC9I9ays2hj7Jffo+4Ohri3Oya/4mlwWbN2Oqlu0vZE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Y2eBmX2ak5uJPeTbxbCVRYWzUtqimHsCokMFw7wQK5weJLck1Su9KoshKH73ia7wmrLtnefsCcoKIX8ZMpkvoM9HjS0KsgT9Qi6qMM2lh3oKAgB+Uxsys7PgvxrDpClU4IP18BkD6aOSiaFf2Ys4aqutED+iRcwXsxkSsk17w+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gGKq/CIz; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gGKq/CIz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDB191F00A3D; Fri, 22 May 2026 10:33:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779446006; bh=fSAKcTCjHEBP0sQv4s+o1EWc5Ccjv9UlLr1FZ7wIvhY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=gGKq/CIzLxg1eVylTmSsaymkCWKTFGI+O2LCAQD66kFGHuWu7AEA0EJlsvNO0PnQE +sihyb31rGdup1cSzTE35K5odHeZ3/eHCKeOYbV9EbYbbeLlKAny6B5p5VBmDYx2ES GZXeOEgUZAcHnVcNK6M3SVEXt1noKuLnGw0nxC0MojK5TvXJhQ6WEjgAVizgmQLpcI dDsCOpurTMS0gGQCbFYdDq9VDF2/E8KvK+CSXg9xD83/19DHSXkato+MRFH0E4vsWo NTnvBgkTQDRwspvDgy289uUsENhabwbbni7Ifovw2ttOt/+5uVb0/kPNiwfTMRJHVs dZpW2WP7j3/pw== Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfauth.phl.internal (Postfix) with ESMTP id 3329CF4008C; Fri, 22 May 2026 06:33:25 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Fri, 22 May 2026 06:33:25 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgddugeelleegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucenucfjughrpeffhffvvefukfhfgggtuggjsehttdertd dttddvnecuhfhrohhmpefmihhrhihlucfuhhhuthhsvghmrghuuceokhgrsheskhgvrhhn vghlrdhorhhgqeenucggtffrrghtthgvrhhnpeeuieejieffkeehfeffffdtkeelfeelhe fhfefhudehjeehvdffleeuvddufefgkeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehkihhrihhllhdomhgvshhmthhprghuthhhphgvrhhsoh hnrghlihhthidqudeiudduiedvieehhedqvdekgeeggeejvdekqdhkrghspeepkhgvrhhn vghlrdhorhhgsehshhhuthgvmhhovhdrnhgrmhgvpdhnsggprhgtphhtthhopeegiedpmh houggvpehsmhhtphhouhhtpdhrtghpthhtohepshhjsehkvghrnhgvlhdrohhrghdprhgt phhtthhopegrkhhpmheslhhinhhugidqfhhouhhnuggrthhiohhnrdhorhhgpdhrtghpth htoheprhhpphhtsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehpvghtvghrgiesrhgv ughhrghtrdgtohhmpdhrtghpthhtohepuggrvhhiugeskhgvrhhnvghlrdhorhhgpdhrtg hpthhtoheplhhjsheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepshhurhgvnhgssehg ohhoghhlvgdrtghomhdprhgtphhtthhopehvsggrsghkrgeskhgvrhhnvghlrdhorhhgpd hrtghpthhtoheplhhirghmrdhhohiflhgvthhtsehorhgrtghlvgdrtghomh X-ME-Proxy: Feedback-ID: i10464835:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 22 May 2026 06:33:23 -0400 (EDT) Date: Fri, 22 May 2026 11:33:18 +0100 From: Kiryl Shutsemau To: SeongJae Park Cc: akpm@linux-foundation.org, rppt@kernel.org, peterx@redhat.com, david@kernel.org, ljs@kernel.org, surenb@google.com, vbabka@kernel.org, Liam.Howlett@oracle.com, ziy@nvidia.com, corbet@lwn.net, skhan@linuxfoundation.org, seanjc@google.com, pbonzini@redhat.com, jthoughton@google.com, aarcange@redhat.com, usama.arif@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, kvm@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v2 03/14] mm: rename uffd-wp PTE accessors to uffd Message-ID: References: <20260514013127.148945-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260514013127.148945-1-sj@kernel.org> On Wed, May 13, 2026 at 06:31:27PM -0700, SeongJae Park wrote: > On Fri, 8 May 2026 16:55:15 +0100 "Kiryl Shutsemau (Meta)" wrote: > > > Userfaultfd RWP will reuse the uffd-wp PTE bit to mark access-tracking > > PTEs, alongside the write-protected ones it already marks. The bit's > > meaning now depends on the VMA flag (WP or RWP), not on its name. > > > > Rename the kernel-internal names that describe the bit: > > > > - pte/pmd/huge_pte accessors (and swap variants) > > - pgtable_supports_uffd() capability query > > - SCAN_PTE_UFFD khugepaged enum > > > > The ftrace string emitted by mm_khugepaged_scan_pmd for this enum is > > kept as "pte_uffd_wp" so existing trace-based tooling keeps matching. > > > > Pure mechanical rename -- no behavior change. > > > > Signed-off-by: Kiryl Shutsemau > > Assisted-by: Claude:claude-opus-4-6 > > Reviewed-by: Mike Rapoport (Microsoft) > > Reviewed-by: SeongJae Park Thanks! > [...] > > @@ -4934,10 +4934,10 @@ int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src, > > softleaf = softleaf_from_pte(entry); > > if (unlikely(softleaf_is_hwpoison(softleaf))) { > > if (!userfaultfd_wp(dst_vma)) > > - entry = huge_pte_clear_uffd_wp(entry); > > + entry = huge_pte_clear_uffd(entry); > > set_huge_pte_at(dst, addr, dst_pte, entry, sz); > > } else if (unlikely(softleaf_is_migration(softleaf))) { > > - bool uffd_wp = pte_swp_uffd_wp(entry); > > + bool uffd_wp = pte_swp_uffd(entry); > > Just curious. Is the variable name intentionally kept to avoid unnecessary > change? No, I've missed this. Will fix. -- Kiryl Shutsemau / Kirill A. Shutemov