From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 618CE472760; Fri, 5 Jun 2026 07:10:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780643455; cv=none; b=VorCeAQptLVh8raPmJvU8A/JI2TIyIHp9tmROTHOb42Wvp+/QH+p+LWZz2XNYJh1QZWMhrsjdEX6GTJyUDldqnt7VNvwspE6ue/+WJf9ULRLkcNzIXeH1TEBJn0b4X/fOLenr7x1j9Bb3J1MyITqo5yyIqN2mkkuEx5FvuUoUbk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780643455; c=relaxed/simple; bh=4yU/OCT1/T1FXA0lrkmmn/qIMb1C05A/1eJwZ2V5vFc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VSRAxfX5prAqEhq8CXTzfnlDWfuDgGVrswt4y5TE9zQzzHkTZFJVGFEKteAj/kUAj/tcV8gCO35q5crZLEDX6Vbm2Nzx7pSnfokVLF+dzD99V6//fLAWLqD3/6IHw/4onwFfkv5lqRHm/WjTh1ZdlYlY8ou50yKPIdZz0az9dXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oZCVS0xb; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oZCVS0xb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB0391F00893; Fri, 5 Jun 2026 07:10:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780643454; bh=ZqZI8J9nTj7elKUH2Z6q9tM5bBMN9BGf/tMB5WQW7IU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=oZCVS0xbB3ept8DSn8zmqUUp5iXMZd7d9yU5v/PwJWzkKOaLp1f1qTcOsgpasGA1A dkiA4k7pvlrfxyr98E/QLxnp+BzfE5RE/HZmtWNLb6y1HOVc5hyZF44o9skt/x1j60 0/BFeEsP738URWphjAne+2IJOJJR6xSfgDdae58W6MsLLoiqloHS4ooxUoiQfe0DjD OenxifPH2pOGaQdGwUcqJR3aJ1yBxx0uhzF1XDLn8HfGdYc5wO612zXTs7Y/1FfYew OMxNMJHIlQ5KtQ/txW7hEDbmE6smArXshNunEk7YVeCCNBxbcfzMKtLMoX3gqE1TYB 9szQz5APYxn6w== Date: Fri, 5 Jun 2026 07:10:49 +0000 From: Tzung-Bi Shih To: Randy Dunlap Cc: Jonathan Corbet , "Rafael J. Wysocki" , Greg Kroah-Hartman , Danilo Krummrich , Shuah Khan , Pavel Machek , Len Brown , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, driver-core@lists.linux.dev, tfiga@chromium.org, senozhatsky@chromium.org Subject: Re: [PATCH v2 2/3] PM: dpm_watchdog: Allow disabling DPM watchdog by default Message-ID: References: <20260604090756.2884671-1-tzungbi@kernel.org> <20260604090756.2884671-3-tzungbi@kernel.org> <32fda49e-f246-4fae-9e4e-05c12fdb3ea6@infradead.org> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <32fda49e-f246-4fae-9e4e-05c12fdb3ea6@infradead.org> On Thu, Jun 04, 2026 at 09:53:11PM -0700, Randy Dunlap wrote: > On 6/4/26 2:07 AM, Tzung-Bi Shih wrote: > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > > index 00375193bd26..0a0d5340b0c7 100644 > > --- a/Documentation/admin-guide/kernel-parameters.txt > > +++ b/Documentation/admin-guide/kernel-parameters.txt > > @@ -5399,6 +5399,14 @@ Kernel parameters > > function to NULL. On Idle the CPU just reduces > > execution priority. > > > > + power.dpm_watchdog_enabled= > > + [KNL] Enable or disable the device suspend/resume > > I think that [KNL] isn't very useful here (nor in many of its uses in > kernel-parameters.txt). > What is required to use this option are: > CONFIG_PM_SLEEP, CONFIG_DPM_WATCHDOG > You should convey that information somehow. > > Also, in kernel-parameters.txt, "pm_async=" is only valid when [PM] > is enabled, but "PM" is not defined/described anywhere. > That should be added near the beginning of kernel-parameters.txt (in > alphabetical order). Thank you for your review. Will fix them in the next version.