From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 177E537BE7D; Fri, 26 Jun 2026 16:05:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782489906; cv=none; b=dGmJ2DX5JPDpCV5sMi5BJVuaNtS769pcfAJhWeFn2/Acv3MFwPlMzaTQA6uVGvwLyP/Wrl/rL1xYCMT2b30UowJyWoKRabgWdNPXw8H/ZC5tAFSkbtpkmnxoCVUb/vqGXUVeQj7HNRENKTZp1v/Od5l+FCreUrA6CwzwojXRNgs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782489906; c=relaxed/simple; bh=9dfevLQUJ67ZAWdkA+BetLlZXEPedxDTPylzxmLpP40=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qUf97hTXiFO5A3L1JbZDzzQrM+cFxxaZpXzt2hgkVmpBw+NAz9c05+YOeco50cdwZlITHqeh3fEt/fhk9zAleVy4f04pAf84sri8TmfcxVu2U5I6wzCaDtYCLc8xpk4u/2AyITzC2bR8jduwADW2Ah+GU+N6DIVjdQo+yatYYS4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m2yAD5pl; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m2yAD5pl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 273471F000E9; Fri, 26 Jun 2026 16:05:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782489904; bh=agO4Z1h9DZD6dkyDAR6EVjfAZLNbhj4L7fvPd9Abd4w=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=m2yAD5pl8rbGleJHS+ABi6ZH4UQHFWpScWGcAX75oANTRayJAz5+2U/6oxd/KLhiq K0od4RJ1rHNcVkQPMdDvZ27wvj/IOap5j7W4F6yBhlyYd81AMvGzrxHoj4bohW7L0M FmIgs8iq3G6XRiSFH/WE24hZGGBpEl8/ZhVvipFVbOz8KrZB6pbpTGoPzYJkpHrJao qMEiial0USyABZw8ZXoOTRrdIXkrXG0c66oh0EskfDhlXdD5BJEwtdY5sgRYndtJac GWohA+isgpMlemKokXw2EnoF2CYzCsKCd3TjPAp11wnpCwiJODCC2gUscYjnkVGuaE YyXSlAdT99Rbg== Date: Fri, 26 Jun 2026 09:05:02 -0700 From: Drew Fustini To: Conor Dooley Cc: Adrien Ricciardi , Alexandre Ghiti , Atish Kumar Patra , Atish Patra , Babu Moger , Ben Horgan , Borislav Petkov , Chen Pei , Conor Dooley , Conor Dooley , Dave Hansen , Dave Martin , Fenghua Yu , Gong Shuai , Gong Shuai , guo.wenjia23@zte.com.cn, James Morse , Kornel =?utf-8?Q?Dul=C4=99ba?= , Krzysztof Kozlowski , liu.qingtao2@zte.com.cn, Liu Zhiwei , Palmer Dabbelt , Paul Walmsley , Peter Newman , Radim =?utf-8?B?S3LEjW3DocWZ?= , Reinette Chatre , Rob Herring , Samuel Holland , Sebastian Andrzej Siewior , Tony Luck , Vasudevan Srinivasan , Ved Shanbhogue , Weiwei Li , yunhui cui , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, devicetree@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-doc@vger.kernel.org Subject: Re: [PATCH v2 7/8] dt-bindings: riscv: Add generic CBQRI controller binding Message-ID: References: <20260624-dfustini-atl-sc-cbqri-dt-v2-0-2f8049fd902b@kernel.org> <20260624-dfustini-atl-sc-cbqri-dt-v2-7-2f8049fd902b@kernel.org> <20260625-cupbearer-failing-9ce0abf97b93@spud> <20260626-immobile-staining-c825a86bd613@spud> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+0HGToKbj2BaC/Io" Content-Disposition: inline In-Reply-To: <20260626-immobile-staining-c825a86bd613@spud> --+0HGToKbj2BaC/Io Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 26, 2026 at 04:44:56PM +0100, Conor Dooley wrote: > On Thu, Jun 25, 2026 at 12:21:52PM -0700, Drew Fustini wrote: > > On Thu, Jun 25, 2026 at 05:19:28PM +0100, Conor Dooley wrote: > > > On Wed, Jun 24, 2026 at 06:38:35PM -0700, Drew Fustini wrote: > > > > Document the generic compatibles for capacity and bandwidth control= lers > > > > that implement the RISC-V CBQRI specification. The binding also > > > > describes the common riscv,cbqri-rcid and riscv,cbqri-mcid properti= es, > > > > and the optional riscv,cbqri-cache phandle that links a capacity > > > > controller to the cache whose capacity it allocates. > > > >=20 > > > > Assisted-by: Claude:claude-opus-4-8 > > > > Co-developed-by: Adrien Ricciardi > > > > Signed-off-by: Adrien Ricciardi > > > > Signed-off-by: Drew Fustini > > > > --- > > > > .../devicetree/bindings/riscv/riscv,cbqri.yaml | 97 ++++++++++= ++++++++++++ > > > > MAINTAINERS | 1 + > > > > 2 files changed, 98 insertions(+) > >=20 > > Thanks for the review. > >=20 > > [..] > > > > +properties: > > > > + compatible: > > > > + oneOf: > > > > + - items: > > > > + - description: Tenstorrent Ascalon Shared Cache > > > > + const: tenstorrent,ascalon-sc-cbqri > > > > + - const: riscv,cbqri-capacity-controller > > > > + - enum: > > > > + - riscv,cbqri-capacity-controller > > > > + - riscv,cbqri-bandwidth-controller > > >=20 > > > Please modify this, as has been done for other riscv spec related > > > bindings, to let people get away without using device-specific > > > compatibles. > > >=20 > > > In this case, you can just delete the first entry from this enum, sin= ce > > > it already has a user and only have to implement this feedback for the > > > second entry. > >=20 > > Would this work? > >=20 > > properties: > > compatible: > > oneOf: > > - items: > > - enum: > > - tenstorrent,ascalon-sc-cbqri # Tenstorrent Ascalon Shar= ed Cache > > - const: riscv,cbqri-capacity-controller > > - items: > > - {} > > - const: riscv,cbqri-bandwidth-controller >=20 >=20 > Should do, yes. I question the need for a comment though, seems pretty > evident from the compatible what it is. I was thinking people may not know that 'sc' is the Shared Cache. I probably should have shortend the comment to 'Ascalon Shared Cache'. Anyways, I can drop it. Thanks, Drew --+0HGToKbj2BaC/Io Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSy8G7QpEpV9aCf6Lbb7CzD2SixDAUCaj6jIAAKCRDb7CzD2Six DDeVAP4vM3GolJCGac4uVQXKOv97J+exeAUD6SDerZ7kBTnOHwEA/LLJW1DYXrzT s/QHLT4rwkG8YmW8CkD6ac5wfPrwywc= =TTDz -----END PGP SIGNATURE----- --+0HGToKbj2BaC/Io--