From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a6-smtp.messagingengine.com (fhigh-a6-smtp.messagingengine.com [103.168.172.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC0463B71B1; Mon, 15 Jun 2026 22:51:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.157 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781563871; cv=none; b=qA7+KidzY3CgdQQvIOcTrlNn6Tel6cOZJae7m7BCEOZ5J1Ad74v+3t9h0lsps5RRQQvbPD/KRhe+RI3NmwqDd5+ysSZLt+d6CMNA+29QVjgZd+fNn6fdOnqH1DU1Theu+VNk6+5WN6eCy6tLAyOl9rtYU+wOvSI7J+KpXCcMLrQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781563871; c=relaxed/simple; bh=HDHe7YkoetYyloltH6XURO2F6igGsU2azkCj/UkQD0Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nW+rQO3I7MIeVrE4+wDXEzjZ99kxfsBHd5SwD4q1ncUyAOdOAUkSTeZNdmPGlI8jsXECgT0apV4yFbePhhBf7XqBp220A8QrdE7U09O3tbayxf9hd3xtJgZEBc9dqS55wqXFNDO0jDQEs4xHSYY4eZnFnF5gRrAs5Lv/cj7Z3zI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=LmXpPuzv; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=ID4O7D9k; arc=none smtp.client-ip=103.168.172.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="LmXpPuzv"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="ID4O7D9k" Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfhigh.phl.internal (Postfix) with ESMTP id A26911400016; Mon, 15 Jun 2026 18:51:08 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Mon, 15 Jun 2026 18:51:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1781563868; x= 1781650268; bh=kLMhR1eeQ42+DWD/TLCVQ6ksLQ40rd4N/1skfaWj9/0=; b=L mXpPuzvfyugOX4NT7SU1KsZq/u/fXDDQZaSR5yDvGtGSok20pdqauPxxjzAg0eGm 1QgWvRJhVN0UseGIlYeYXHCouoK+eHsPQikgNiKjW3IjWLqJdSkGSib63chtt1mL rC5gABXNY3Uv6XuOrYURfpZJRiZp+EVDeKp5ona689BAPuk195DQ6t9TBwF5w9J/ aDMfub88Pqp2eovHm4we9mzwaxvZeTKIP4LzSOXpapPmYEj27/cu24Fqu7+SxRmY JoPy9r4LcATMCrcbfqiwWy4K92zCrrUkBjlUAwOY8vn4UPRpcwkYvY1DV/CKYeMt KhsL9SQdC35TRYdlQe9qQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1781563868; x=1781650268; bh=kLMhR1eeQ42+DWD/TLCVQ6ksLQ40rd4N/1s kfaWj9/0=; b=ID4O7D9kHcyOKOafP7D2hWpIGGELlmuDMt3lmlY6t5qsX6yOSDl 0QgEFKtG7bjbyZweavtkVCPweJm+drtZ4US581kayDKaeQcvO1Z6zQ9+nEoxHblQ QTzgJskAnWvrkwgndFetUfNnqgkc0Qt6gDUoaAayjaQE6ZatM69MILwN+fcrplsw 9+RcrGIBG9s+GZHwOOKO4dB9ycpbntUG+CFraeta8Xp1x/edq8QJ52odOk3/9saL RM1+bnxXo+z5GPYJd0fc/oa+xduB3Hh6OG762vlcJXnp+AtAuBjlg/CpOkzKwTUO amGT7ltHY2IpIU5lZFdjdQmucdJyn4DPdiA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGUhEvLyB9ig41WxJtSC1xHT3ItJlvcMxkv67VI7SLdKksztZzaEJoLX1RgraCNY5 g26R8gAWu3mWoe1xtyMhipjz+Jk2ojUp21EEAtQZZKYU2x8r5wpBga9TC78Gvh2/5+FCqq od6xTmp9rOzNV8Wr8v7iV74r08b7rx7kjIZxE7UBmyjbSCwEJ0Uol6DPNjIrlCB4QV7Jii wobwG72iKTrrD8/XP6nYgnLennenpaoAPoHTQcQPVZp/+xENu+zCmijAdBb7MrFWVKaUIt FoiNDvLFxG0NkCT0mHi/TJVZ5Gz5waohMhoFZ+CTrb00q68imu66VsZ5OOY4maU4+uEQCi TWXFZVkkP5vYz+alkqmvDT8pkh/NIzxvOhwzwQrokoJNi5MDW6JfjvxKsLtwvXM/Ohsq/r V4Bcclw99iEHU5i8yuRy4iZVUimXKcmpqz+Sn+0xvfXvBAAJoRpkxxDc37FC1NSHRmA/7Q tBARLk9h8RA+KNnDjqVubXkDgOjkZdAkOnbflBB3UW9v2/RI4GiVy0dE7Dbx5ykEsMJDrC ILctSpoDoooYOBpiR/uF/VXfvKjoSV4FUo3kWYBknoKviT3QH9A7NNaVaGNZDbg0fwdZtS qxxp+uKDmbljHDGe4ma72n+DoghoWtHL3Y5M9XxHDvc62PgGtlwztvYQjUNg X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 15 Jun 2026 18:51:07 -0400 (EDT) Date: Tue, 16 Jun 2026 00:51:06 +0200 From: Sabrina Dubroca To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org, john.fastabend@gmail.com, jiri@resnulli.us, skhan@linuxfoundation.org Subject: Re: [PATCH net-next v2 3/3] docs: net: fix minor issues with strparser docs Message-ID: References: <20260613165846.2913092-1-kuba@kernel.org> <20260613165846.2913092-4-kuba@kernel.org> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260613165846.2913092-4-kuba@kernel.org> 2026-06-13, 09:58:46 -0700, Jakub Kicinski wrote: > Not sure if anyone would read this doc, but the API has evolved > since it was written. Update to: > - show the int return type for strp_init() > - refer to strp_data_ready(), not the old strp_tcp_data_ready() name > - direct users to strp_msg(skb) for strparser metadata instead of > treating skb->cb as struct strp_msg directly > > Signed-off-by: Jakub Kicinski > --- > CC: corbet@lwn.net > CC: skhan@linuxfoundation.org > CC: linux-doc@vger.kernel.org > --- > Documentation/networking/strparser.rst | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) Reviewed-by: Sabrina Dubroca > @@ -123,9 +123,9 @@ Callbacks > should parse the sk_buff as containing the headers for the > next application layer message in the stream. Last time I had a look at strp, I was thinking about removing half of the callbacks, since they're never used. Not a big simplification, but it would remove a few indirections when reading the code. -- Sabrina