Re: [PATCH RFC v6 4/5] iio: osf: add authenticated stream parser

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Tue, Jun 30, 2026 at 02:12:06PM +0900, Kim Jinseob wrote:

And do not top-post!

> Understood. I missed applying the earlier style feedback consistently
> across this file, and I should have explicitly replied where a previous
> comment was not addressed.
> 
> I will these:
> - reuse the existing OSF magic definition instead of duplicating a byte array
>   in the stream parser;
> - use loop-local variables where the variable is not used outside the loop;
> - rework the stream error handling so authenticated and unauthenticated
>   failures are handled deliberately;
> - either update partial_frames where appropriate or remove the unused
>   statistic.
> 
> I will also check lore for the previous versions and track the earlier review
> comments before posting another revision, making sure each one is either
> addressed in code or explicitly answered.

...

> > > Come again when each of the given comment will be either addressed or argued.
> > >
> > Likewise.  Please make sure to address every comment either through
> > changes or through reply to the earlier thread.  Perhaps some emails
> > have gone astray (it happens!). It can be a good idea to take a quick
> > look at lore.kernel.org to make sure you aren't missing any feedback
> > on a previous version.

-- 
With Best Regards,
Andy Shevchenko