From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 519CA3F0A94; Wed, 1 Jul 2026 09:00:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782896408; cv=none; b=SgoBLOPJvx2tts/EKHviaYIu8Eh16wdwyP/5z36GhrXOd6SdxEMuVkmTXbPg4Er8D6E92Frrz3ANw+K9QXCWeg6BvI9cPIK0MxExKd2ZpXi7OJ1YZ0IE+4XRdFE0lVxlZsM1SNntaaeZmo0luDmfBWSs/xZFad/pMyuPkeWfqMs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782896408; c=relaxed/simple; bh=nHgJI21HPY161RCXXPvHhSW5/EGkSu5uqE1nrC9+G4U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DMA/CzStr2IjDWhQxW2AxAPCzC6FcYKwOvmK4Q3Txd4nlnupqd156n6WVA8FIrIR3O+qkrAQ4ZMhN+lK7Bjix40e61BVr9NODkqm9bCoxisX/OzorRNGLtSOdUr/0FTiUUA2kciMQXfnQMPKNgNdaYPrcW9pUOnm5fzojVzPGPk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=L/sK1EsA; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="L/sK1EsA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782896407; x=1814432407; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=nHgJI21HPY161RCXXPvHhSW5/EGkSu5uqE1nrC9+G4U=; b=L/sK1EsAn2rV9wO0o1NXBwhP/ZY8i0sZWdLVpsuKvZEWCvvk6jlCAHQF pXJKrKruNDpcHYhE+Rlv0GDncg4m5ALoUqfuUULcKhDOwtsORHkTHyqSB QVdfLpa81JLjGAG/Kz/p/8tI91+spkLofHNpxrexBsf8jFAZOhmlzJhOG yjsC2ZX3QnZSIwC+DDyDtRwp6JlM28mwNj6DnT4zJYJyba7jfNRd5nPHG tycQudpfvVnLIz9w9jMOpSJyRX+fiWtFrslZK7zP7yBxxMpvmqQHS0Al7 xjH0LwFLSRgi2artqXquC6fSOFhSkGEHWLjB0dlde3tolCvWLG9nmGYYQ w==; X-CSE-ConnectionGUID: 4YMMw1gKRMyGwk8CSGI4ZQ== X-CSE-MsgGUID: kP7wENKIRhuvkmTSlpVfBw== X-IronPort-AV: E=McAfee;i="6800,10657,11833"; a="109170685" X-IronPort-AV: E=Sophos;i="6.24,235,1774335600"; d="scan'208";a="109170685" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2026 02:00:06 -0700 X-CSE-ConnectionGUID: qmADDl3uRZuJqwO2sQFarg== X-CSE-MsgGUID: ULkSYhUmQ0SqQeGXnXEstQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,235,1774335600"; d="scan'208";a="254425816" Received: from conormcd-mobl2.ger.corp.intel.com (HELO localhost) ([10.245.244.65]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2026 02:00:02 -0700 Date: Wed, 1 Jul 2026 12:00:00 +0300 From: Andy Shevchenko To: "David Hildenbrand (Arm)" Cc: Hugh Dickins , Anshuman Khandual , linux-mm@kvack.org, Rasmus Villemoes , Sergey Senozhatsky , Petr Mladek , Steven Rostedt , Jonathan Corbet , Andrew Morton , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Lorenzo Stoakes Subject: Re: [RFC V2 3/3] mm: Replace pgtable entry prints with new format Message-ID: References: <20260610043545.3725735-1-anshuman.khandual@arm.com> <20260610043545.3725735-4-anshuman.khandual@arm.com> <4a416383-62f5-1716-8e04-a2ee1f89a864@google.com> <3afa822d-3cc9-1068-9a10-94a5f2e4d29a@google.com> <90b5cd31-87ed-4ef7-86cc-458b9e06b02d@kernel.org> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <90b5cd31-87ed-4ef7-86cc-458b9e06b02d@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Jun 30, 2026 at 03:36:58PM +0200, David Hildenbrand (Arm) wrote: > On 6/16/26 08:19, Hugh Dickins wrote: > > On Mon, 15 Jun 2026, David Hildenbrand (Arm) wrote: > >> On 6/12/26 23:26, Hugh Dickins wrote: ... > +#define PTVAL_STR_MAX (sizeof(u64) * 4 + 1) > + > +static void ptval_bytes_to_str(char *buf, size_t buf_size, > + const void *entry, size_t entry_size) > +{ > + if (WARN_ON_ONCE(buf_size < entry_size * 2 + 1)) { > + snprintf(buf, buf_size, "overflow"); > + return; > + } If you want to make this available for dynamically allocated buffers of the exact size, this function should return the result of snprintf() as int along with accepting NULL, 0 case. > + switch (entry_size) { > + case sizeof(u32): > + snprintf(buf, buf_size, "%08x", *(const u32 *)entry); > + break; > + case sizeof(u64): > + snprintf(buf, buf_size, "%016llx", > + (unsigned long long)*(const u64 *)entry); Not sure why castings are needed here and below. > + break; > + case sizeof(u64) * 2: { > + const u64 *val = entry; > + > + if (IS_ENABLED(CONFIG_CPU_BIG_ENDIAN)) > + snprintf(buf, buf_size, "%016llx%016llx", > + (unsigned long long)val[0], > + (unsigned long long)val[1]); > + else > + snprintf(buf, buf_size, "%016llx%016llx", > + (unsigned long long)val[1], > + (unsigned long long)val[0]); > + break; > + } > + default: > + snprintf(buf, buf_size, "unsupported"); > + break; > + } > +} -- With Best Regards, Andy Shevchenko