From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34428372073 for ; Fri, 10 Jul 2026 17:06:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783703209; cv=none; b=s/FvzCehsdyfxGtLRxOoHwIMha7hGHOi8dPGJ17TWt6pV6bMWbqJAzGWcwHw3g9jESrFf+WMWKlwd6ovRfORAMdU549Jm5XH8bv9wqJxT7hrWslH53+o4nMw+1q2G/kqM47UF6leAJs+Hb7fqWD/vJiTI/pC3uaz62nWTOo1vVs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783703209; c=relaxed/simple; bh=9lSzgAW8+FmEe+Hp7Rve4vbC7ZImzNSGMC/0E8OnJU8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iyWcq3Z+5wCMijL3tkanELPmogc1HIUXHRArTdgM1n7mOE5ADqXEbKgLROXrIHxBxAOGLPihZz3DqIAck0EB8mRPxHkWOuSJYxd5giSLACOi8Zwzzf8wphJWVSV0k3l5V9FTT8hOtKpJ0PWPapgVWxGsQDiyV0mDf+H88U+kaho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KELdLpIE; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KELdLpIE" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-84847f60deeso2034038b3a.0 for ; Fri, 10 Jul 2026 10:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783703208; x=1784308008; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=SpFBfA7wdgGokfuzCR83lopKSZdMUZgccIdXLTCA/gs=; b=KELdLpIEG69QzorDWc9dOz8Phaqk0PdwKcMWah/KS+00zAtkxakyNOocwduHCVZHBH xvKjGEVu7mCXvCBwEAEi0dfWYLj6Pk29lGoTX/JBVr8nOY/M2mGzrNL8r4UwoHIpeWEQ J1bVxtTNnjRcV3ILNFDKqKCcFKO1AL/h+xr5iKGRmyf8hlzjGCQFtIWbHDml3HdjCGfp F5Tjao/4E3jfWuNeuNdEC0v6BNRNxhmiaghwC98VdS6K9tFxaL7hqO16oU2RVsMFGNhf oV6EVy6Cd2EKPsm7qSZPquBndbMcyOw0MCbbYHLayOZfDBvBQzaNhHCna93v4kDIzD+W t8Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783703208; x=1784308008; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SpFBfA7wdgGokfuzCR83lopKSZdMUZgccIdXLTCA/gs=; b=iMZdBrnrwJukEoOoFX8TZQzzfPyrg87naP8XriIUiuDjK1fBsoYG15nYExYA6Yc1+0 cuH9pUe66eT5uMxAHcrc8HR1WP0INXFbu9+fbeQBdLaxNF8NL9QL5dvwaeTKzStXlol5 FBr8f64UBevs3++PC3nJj44kHMML9tXFytTg2HIVrWsbjBq6xlNDmYuRv88kuuaC3AYF lp06f7qFoTrle7Y1dskXZR0RDI4yUslJNe9T8UMUqRLDKAxTfE9k3qRK0dNk2JE6J2g5 DCdezkQlGzBydAutabYH7cJOa+rC7yciPnrmpOgf9gpJ+lrWUARh/7qSsnNuU82Z2Sei PC0Q== X-Forwarded-Encrypted: i=1; AHgh+RqgmsVYbsSTPOxEVt/0UpejW+mRTLV9UgQcoQ5kIsbG3d711FTR2cWVOE1BdGpTEoJux91UkXSpoYw=@vger.kernel.org X-Gm-Message-State: AOJu0YwAKje8WIXou3p9uOFTLuDd8yTQlkS2Ycdw4EPPWMyQecr3kS2c bivyrHXrq5+UKkkBNwfvjT+RYGbPQlGBSzO6V0ZeTjzSXtasoyDg1bXC X-Gm-Gg: AfdE7cncsnBai2leiUgCIlJnROMRp/mMubJGvfvfQ7wyMaebwqNXMQdG5TCw1Ak2tSg hRowrf4XFoMXqAdXacc9bWfWZIp4RAUkoRxrsY6BMP9NNKtLCNtzwBs1mfafB1L22Cxf4vnBryW mIzoaiRmuoFMfeQhgJlWnYmawt1+R14/x98s11CUmW19NtmtMDPA88Sbuu8EgPxRgCzR6LZGnZJ jJIRyCKIAJ4aw+Ap0ZwCF6Se8HV7q96wf0EC3nwAzJqF44gaOJjiUo+QRO4MTPqXa4JFH1imqEW 6ijflKesQIcjLiBNb6xcAIIBBlHXIGnLzLx5VgAfHiuYFL0LWYyGZqntjU4M2lAyCLlNl1zrSMv 3JOOpAdnHvZ6MPh1rV1S4fAossJJHfQAzih22arkCoX8yD0dBTDYHP7fMapRQjOGudBvMC02bim N6KKGnGchk6C/P41edVEIRMGK23tLZdyltOKy3ic9inBmgHcXtqOlVe2g= X-Received: by 2002:a05:6a20:d494:b0:3c0:9acb:400 with SMTP id adf61e73a8af0-3c0f13a6583mr4025578637.37.1783703207546; Fri, 10 Jul 2026 10:06:47 -0700 (PDT) Received: from skinsburskii (c-98-225-44-182.hsd1.wa.comcast.net. [98.225.44.182]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3a2e42bsm5458929a12.30.2026.07.10.10.06.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 10:06:46 -0700 (PDT) Date: Fri, 10 Jul 2026 10:06:44 -0700 From: Stanislav Kinsburskii To: Jason Gunthorpe Cc: airlied@gmail.com, akhilesh@ee.iitb.ac.in, akpm@linux-foundation.org, corbet@lwn.net, dakr@kernel.org, david@kernel.org, decui@microsoft.com, haiyangz@microsoft.com, kees@kernel.org, kys@microsoft.com, leon@kernel.org, liam@infradead.org, lizhi.hou@amd.com, ljs@kernel.org, longli@microsoft.com, lyude@redhat.com, maarten.lankhorst@linux.intel.com, mamin506@gmail.com, mhocko@suse.com, mripard@kernel.org, nouveau@lists.freedesktop.org, ogabbay@kernel.org, oleg@redhat.com, rppt@kernel.org, shuah@kernel.org, simona@ffwll.ch, skhan@linuxfoundation.org, surenb@google.com, tzimmermann@suse.de, vbabka@kernel.org, wei.liu@kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH v7 2/8] mm/hmm: add hmm_range_fault_unlocked_timeout() for mmap lock-drop support Message-ID: References: <178345345668.660027.2952911919681614557.stgit@skinsburskii> <178345362182.660027.12809852179204464964.stgit@skinsburskii> <20260710163835.GR118978@ziepe.ca> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260710163835.GR118978@ziepe.ca> On Fri, Jul 10, 2026 at 01:38:35PM -0300, Jason Gunthorpe wrote: > On Tue, Jul 07, 2026 at 12:47:01PM -0700, Stanislav Kinsburskii wrote: > > hmm_range_fault() requires the caller to hold the mmap read lock for the > > duration of the call. This is incompatible with mappings whose fault > > handler may release the mmap lock, notably userfaultfd-managed regions, > > where handle_mm_fault() can return VM_FAULT_RETRY or VM_FAULT_COMPLETED > > after dropping the lock. Drivers that need to populate device page tables > > for such mappings have no way to do so today. > > sashiko could not apply v7 for some reason but the remarks on v6 > seemed meaningful, did you see them were they delt with? > Yes, I dealt with them. > https://sashiko.dev/#/patchset/178336023903.504354.7500950448226027718.stgit%40skinsburskii > > > diff --git a/Documentation/mm/hmm.rst b/Documentation/mm/hmm.rst > > index 7d61b7a8b65b..70885f153d03 100644 > > --- a/Documentation/mm/hmm.rst > > +++ b/Documentation/mm/hmm.rst > > @@ -208,6 +208,69 @@ invalidate() callback. That lock must be held before calling > > mmu_interval_read_retry() to avoid any race with a concurrent CPU page table > > update. > > > > +Dropping the mmap lock during page faults > > +========================================= > > + > > +Some VMAs have fault handlers that need to release the mmap lock while > > +servicing a fault (for example, regions managed by ``userfaultfd``). > > +``hmm_range_fault()`` cannot be used on such mappings because it must hold the > > +mmap lock for the duration of the call. Drivers that need to support them > > +should call:: > > Given the majority of callers use this API it should probably be the > focus of the documentation and example, regulate the existing API to a > 'BTW if you really need the mmap lock, and you really shouldn't, this > exists too' > Sure, I'll update the doc to reflect it this way. > > @@ -32,6 +32,7 @@ > > > > struct hmm_vma_walk { > > struct hmm_range *range; > > + int *locked; > > Let's use bool if you have to respin this > Sure. > > @@ -651,37 +663,33 @@ static int hmm_do_fault(struct mm_struct *mm, > > fault_flags |= FAULT_FLAG_WRITE; > > } > > > > - for (; addr < end; addr += PAGE_SIZE) > > - if (handle_mm_fault(vma, addr, fault_flags, NULL) & > > - VM_FAULT_ERROR) > > - return -EFAULT; > > + for (; addr < end; addr += PAGE_SIZE) { > > + vm_fault_t ret; > > + > > + ret = handle_mm_fault(vma, addr, fault_flags, NULL); > > + > > + if (ret & (VM_FAULT_COMPLETED | VM_FAULT_RETRY)) { > > + *hmm_vma_walk->locked = 0; > > + return HMM_FAULT_UNLOCKED; > > + } > > + > > + if (ret & VM_FAULT_ERROR) { > > + int err = vm_fault_to_errno(ret, 0); > > + > > + if (err) > > + return err; > > + BUG(); > > Linux will be upset if he sees this. > > if (WARN_ON(!err)) > err = -EINVAL > It will. I copied it from GUP. I'll change it the way you propose it. > > +/** > > + * hmm_range_fault - try to fault some address in a virtual address range > > + * @range: argument structure > > + * > > + * Returns 0 on success or one of the following error codes: > > + * > > + * -EINVAL: Invalid arguments or mm or virtual address is in an invalid vma > > + * (e.g., device file vma). > > + * -ENOMEM: Out of memory. > > + * -EPERM: Invalid permission (e.g., asking for write and range is read > > + * only). > > + * -EBUSY: The range has been invalidated and the caller needs to wait for > > + * the invalidation to finish. > > + * -EFAULT: A page was requested to be valid and could not be made valid > > + * ie it has no backing VMA or it is illegal to access > > + * > > + * This is similar to get_user_pages(), except that it can read the page tables > > + * without mutating them (ie causing faults). > > + * > > + * The mmap lock must be held by the caller and will remain held on return. > > + * For a variant that allows the mmap lock to be dropped during faults (e.g., > > + * for userfaultfd support), see hmm_range_fault_unlocked_timeout(). > > + */ > > Add a comment discourging anyone from using this function and prefer > hmm_range_fault_unlocked_timeout() > Will do. Thanks, Stanislav > Other than the concern about the timeout and minor nits this looks > fine > > Jason