From: "Michal Koutný" <mkoutny@suse.com>
To: Tao Cui <cui.tao@linux.dev>
Cc: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
Jonathan Corbet <corbet@lwn.net>,
Josef Bacik <josef@toxicpanda.com>, Jens Axboe <axboe@kernel.dk>,
cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
cuitao@kylinos.cn
Subject: Re: [PATCH v2 1/2] Docs/admin-guide/cgroup-v2: document io.latency rotational vs non-rotational behavior
Date: Fri, 17 Jul 2026 16:48:40 +0200 [thread overview]
Message-ID: <alpADmJBLHpHAS_G@localhost.localdomain> (raw)
In-Reply-To: <20260717060225.2019764-2-cui.tao@linux.dev>
[-- Attachment #1: Type: text/plain, Size: 990 bytes --]
Hi.
On Fri, Jul 17, 2026 at 02:02:24PM +0800, Tao Cui <cui.tao@linux.dev> wrote:
> - The sampling window size in milliseconds. This is the minimum
> - duration of time between evaluation events. Windows only elapse
> - with IO activity. Idle periods extend the most recent window.
> + (Rotational devices only.) The sampling window size in
> + milliseconds. This is the minimum duration of time between
> + evaluation events. Windows only elapse with IO activity. Idle
> + periods extend the most recent window.
> +
> + missed
> + (Non-rotational devices only.) The number of IOs in the
> + current window whose latency exceeded the target.
A group is considered to be missing its target once
missed reaches certain ratio of total.
I would not bind to the exact value in the docs and put the explanation
to the "missed" stanza.
Thanks for documenting missed (pun intended) fields.
Besides that
Acked-by: Michal Koutný <mkoutny@suse.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 265 bytes --]
next prev parent reply other threads:[~2026-07-17 14:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 6:02 [PATCH v2 0/2] blk-iolatency: fix io.latency documentation accuracy Tao Cui
2026-07-17 6:02 ` [PATCH v2 1/2] Docs/admin-guide/cgroup-v2: document io.latency rotational vs non-rotational behavior Tao Cui
2026-07-17 14:48 ` Michal Koutný [this message]
2026-07-17 6:02 ` [PATCH v2 2/2] Docs/admin-guide/cgroup-v2: fix delay_nsec unit in io.latency doc Tao Cui
2026-07-17 14:49 ` Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpADmJBLHpHAS_G@localhost.localdomain \
--to=mkoutny@suse.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=cui.tao@linux.dev \
--cc=cuitao@kylinos.cn \
--cc=hannes@cmpxchg.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox