From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id B62737D089 for ; Sun, 18 Nov 2018 11:04:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726746AbeKRVYU (ORCPT ); Sun, 18 Nov 2018 16:24:20 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:38576 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726077AbeKRVYU (ORCPT ); Sun, 18 Nov 2018 16:24:20 -0500 X-IronPort-AV: E=Sophos;i="5.56,248,1539640800"; d="scan'208";a="356152582" Received: from abo-186-120-68.mrs.modulonet.fr (HELO hadrien) ([85.68.120.186]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2018 12:04:04 +0100 Date: Sun, 18 Nov 2018 12:04:04 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Fernando Ramos cc: dri-devel@lists.freedesktop.org, David Airlie , Maarten Lankhorst , Maxime Ripard , Sean Paul , Jonathan Corbet , Alexey Brodkin , Boris Brezillon , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Gerd Hoffmann , Archit Taneja , Andrzej Hajda , Laurent Pinchart , Lucas Stach , Russell King , Christian Gmeiner , Marek Vasut , Stefan Agner , Kieran Bingham , Linus Walleij , Shawn Guo , Julia Lawall , Gilles Muller , Nicolas Palix , Michal Marek , Haneen Mohammed , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, etnaviv@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, cocci@systeme.lip6.fr Subject: Re: [PATCH 8/9] drm: remove no longer needed drm-get-put coccinelle script In-Reply-To: <20181115221634.22715-9-greenfoo@gluegarage.com> Message-ID: References: <20181115221634.22715-1-greenfoo@gluegarage.com> <20181115221634.22715-9-greenfoo@gluegarage.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu, 15 Nov 2018, Fernando Ramos wrote: > The coccinelle script was used to rename some (deprecated) functions > which no longer exist now. > > Signed-off-by: Fernando Ramos Acked-by: Julia Lawall > --- > scripts/coccinelle/api/drm-get-put.cocci | 78 ------------------------ > 1 file changed, 78 deletions(-) > delete mode 100644 scripts/coccinelle/api/drm-get-put.cocci > > diff --git a/scripts/coccinelle/api/drm-get-put.cocci b/scripts/coccinelle/api/drm-get-put.cocci > deleted file mode 100644 > index 3a09c97ad87d..000000000000 > --- a/scripts/coccinelle/api/drm-get-put.cocci > +++ /dev/null > @@ -1,78 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0 > -/// > -/// Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and > -/// drm_*_unreference() helpers. > -/// > -// Confidence: High > -// Copyright: (C) 2017 NVIDIA Corporation > -// Options: --no-includes --include-headers > -// > - > -virtual patch > -virtual report > - > -@depends on patch@ > -expression object; > -@@ > - > -( > -- drm_connector_reference(object) > -+ drm_connector_get(object) > -| > -- drm_connector_unreference(object) > -+ drm_connector_put(object) > -| > -- drm_framebuffer_reference(object) > -+ drm_framebuffer_get(object) > -| > -- drm_framebuffer_unreference(object) > -+ drm_framebuffer_put(object) > -| > -- drm_gem_object_reference(object) > -+ drm_gem_object_get(object) > -| > -- drm_gem_object_unreference(object) > -+ drm_gem_object_put(object) > -| > -- __drm_gem_object_unreference(object) > -+ __drm_gem_object_put(object) > -| > -- drm_gem_object_unreference_unlocked(object) > -+ drm_gem_object_put_unlocked(object) > -| > -- drm_dev_unref(object) > -+ drm_dev_put(object) > -) > - > -@r depends on report@ > -expression object; > -position p; > -@@ > - > -( > -drm_connector_unreference@p(object) > -| > -drm_connector_reference@p(object) > -| > -drm_framebuffer_unreference@p(object) > -| > -drm_framebuffer_reference@p(object) > -| > -drm_gem_object_unreference@p(object) > -| > -drm_gem_object_reference@p(object) > -| > -__drm_gem_object_unreference(object) > -| > -drm_gem_object_unreference_unlocked(object) > -| > -drm_dev_unref@p(object) > -) > - > -@script:python depends on report@ > -object << r.object; > -p << r.p; > -@@ > - > -msg="WARNING: use get/put helpers to reference and dereference %s" % (object) > -coccilib.report.print_report(p[0], msg) > -- > 2.19.1 > >