From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MALFORMED_FREEMAIL, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2437C433E7 for ; Wed, 14 Oct 2020 08:19:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4020C21527 for ; Wed, 14 Oct 2020 08:19:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y91XoDmg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729110AbgJNITk (ORCPT ); Wed, 14 Oct 2020 04:19:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728922AbgJNITd (ORCPT ); Wed, 14 Oct 2020 04:19:33 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85C90C041E73; Tue, 13 Oct 2020 21:43:15 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id j136so1162742wmj.2; Tue, 13 Oct 2020 21:43:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=yAoSXHRwpGz7nBgURGl4h1iZHKvaWjYO9+dk8dtTzEM=; b=Y91XoDmgSV0T8y7s38jad1TN0OqdQ/W7/i8P2ncbuMKEZD2rOkSZiUQTJlsuYKHtPU EAZV7qv1rUsvdBWUoA886/Y95M9vZa/oxqlJFhM8q/1rrvT6J84jeJlhZi8NQCojqDrj Tes5NzvdJSB+DVYiNzB7Z+JvVuOHpaiNru8rAGagKUdC0j9MPOurw7mLoHNDCbFsPoZS n583hEDRzu2p7Kqe01AlohE9ec6ZDpWlycrOa7cs+BNDFjntEoiVKIrhkwJA/95FI/mV FSdQmGYWryAjzzPk7+g9a6lDfDynMecp9R4n0hxGRZiNmkM4V9grSiY5O0gZsORtJ/5Y 3abg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=yAoSXHRwpGz7nBgURGl4h1iZHKvaWjYO9+dk8dtTzEM=; b=JOHhwdfZKe4yD68bJyQjxY1BrYQE1wRftfXe8xqtgIenqTaOY8P4GQhtxNJ2213hOx fD+oN3qVtAq71HlsTo/SSr3bVLtG6EKsROmhtrRgm10x9+rHzWBwCEtARl/T2SJKzjTb TVDO6uIxoT9bHFvUOjeYa2623nfyFopsNSrlV4OFe2FTmlQnB1GpDzM8mcYZSEDMOFsG FJMdqGXeClm45nrcn8OcDxzyEX37aohLgT35SsGCdXRpHcPbsm8Ht9sAYGWcIax2jW5v P/NFtkz7TrMExm8Gq7gQMHL2t4CPkr2S/Agaku02sj/eBOxi15KmsGN/DhBtqSE74ZKZ +EFw== X-Gm-Message-State: AOAM532UQZiR34uXFHvqv+IdJYqNTrWuPGrD9kwZqhm8vBZwb0i5xfaJ UbiOnJKPRe5pVwy73pOOnz0= X-Google-Smtp-Source: ABdhPJxLj7cfYT+/1rNY1VWyuk/FeNLUT9YgTom+iIidb6iYPJvpU8+DuMBSQu3AZwhlP+GOUgdJYw== X-Received: by 2002:a7b:c081:: with SMTP id r1mr1410127wmh.158.1602650594160; Tue, 13 Oct 2020 21:43:14 -0700 (PDT) Received: from felia ([2001:16b8:2da8:8200:4c70:9c82:f3bf:bebb]) by smtp.gmail.com with ESMTPSA id h206sm1713989wmf.47.2020.10.13.21.43.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2020 21:43:13 -0700 (PDT) From: Lukas Bulwahn X-Google-Original-From: Lukas Bulwahn Date: Wed, 14 Oct 2020 06:43:06 +0200 (CEST) X-X-Sender: lukas@felia To: Masahiro Yamada cc: Lukas Bulwahn , Andrew Morton , Kees Cook , Michal Marek , Linux Kbuild mailing list , Jonathan Corbet , "open list:DOCUMENTATION" , Linux Kernel Mailing List , Ujjwal Kumar , linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH] kbuild: doc: describe proper script invocation In-Reply-To: Message-ID: References: <20201001075723.24246-1-lukas.bulwahn@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Wed, 14 Oct 2020, Masahiro Yamada wrote: > On Tue, Oct 13, 2020 at 11:31 PM Masahiro Yamada wrote: > > > > On Thu, Oct 1, 2020 at 4:57 PM Lukas Bulwahn wrote: > > > > > > During an investigation to fix up the execute bits of scripts in the kernel > > > repository, Andrew Morton and Kees Cook pointed out that the execute bit > > > should not matter, and that build scripts cannot rely on that. Kees could > > > not point to any documentation, though. > > > > > > Masahiro Yamada explained the convention of setting execute bits to make it > > > easier for manual script invocation. > > > > > > Provide some basic documentation how the build shall invoke scripts, such > > > that the execute bits do not matter, and acknowledge that execute bits > > > are useful nonetheless. > > > > > > This serves as reference for further clean-up patches in the future. > > > > > > Link: https://lore.kernel.org/lkml/20200830174409.c24c3f67addcce0cea9a9d4c@linux-foundation.org/ > > > Link: https://lore.kernel.org/lkml/202008271102.FEB906C88@keescook/ > > > Link: https://lore.kernel.org/linux-kbuild/CAK7LNAQdrvMkDA6ApDJCGr+5db8SiPo=G+p8EiOvnnGvEN80gA@mail.gmail.com/ > > > > > > Suggested-by: Andrew Morton > > > Suggested-by: Kees Cook > > > Signed-off-by: Lukas Bulwahn > > > > > > Applied to linux-kbuild. > > Thanks. > > > > No, not really. > > I will re-think if this is the right thing to do. > > Masahiro-san, Andrew Morton has already picked this patch in his branch; so, if we do not shout loudly, it will be merged. And we can follow up with a solid improvement for rc2. I am happy to rework the documentation and help guide and review the follow-up patches that have been sent by Ujjwal. Please provide some specific feedback what is wrong and why; I think the basic request not to rely on the execute bit from Andrew and Kees is still valid. Maybe we just need to be more specific on the rules to follow in Makefiles and have multiple examples for the different cases to consider. Thanks, Lukas