From: Julia Lawall <julia.lawall@inria.fr>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Joe Perches <joe@perches.com>,
trivial@kernel.org, kernel-janitors@vger.kernel.org,
corbet@lwn.net, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trivial: fix kerneldoc comments
Date: Tue, 23 Jun 2020 11:45:48 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2006231145350.2367@hadrien> (raw)
In-Reply-To: <20200623093228.GI4151@kadam>
On Tue, 23 Jun 2020, Dan Carpenter wrote:
> On Tue, Jun 23, 2020 at 09:59:57AM +0200, Julia Lawall wrote:
> > > > diff --git a/drivers/crypto/bcm/spu.c b/drivers/crypto/bcm/spu.c
> > > []
> > > > @@ -519,7 +519,7 @@ u32 spum_assoc_resp_len(enum spu_cipher_mode cipher_mode,
> > > > * spu_aead_ivlen() - Calculate the length of the AEAD IV to be included
> > > > * in a SPU request after the AAD and before the payload.
> > > > * @cipher_mode: cipher mode
> > > > - * @iv_ctr_len: initialization vector length in bytes
> > > > + * @iv_len: initialization vector length in bytes
> > > > *
> > > > * In Linux ~4.2 and later, the assoc_data sg includes the IV. So no need
> > > > * to include the IV as a separate field in the SPU request msg.
> > > > @@ -917,7 +917,7 @@ u16 spum_cipher_req_init(u8 *spu_hdr, struct spu_cipher_parms *cipher_parms)
> > > > * setkey() time in spu_cipher_req_init().
> > > > * @spu_hdr: Start of the request message header (MH field)
> > > > * @spu_req_hdr_len: Length in bytes of the SPU request header
> > > > - * @isInbound: 0 encrypt, 1 decrypt
> > > > + * @is_inbound: 0 encrypt, 1 decrypt
> > >
> > > odd alignments
> >
> > Sorry to have missed these.
> >
> > > etc...
> >
> > Are there a lot of other such problems? I did look through the whole
> > patch several times by hand, but perhaps it is just too big to see
> > everything.
>
> Probably the comments for spum_assoc_resp_len() could be tweaked.
>
> I had written an email about this one that Joe mentioned and
> spum_assoc_resp_len() but then I decided that it wasn't enough to worry
> about so I deleted the email instead of sending it.
OK, thanks.
julia
prev parent reply other threads:[~2020-06-23 9:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 19:37 [PATCH] trivial: fix kerneldoc comments Julia Lawall
2020-06-22 20:30 ` Joe Perches
2020-06-23 7:59 ` Julia Lawall
2020-06-23 9:32 ` Dan Carpenter
2020-06-23 9:45 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2006231145350.2367@hadrien \
--to=julia.lawall@inria.fr \
--cc=corbet@lwn.net \
--cc=dan.carpenter@oracle.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox