Re: [Cocci] [PATCH v3] documentation: coccinelle: Improve command example for make C={1, 2}

Julia Lawall
2020-08-10T20:52:41Z

[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]

On Mon, 10 Aug 2020, Markus Elfring wrote:

> > the usage of the makefile C variable flag by coccicheck.
>
> * Can it be confusing to denote an item as a variable and a flag?
>
> * Would you really like to stress here that a flag can be variable?

This is not part of the documentation, so it doesn't really matter.

Nevertheless, Sumera, there is stail an occurrence of flag in the proposed
change to the documentation, so you could indeed change that one to
variable.

>
>
> > +This variable can be used to run scripts for …
>
> Can the scope for a make command be selected also without such a variable?

If you know something that is different than what is in the documentation,
then please say what it is. Don't just ask questions.

> Will clarification requests for previously mentioned background information
> influence the proposed descriptions any further?

The point is to document the use of make coccicheck, not the C variables.
So the point about KBUILD_CHECK, while interesting, does not seem
appropriate for this documentation.

julia