Linux Documentation
 help / color / mirror / Atom feed
From: Weijie Yuan <wy@wyuan.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: "Yahya Toubali" <yahya@yahyatoubali.me>,
	"Tejun Heo" <tj@kernel.org>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Michal Koutný" <mkoutny@suse.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"open list:CONTROL GROUP (CGROUP)" <cgroups@vger.kernel.org>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst
Date: Sun, 19 Jul 2026 00:32:21 +0800	[thread overview]
Message-ID: <aluqleITl23HConW@wyuan.org> (raw)
In-Reply-To: <c8ef86b1-3ed9-47f7-9c1d-f9a0b0676bc0@infradead.org>

On Sat, Jul 18, 2026 at 09:16:29AM -0700, Randy Dunlap wrote:
> 
> 
> On 7/18/26 9:14 AM, Weijie Yuan wrote:
> > On Sat, Jul 18, 2026 at 04:19:08PM +0100, Yahya Toubali wrote:
> >> Remove trailing spaces on lines 1335 and 2197.
> >>
> >> Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>
> > 
> > Hmmm, for a file that might be modified, I wonder if it makes sense to
> > include fixed line numbers in the commit message. i.e. When the line
> > number changes, your commit message will become meaningless.
> > 
> > I'd love to hear others' comments.
> 
> I wouldn't include the line numbers...

Alright, it seems that Yahya needs to refine his commit message.

Thanks.

  reply	other threads:[~2026-07-18 16:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-18 15:19 [PATCH 1/5] Documentation: proc: fix repeated word 'page' Yahya Toubali
2026-07-18 15:19 ` [PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst Yahya Toubali
2026-07-18 16:14   ` Weijie Yuan
2026-07-18 16:16     ` Randy Dunlap
2026-07-18 16:32       ` Weijie Yuan [this message]
2026-07-18 16:56     ` [PATCH v3] " Yahya Toubali
2026-07-18 17:24       ` Randy Dunlap
2026-07-18 15:19 ` [PATCH 4/5] Documentation: fix spelling typos Yahya Toubali
2026-07-18 16:07   ` Weijie Yuan
2026-07-18 16:56     ` [PATCH v3] " Yahya Toubali
2026-07-18 15:19 ` [PATCH 5/5] Documentation: add SPDX license identifiers to RST files Yahya Toubali
  -- strict thread matches above, loose matches on Subject: below --
2026-07-18 14:40 [PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst Yahya Toubali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aluqleITl23HConW@wyuan.org \
    --to=wy@wyuan.org \
    --cc=cgroups@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=hannes@cmpxchg.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkoutny@suse.com \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tj@kernel.org \
    --cc=yahya@yahyatoubali.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox