From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7F397372ECA for ; Tue, 28 Jul 2026 16:23:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785255796; cv=none; b=h+VPWt03bR10ulcQG34E1cLkEoy889CAzRTIthsAX2yVSeMPxESwI3/HV8X297z3r6/S6ViK8d3yTLDTJpH3YCJaY+3Fwt9GqmbJgRyD3e0geVD4tEruh7PnmaX5oXUXzUU7VpJxyb7Iq7duQJ3O34M4Sg7lsbPEsokXA1jZGIc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785255796; c=relaxed/simple; bh=MuoYv/trvB+apkFilFU7ge8EmIYL0Cz7Mp4H5bYBY04=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Y59h4QQDmMK03btSlQDaIKIBLXKXBsJDs1jLA/udqSPRYl/tk/gc7WpA5VnYoyF/HyJ0/A2OOirtSS02WArR6jwZExnqoL6D3mskasRS1Che9rd92sf/9qRB9mMjzixeAJsTmJoJcdua1IrTTd9Khc3dfec5xAkbbXWrt093tSI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=hCgeHs4p; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="hCgeHs4p" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8C96A169E for ; Tue, 28 Jul 2026 09:23:09 -0700 (PDT) Received: from [10.2.11.34] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5F4D03F763 for ; Tue, 28 Jul 2026 09:23:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1785255793; bh=MuoYv/trvB+apkFilFU7ge8EmIYL0Cz7Mp4H5bYBY04=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hCgeHs4plznb1stFBuLuDmXhYpDxaF2iXHY744tE6yDTWcN5frhOdg7pbe9ZGFzHI gE4mKqKUZvmDD3rTu4z7Hjs8F/BHllcTWocgGnaZRLkgmqrFqFWwXr7f/5BSMD1kdy CUfZ14eymzcuEHCo6IFdxCyG3cCnCVdvx6IkDG6g= Date: Tue, 28 Jul 2026 17:21:58 +0100 From: Liviu Dudau To: Diogo Silva Cc: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org Subject: Re: [PATCH 12/15] drm/arm/komeda: remove dependency on DRM simple helpers Message-ID: References: <20260719-drm_simple_encoder_init-v1-0-a78c509e3062@gmail.com> <20260719-drm_simple_encoder_init-v1-12-a78c509e3062@gmail.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260719-drm_simple_encoder_init-v1-12-a78c509e3062@gmail.com> On Sun, Jul 19, 2026 at 01:35:43AM +0200, Diogo Silva wrote: > The simple KMS helpers are deprecated because they only add an > intermediate layer between drivers and atomic modesetting. > > Open-code drm_simple_encoder_init() by calling drm_encoder_init() > directly and providing driver-local drm_encoder_funcs. > > Signed-off-by: Diogo Silva Reviewed-by: Liviu Dudau Best regards, Liviu > --- > drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c > index e8cb782a6f8e..719568d9f7c2 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c > @@ -11,9 +11,9 @@ > > #include > #include > +#include > #include > #include > -#include > #include > > #include "komeda_dev.h" > @@ -635,6 +635,10 @@ static int komeda_attach_bridge(struct device *dev, > return err; > } > > +static const struct drm_encoder_funcs komeda_encoder_funcs = { > + .destroy = drm_encoder_cleanup, > +}; > + > static int komeda_crtc_add(struct komeda_kms_dev *kms, > struct komeda_crtc *kcrtc) > { > @@ -658,7 +662,8 @@ static int komeda_crtc_add(struct komeda_kms_dev *kms, > * bridge > */ > kcrtc->encoder.possible_crtcs = drm_crtc_mask(crtc); > - err = drm_simple_encoder_init(base, encoder, DRM_MODE_ENCODER_TMDS); > + err = drm_encoder_init(base, encoder, &komeda_encoder_funcs, > + DRM_MODE_ENCODER_TMDS, NULL); > if (err) > return err; > > > -- > 2.54.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯