Re: [PATCH] kbuild: let the environment set HOSTPKG_CONFIG

[Nicolas Schier <nsc@kernel.org>]

[resending from 2026-08-05, as my mail client broke the reply recipient
 list]

On Wed, Aug 05, 2026 at 01:54:35AM -0400, Trevor Woerner wrote:
> HOSTPKG_CONFIG was added so that "tooling that builds the kernel" could
> choose which pkg-config the host tools ask about their dependencies, but
> it is assigned with '=', so only a make command line assignment takes
> effect. Exporting it does nothing, silently.
> 
> That is surprising, because the other inputs to host program builds do
> honour the environment: HOSTCFLAGS, HOSTCXXFLAGS, HOSTLDFLAGS and
> HOSTLDLIBS are all read from it and documented in kbuild.rst as such.
> 
> It also matters. A cross development environment sets
> PKG_CONFIG_SYSROOT_DIR and PKG_CONFIG_PATH so that pkg-config answers
> for the target rather than the build machine. Those settings are correct
> for everything that will run on the target and wrong for a program that
> has to run on the build machine. objtool asks pkg-config where libelf is,
> gets the target's include directory, and compiles a host tool against
> the target's C library headers. Because the directory arrives as -I it
> is not treated as a system header directory, -Wno-system-headers no
> longer covers it, and the build stops on warnings that would otherwise
> be suppressed:
> 
>   usr/include/sys/cdefs.h:486: error: "__attribute_const__" redefined [-Werror]
>   tools/include/linux/compiler.h:123: note: previous definition
>   usr/include/stdio.h:449: error: redundant redeclaration of 'fscanf'
> 
> An environment that knows it is cross building can then say
> 
>   export HOSTPKG_CONFIG="env -u PKG_CONFIG_SYSROOT_DIR \
>                              -u PKG_CONFIG_PATH pkg-config"
> 
> once, in the shell it hands to the user, instead of every make command
> line growing an override.

Thank for the patch with the detailed description.  This sounds to be
consistent, but looking at the other variables that effectively can be
set via environment it looks differently to me:  Environment variables
are honoured especially for _flags_, while most variables for _tooling
paths_ (e.g. HOSTCC) are to be overriden via make command line (w/
exceptions e.g. CROSS_COMPILE, LLVM).  Right now, I am not aware of the
reason for this distinction, but before opening the gate for tooling
overrides via environment, we should think it through (aka Chesterton's
Fence).

Another simple way of not piling up overrides could be something like:

    cat <<-eof >Makefile.cross
    override HOSTPKG_CONFIG := env -u PKG_CONFIG_SYSROOT_DIR -u PKG_CONFIG_PATH pkg-config
    include Makefile
    eof

    make -f Makefile.cross

So, I suggest to wait a bit and see if further arguments come up.

Kind regards,
Nicolas