From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-192.mta0.migadu.com [91.218.175.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C90AA31F98E for ; Sun, 23 Aug 2026 15:58:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.192 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787500692; cv=none; b=I1IgK5RfDm2COV0ktL61xn0oEr76okbpHgSm0+4nKnfLX6xACwS7Tp87dos8+rhv6P2oQlnLUUCfrGaiqQqcn2WYOB7Sn5KiuZuLb3o6tGI5rPAqj9yo+6DjFgrssa69ube9vlnLAQsy6o8ij7XC2woAH8jcOHjhfwC8Jq5tYpg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787500692; c=relaxed/simple; bh=KyYEFiaplUX1+FT41+Zr80qnwqNbDWUgKZSbnVYSy+U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=J0Mnb0hV5er9Y0KRYHBzMZcJg1K47i+dcqjWOwEEA5C797uO6VfgFMW+TI/+U7WsIvgK4P3PFmVyuX8NUvt/acjkjWpQAyx6eMKUFsfntgtYzoxgzmyesVmNvwrtp7xCfrsiGxhSPWtrhf/zu+feC5x9W2sfVrOF8yuxf3Qza40= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=wyuan.org; spf=pass smtp.mailfrom=wyuan.org; dkim=pass (2048-bit key) header.d=wyuan.org header.i=@wyuan.org header.b=dm6oYOFJ; arc=none smtp.client-ip=91.218.175.192 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=wyuan.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wyuan.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wyuan.org header.i=@wyuan.org header.b="dm6oYOFJ" X-Envelope-To: linux-doc@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=KyYEFiaplUX1+FT41+Zr80qnwqNbDWUgKZSbnVYSy+U=; c=simple/simple; d=wyuan.org; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1787500686; v=1; x=1788105486; b=dm6oYOFJUxEUPynAQM0gVSnqLYH6c+M77HYH+/DCRH+3/uLsKlBWJFf1+HxpAxWA0ipsiM+W dJtY/Ll33rGTXkw/dNgw4NxDVmMQjNOhhPiI49470P3uCkF4oBbPvc0XdPrUQpjmgAJRnB7mEX/ Dv9YjRcKzOUO2699/6Hxlan3aHVZo58KS49ApcYpzMUAuyqtlWryIW6wEm4FnbEhT1CFdk0Q6YL XwK0N+tp7fHdm5TkY+xGUT2Y048/GY0vFjDDOJDSmpaLFSlOPTu9ugt1JOxxV2AaJZ5ZbHTd6FZ QAEk7c5RuksUcBDsanc9tT/pzcKItpZsL7VOEtTw+800w== X-Envelope-To: linux-doc@vger.kernel.org Received: from localhost (117.176.242.187) by smtp.migadu.com with ESMTPS id 8e63290d184e8428; Sun, 23 Aug 2026 15:57:56 +0000 X-Mizu-Trace-ID: 8e63290d184e8428 X-Migadu-Flow: FLOW_OUT Date: Sun, 23 Aug 2026 23:57:49 +0800 From: Weijie Yuan To: Manuel Ebner Cc: Mauro Carvalho Chehab , Jonathan Corbet , Shuah Khan , "open list:DOCUMENTATION PROCESS" , "open list:DOCUMENTATION" , open list Subject: Re: [Issue] sphinx: incorrect high-lighting Message-ID: References: Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, Aug 23, 2026 at 05:14:20PM +0200, Manuel Ebner wrote: > I think in the documentation is some incorrect auto high-lighting. > > https://docs.kernel.org/process/deprecated.html > > Line 272: > > when such a struct was in unions, structs of structs, etc). > with 'struct was' bold. > > Line 358: > > alone in a struct or is part of a union. These are disallowed by the C99 > with 'struct or' bold as well. > > Other files have the same issue: > E.g.: https://docs.kernel.org/process/adding-syscalls.html > > Unfortunately I don't know how to fix this. Hi Manuel, I think we can just add "or" and "was" to Skipidentifiers, so that it won't be treated as C identifiers. --- a/Documentation/sphinx/automarkup.py +++ b/Documentation/sphinx/automarkup.py @@ -51,7 +51,7 @@ Skipnames = [ 'for', 'if', 'register', 'sizeof', 'struct', 'unsigned' ] # when following struct/union/enum/typedef keywords. # Example: "a simple struct that" in workqueue.rst should not be marked as code. # -Skipidentifiers = [ 'that', 'which', 'where', 'whose' ] +Skipidentifiers = [ 'or', 'that', 'was', 'which', 'where', 'whose' ] # # Many places in the docs refer to common system calls. It is But I find more words needs to be added when looking at process/adding-syscalls.rst. Adding the falsely highlighted words one by one may not be a perfect solution, since it could potentially affect other places where those words should actually be highlighted. So I'm not quite sure what the best approach is either now. Thanks.