From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED7E95326AA; Wed, 14 Oct 2026 13:48:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791985697; cv=none; b=OUDj685/5jouGLui3lx9hbWO51dm8QfAUdMpWttikQCsTQSyEjpQzQJOw47EzamIXusu9uTV0qTKzRJnlwsvz7g704hdTk+mHjikMRiZ1PvFHKTA9adeVxXXdOOMI3szxLVpFGngTQZxpihQTAf6qz1zabnp4hdHhKK4gPsh8bc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791985697; c=relaxed/simple; bh=TmOHkYRuvrUgagwVcOvIbXXfLOe4v1DZSdUWKMO7u28=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lIUBbrC2aBhu8rcVxRZHIELZllICfuSFbD6BkTA+i7uLiJ1IAdcbjl1wqxn3GigtZ5OKGBgXSZMzbQqCGs/aGrujW5f2UXgCAh0NdUW96hHPzl4PKD7LmmZEY7LPxnsBj/ReOguXUY2dok8gE7pG79gsiTKtYq+DWqpAyFZjMQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V+Wp8E3K; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V+Wp8E3K" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 025671F00A2F; Wed, 14 Oct 2026 13:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791985694; bh=1qQSURO19kIhXzArX2xPf4oTamNn87j/Xtfb5YjYQeg=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=V+Wp8E3KHj5HfarmjhHe8oPbVzrZV+mSoVlO20FAUrZAtZZUSAvDZDvEdIUnMOfWs PdNFGYrmWub+NN20ADFsWODAqJ3aIsrh+e0rqf6NEtKzTnDVGbFIftvtvYw9KUmM8v iGP4otTdzMyc8eRi+SNMBLMAdH4SVyy9ZPMTN8W3SsuNA2PnirUtJbaab3cG+2c8ym dWi6Wa9WJU73sMqDniudv0FvXOFPy9nXKJHHb2eTUks3yFfMZcFaeA1bARgEjo5TrC r+DoskInDcsRaq/0vcO9ButTC3Nw8nmVHd613gX+AutImHQNrGT4cq/NfYOUWyHI/m oXmBkDNyfnpXg== Date: Wed, 14 Oct 2026 14:48:02 +0100 From: "Lorenzo Stoakes (ARM)" To: Fuad Tabba Cc: Catalin Marinas , Will Deacon , Marc Zyngier , Oliver Upton , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Jonathan Corbet , Mark Rutland , Randy Dunlap , Christian Borntraeger , Janosch Frank , David Hildenbrand , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Shuah Khan , Shuah Khan , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Jack Thomson , Jack Thomson , Alexandru Elisei , Vincent Donnefort , "Aneesh Kumar K.V" , Sean Christopherson , Claudio Imbrenda , Leo Soares Passos , Wei-Lin Chang , linux-s390@vger.kernel.org Subject: Re: [PATCH v4 01/14] KVM: Allow architectures to disallow pre-fault Message-ID: References: <20260923-kvm-arm-prefault-v4-0-d4b0b4dfa8c3@kernel.org> <20260923-kvm-arm-prefault-v4-1-d4b0b4dfa8c3@kernel.org> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Sep 23, 2026 at 07:52:27PM +0100, Fuad Tabba wrote: > Hi Lorenzo, > > On Wed, 23 Sep 2026 16:15:44 +0100, "Lorenzo Stoakes (ARM)" > wrote: > [...] > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > [...] > > +int kvm_arch_pre_fault_allowed(struct kvm_vcpu *vcpu) > > +{ > > + if (!vcpu->kvm->arch.pre_fault_allowed) > > + return -EOPNOTSUPP; > > + > > + return 0; > > +} > > nit: the comment above the smp_rmb() in tdx_sept_map_leaf_spte() still > says pre_fault_allowed is read by kvm_arch_vcpu_pre_fault_memory(), > but after this patch it's read here. Ack, will chase that up! > > Reviewed-by: Fuad Tabba Thanks! > > Cheers, > /fuad > -- Cheers, Lorenzo