From: Stanislav Fomichev <sdf.kernel@gmail.com>
To: "Björn Töpel" <bjorn@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
Alexander Duyck <alexanderduyck@fb.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Magnus Karlsson <magnus.karlsson@intel.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Pavel Begunkov <asml.silence@gmail.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
Simon Horman <horms@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
kernel-team@meta.com, John Fastabend <john.fastabend@gmail.com>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
Jiri Olsa <jolsa@kernel.org>,
Emil Tsalapatis <emil@etsalapatis.com>,
Ihor Solodrai <ihor.solodrai@linux.dev>,
Weiming Shi <bestswngs@gmail.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
David Wei <dw@davidwei.uk>,
Bobby Eshleman <bobbyeshleman@meta.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, io-uring@vger.kernel.org,
Mina Almasry <almasrymina@google.com>
Subject: Re: [PATCH net-next 7/7] selftests: net: Test XDP on io_uring RX
Date: Thu, 19 Nov 2026 16:31:55 -0800 [thread overview]
Message-ID: <av-Udp0GfOjxH9vq@devvm16445.scu0.facebook.com> (raw)
In-Reply-To: <20261117164700.2157816-8-bjorn@kernel.org>
On 11/17, Björn Töpel wrote:
> Native XDP must not access io_uring payload through normal packet
> helpers. Compare ordinary page-backed RX with an io_uring RX queue.
> Check header, fragment and boundary access, and verify the received
> bytes through recv() and RECV_ZC.
>
> Probe support by binding io_uring first and attaching a frags-aware
> XDP_PASS program. Skip unsupported combinations, but fail later
> attach, verifier and data-path checks. Require non-linear packets on
> the selected queue. Use XDP links so the test cannot replace another
> program, and restore header split, RSS and the flow rule.
>
> An AI review found that ignoring io_uring setup errors could turn them
> into capability skips. A process-local seccomp filter returning EPERM
> reproduced this. The new XDP test now treats setup errors as failures.
>
> Signed-off-by: Björn Töpel <bjorn@kernel.org>
> ---
> MAINTAINERS | 2 +
> .../selftests/drivers/net/hw/.gitignore | 1 +
> .../testing/selftests/drivers/net/hw/Makefile | 10 +-
> tools/testing/selftests/drivers/net/hw/config | 5 +
> .../selftests/drivers/net/hw/iou-zcrx.c | 242 +++++++++++++++++-
> .../selftests/drivers/net/hw/iou-zcrx.py | 108 +++++++-
> .../selftests/drivers/net/hw/iou_zcrx.bpf.c | 111 ++++++++
> .../selftests/drivers/net/hw/iou_zcrx.h | 34 +++
> 8 files changed, 492 insertions(+), 21 deletions(-)
> create mode 100644 tools/testing/selftests/drivers/net/hw/iou_zcrx.bpf.c
> create mode 100644 tools/testing/selftests/drivers/net/hw/iou_zcrx.h
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 32e218c0fe68..ea383dd81668 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -14076,6 +14076,8 @@ T: git https://github.com/isilence/linux.git zcrx/for-next
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux.git
> S: Maintained
> F: io_uring/zcrx.*
> +F: tools/testing/selftests/drivers/net/hw/iou-zcrx.*
> +F: tools/testing/selftests/drivers/net/hw/iou_zcrx.*
>
> IO_URING BPF-OPS
> M: Pavel Begunkov <asml.silence@gmail.com>
> diff --git a/tools/testing/selftests/drivers/net/hw/.gitignore b/tools/testing/selftests/drivers/net/hw/.gitignore
> index 911a9bfeaf41..085aa8b17afc 100644
> --- a/tools/testing/selftests/drivers/net/hw/.gitignore
> +++ b/tools/testing/selftests/drivers/net/hw/.gitignore
> @@ -1,5 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0-only
> iou-zcrx
> +iou_zcrx.skel.h
> ncdevmem
> tls_hw_offload
> toeplitz
> diff --git a/tools/testing/selftests/drivers/net/hw/Makefile b/tools/testing/selftests/drivers/net/hw/Makefile
> index 429cb545a4f0..d7a1fea08ea7 100644
> --- a/tools/testing/selftests/drivers/net/hw/Makefile
> +++ b/tools/testing/selftests/drivers/net/hw/Makefile
> @@ -10,7 +10,8 @@ HAS_IOURING_ZCRX := $(shell \
> echo -e '#include <liburing.h>\n' \
> 'void *func = (void *)io_uring_register_ifq;\n' \
> 'int main() {return 0;}' | \
> - $(CC) -luring -x c - -o /dev/null 2>&1 && echo y)
> + $(CC) $(CFLAGS) $(CPPFLAGS) $(USERCFLAGS) $(LDFLAGS) \
> + $(USERLDFLAGS) -x c - -o /dev/null -luring 2>&1 && echo y)
>
> ifeq ($(HAS_IOURING_ZCRX),y)
> COND_GEN_FILES += iou-zcrx
> @@ -98,5 +99,10 @@ include ../../../net/ynl.mk
> include ../../../net/bpf.mk
>
> ifeq ($(HAS_IOURING_ZCRX),y)
> -$(OUTPUT)/iou-zcrx: LDLIBS += -luring -lpthread
> +$(OUTPUT)/iou-zcrx: CFLAGS += -I$(OUTPUT) -I$(SCRATCH_DIR)/include
> +$(OUTPUT)/iou-zcrx: LDLIBS += -luring -lpthread -lelf -lz
> +$(OUTPUT)/iou-zcrx: LOCAL_HDRS += iou_zcrx.h $(OUTPUT)/iou_zcrx.skel.h
> +$(OUTPUT)/iou-zcrx: iou_zcrx.h $(OUTPUT)/iou_zcrx.skel.h $(BPFOBJ)
> endif
> +
> +$(OUTPUT)/iou_zcrx.bpf.o: iou_zcrx.h $(selfdir)/bpf/bpf_kfuncs.h
> diff --git a/tools/testing/selftests/drivers/net/hw/config b/tools/testing/selftests/drivers/net/hw/config
> index 081155bf7847..ef77543b567f 100644
> --- a/tools/testing/selftests/drivers/net/hw/config
> +++ b/tools/testing/selftests/drivers/net/hw/config
> @@ -1,4 +1,6 @@
> +CONFIG_BPF_JIT=y
> CONFIG_BPF_SYSCALL=y
> +CONFIG_DEBUG_INFO_BTF=y
> CONFIG_FAIL_FUNCTION=y
> CONFIG_FAULT_INJECTION=y
> CONFIG_FAULT_INJECTION_DEBUG_FS=y
> @@ -9,6 +11,7 @@ CONFIG_INET6_ESP_OFFLOAD=y
> CONFIG_INET_ESP=y
> CONFIG_INET_ESP_OFFLOAD=y
> CONFIG_IO_URING=y
> +CONFIG_IO_URING_ZCRX=y
> CONFIG_IPV6=y
> CONFIG_IPV6_GRE=y
> CONFIG_IPV6_SIT=y
> @@ -20,7 +23,9 @@ CONFIG_NET_IPGRE=y
> CONFIG_NET_IPGRE_DEMUX=y
> CONFIG_NET_IPIP=y
> CONFIG_NETKIT=y
> +CONFIG_NET_RX_BUSY_POLL=y
> CONFIG_NET_SCH_INGRESS=y
> +CONFIG_PAGE_POOL=y
> CONFIG_SYNC_FILE=y
> CONFIG_TLS=y
> CONFIG_TLS_DEVICE=y
> diff --git a/tools/testing/selftests/drivers/net/hw/iou-zcrx.c b/tools/testing/selftests/drivers/net/hw/iou-zcrx.c
> index 91b025a8771e..f7e909fd6840 100644
> --- a/tools/testing/selftests/drivers/net/hw/iou-zcrx.c
> +++ b/tools/testing/selftests/drivers/net/hw/iou-zcrx.c
> @@ -16,6 +16,7 @@
> #include <linux/mman.h>
> #include <linux/errqueue.h>
> #include <linux/if_packet.h>
> +#include <linux/if_link.h>
> #include <linux/ipv6.h>
> #include <linux/socket.h>
> #include <linux/sockios.h>
> @@ -37,9 +38,13 @@
> #include <sys/un.h>
> #include <sys/wait.h>
>
> +#include <bpf/bpf.h>
> #include <liburing.h>
> #include <ynl.h>
> +#include "kselftest.h"
> #include "netdev-user.h"
> +#include "iou_zcrx.h"
> +#include "iou_zcrx.skel.h"
>
> #define SKIP_CODE 42
>
> @@ -89,7 +94,11 @@ static struct sockaddr_in6 cfg_addr;
> static unsigned int cfg_rx_buf_len;
> static bool cfg_dry_run;
> static int cfg_num_threads = 1;
> +static bool cfg_xdp;
> +static bool cfg_pages;
>
> +static struct iou_zcrx *xdp_skel;
> +static int xdp_link = -1;
> static char *payload;
>
> #define MAX_CONNS_PER_THREAD 64
> @@ -154,6 +163,139 @@ static inline size_t get_refill_ring_size(unsigned int rq_entries)
> return ALIGN_UP(size, page_size);
> }
>
> +static int probe_xdp(void)
> +{
> + const struct bpf_insn insns[] = {
> + {
> + .code = BPF_ALU64 | BPF_MOV | BPF_K,
> + .dst_reg = BPF_REG_0,
> + .imm = XDP_PASS,
> + },
> + { .code = BPF_JMP | BPF_EXIT },
> + };
> + LIBBPF_OPTS(bpf_prog_load_opts, load_opts,
> + .prog_flags = BPF_F_XDP_HAS_FRAGS);
> + LIBBPF_OPTS(bpf_link_create_opts, link_opts,
> + .flags = XDP_FLAGS_DRV_MODE);
> + unsigned int ifindex;
> + int prog_fd, link_fd;
> +
> + ifindex = if_nametoindex(cfg_ifname);
> + if (!ifindex) {
> + error(0, errno, "if_nametoindex()");
> + return EXIT_FAILURE;
> + }
> + prog_fd = bpf_prog_load(BPF_PROG_TYPE_XDP, "zcrx_probe", "GPL",
> + insns, ARRAY_SIZE(insns), &load_opts);
> + if (prog_fd < 0) {
> + error(0, -prog_fd, "load XDP probe");
> + return EXIT_FAILURE;
> + }
> +
> + /* The io_uring queue is already registered; never replace a program. */
> + link_fd = bpf_link_create(prog_fd, ifindex, BPF_XDP, &link_opts);
> + close(prog_fd);
> + if (link_fd >= 0) {
> + close(link_fd);
> + return 0;
> + }
> + if (link_fd == -EBUSY || link_fd == -EOPNOTSUPP) {
> + printf("Native XDP with ZCRX is not supported: %s\n",
> + strerror(-link_fd));
> + return SKIP_CODE;
> + }
> + error(0, -link_fd, "attach XDP probe");
> + return EXIT_FAILURE;
> +}
> +
> +static void setup_xdp(void)
> +{
> + LIBBPF_OPTS(bpf_link_create_opts, opts,
> + .flags = XDP_FLAGS_DRV_MODE);
> + unsigned int ifindex;
> + int prog_fd;
> +
> + ifindex = if_nametoindex(cfg_ifname);
> + if (!ifindex)
> + error(1, errno, "if_nametoindex()");
> + xdp_skel = iou_zcrx__open();
> + if (!xdp_skel)
> + error(1, errno, "iou_zcrx__open()");
> + xdp_skel->bss->port = cfg_port;
> + xdp_skel->bss->queue_id = cfg_queue_id;
> + xdp_skel->bss->unreadable = !cfg_pages;
> + if (iou_zcrx__load(xdp_skel))
> + error(1, errno, "iou_zcrx__load()");
> +
> + /* A link cannot replace another program and closes with the process. */
> + prog_fd = bpf_program__fd(xdp_skel->progs.iou_zcrx);
> + xdp_link = bpf_link_create(prog_fd, ifindex, BPF_XDP, &opts);
> + if (xdp_link < 0)
> + error(1, errno, "attach native XDP");
> +}
> +
> +static void check_xdp(void)
> +{
> + static const char * const locations[] = {
> + "header", "fragment", "boundary",
> + };
> + static const char * const ops[] = {
> + "load", "store", "dynptr read", "dynptr write",
> + "slice", "slice rdwr",
> + };
> + struct xdp_zcrx_stats sum = {}, *all, *s;
> + int ncpus, cpu, loc, op;
> + __u32 key = 0;
> + bool failed;
> +
> + close(xdp_link);
> + xdp_link = -1;
> + ncpus = libbpf_num_possible_cpus();
> + if (ncpus < 0)
> + error(1, 0, "libbpf_num_possible_cpus(): %d", ncpus);
> + all = calloc(ncpus, sizeof(*all));
> + if (!all)
> + error(1, errno, "calloc XDP statistics");
> + if (bpf_map_lookup_elem(bpf_map__fd(xdp_skel->maps.stats), &key, all))
> + error(1, errno, "read XDP statistics");
> +
> + for (cpu = 0; cpu < ncpus; cpu++) {
> + s = &all[cpu];
> + sum.packets += s->packets;
> + sum.tested += s->tested;
> + sum.wrong_queue += s->wrong_queue;
> + sum.bad_headers += s->bad_headers;
> + sum.linear_bytes += s->linear_bytes;
> + sum.frag_bytes += s->frag_bytes;
> + for (loc = 0; loc < XDP_ZCRX_LOCATIONS; loc++) {
> + for (op = 0; op < XDP_ZCRX_OPS; op++)
> + sum.errors[loc][op] += s->errors[loc][op];
> + }
> + }
> + free(all);
> +
> + printf("XDP %s: queue=%d packets=%llu tested=%llu\n",
> + cfg_pages ? "pages" : "io_uring", cfg_queue_id,
> + sum.packets, sum.tested);
> + printf("XDP geometry: linear=%llu frags=%llu\n",
> + sum.linear_bytes, sum.frag_bytes);
> + printf("XDP errors: wrong_queue=%llu bad_headers=%llu\n",
> + sum.wrong_queue, sum.bad_headers);
> + failed = !sum.tested || sum.wrong_queue || sum.bad_headers;
> + for (loc = 0; loc < XDP_ZCRX_LOCATIONS; loc++) {
> + for (op = 0; op < XDP_ZCRX_OPS; op++) {
> + if (!sum.errors[loc][op])
> + continue;
> + fprintf(stderr, "%s %s: %llu failures\n",
> + locations[loc], ops[op], sum.errors[loc][op]);
> + failed = true;
> + }
> + }
> + iou_zcrx__destroy(xdp_skel);
> + if (failed)
> + error(1, 0, "XDP access checks failed");
> +}
> +
> static void setup_zcrx(struct thread_ctx *ctx)
> {
> unsigned int rq_entries = AREA_SIZE / page_size;
> @@ -217,6 +359,10 @@ static void setup_zcrx(struct thread_ctx *ctx)
> };
>
> ret = io_uring_register_ifq(&ctx->ring, (void *)®);
> + if (cfg_xdp && cfg_dry_run && ret == -EOPNOTSUPP) {
> + puts("Interface-bound ZCRX is not supported");
> + exit(SKIP_CODE);
> + }
> if (cfg_rx_buf_len && (ret == -EINVAL || ret == -EOPNOTSUPP ||
> ret == -ERANGE)) {
> printf("Large chunks are not supported %i\n", ret);
> @@ -258,6 +404,34 @@ static void add_recvzc_oneshot(struct thread_ctx *ctx, int conn_idx, size_t len)
> sqe->user_data = conn_idx;
> }
>
[..]
> +static void verify_data(struct thread_ctx *ctx, int conn_idx,
> + const char *data, size_t len)
> +{
> + size_t offset = ctx->received[conn_idx];
> + size_t i;
> +
> + for (i = 0; i < len; i++) {
> + if (data[i] != payload[offset + i])
> + error(1, 0, "payload mismatch at %zu", i);
> + }
> + ctx->received[conn_idx] += len;
> +}
Move some of the refactoring/fixes out into a separate patch?
But in general feels like a wrong test to extend.. Why not call
ncdevmem somewhere in python wrapper (and attach xdp prog that you have
in this patch)? To decouple xdp testing from the entity that generates/receives
unreadable frags.
prev parent reply other threads:[~2026-11-20 0:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 16:46 [PATCH net-next 0/7] XDP with io_uring zero-copy RX and devmem Björn Töpel
2026-11-17 16:46 ` [PATCH net-next 1/7] bpf: Keep XDP helpers within readable data Björn Töpel
2026-11-20 0:22 ` Stanislav Fomichev
2026-11-17 16:46 ` [PATCH net-next 2/7] xdp: Reject frames with unreadable fragments Björn Töpel
2026-11-17 16:46 ` [PATCH net-next 3/7] net: Admit native XDP on provider queues Björn Töpel
2026-11-20 0:24 ` Stanislav Fomichev
2026-11-17 16:46 ` [PATCH net-next 4/7] eth: fbnic: Run " Björn Töpel
2026-11-17 16:46 ` [PATCH net-next 5/7] netdevsim: Run native XDP next to devmem Björn Töpel
2026-11-17 16:46 ` [PATCH net-next 6/7] selftests: net: Test XDP with devmem bindings Björn Töpel
2026-11-17 16:46 ` [PATCH net-next 7/7] selftests: net: Test XDP on io_uring RX Björn Töpel
2026-11-20 0:31 ` Stanislav Fomichev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av-Udp0GfOjxH9vq@devvm16445.scu0.facebook.com \
--to=sdf.kernel@gmail.com \
--cc=alexanderduyck@fb.com \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrii@kernel.org \
--cc=asml.silence@gmail.com \
--cc=ast@kernel.org \
--cc=bestswngs@gmail.com \
--cc=bjorn@kernel.org \
--cc=bobbyeshleman@meta.com \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=eddyz87@gmail.com \
--cc=edumazet@kernel.org \
--cc=emil@etsalapatis.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ihor.solodrai@linux.dev \
--cc=io-uring@vger.kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=rdunlap@infradead.org \
--cc=sdf@fomichev.me \
--cc=skhan@linuxfoundation.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox