Hello, On Thu, Nov 19, 2026 at 07:14:47AM -0500, Anthony Krowiak wrote: > On 11/19/26 12:15 AM, Alex Williamson wrote: > > diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c > > index 8e69ed286bb9..2d47dc643269 100644 > > --- a/drivers/s390/crypto/vfio_ap_drv.c > > +++ b/drivers/s390/crypto/vfio_ap_drv.c > > @@ -62,6 +62,7 @@ static struct ap_driver vfio_ap_drv = { > > .on_config_changed = vfio_ap_on_cfg_changed, > > .on_scan_complete = vfio_ap_on_scan_complete, > > .ids = ap_queue_ids, > > + .driver.support_driver_override = true, > > Does this really belong here? Shouldn't it be in struct ap_driver > since driver_override is supported in the AP bus? ap_device_probe() calls device_match_driver_override with drv=&ap_drv->driver. So I think the assignment is fine. Best regards Uwe