From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.229.135 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794435917; b=iqZn7p29ui7GtFPHsq2DToAojSmScdr/G1+ItVN7Xmk4LCWMzq1yaMdVbgvgk6FHK6Tk nlxT0z+xN/oYg41q+U7LyuROHxoZsdB6xIfoCMBPAoWfbz2ylYY4P9o6gRnn0+Il39v5R VkPzkQMMgD8jCQiZlEd+SwJpymFhn9yosuN1OtgcCVtu4kMotgaQW9QgmLt4JTEfoGcwZ vy+Ch6aTuXqjw5eE/XQbcdee6QMoT8Qa7ptI5KUj9+h87VQYV0GK9muQaLREUgN34EgLb TQjP5amOnqfRXyYnqsa/3QOltP84eqFV4IKVjTFIS9HNf64oTva3Qv/ksjRYrFKZvKA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794435917; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=LcIgSNREManU20T5ds32E1qosC1xbF0e9vbPmoZw/SM=; b=o2AyMNmRCl9N4DnMDEiLLoARl0uLmTnIhgf7JeFJ2KM3BW96BvAS2xUsZNryL60SPihS K4qR5NdIMhEvgB3SS9/HBLPMyUtlWI1gLs2R+NiAunK/uYPtcCRVX38JWtCl2HY5IfQ+a G/0Amt2KCdUdRuY3SCSExwaTHIhOvh5jYjB3fkesOMhF1VWKf6Ke2/KNviAK9LEGVPm8K Anh765WcjHSx/u0G9M08e7moIQWLJ8C1vaRufPL2KG3DIuzLrX3bHlwkr3OKh+M7FgJUA /7rOh98yr6/cPq9LguhYmx5VUuc0x/igkFF4RjTx1XoJjWhQGJbpUxD+2U61fQfB4/w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b="WRxwN8/y"; arc=none smtp.remote-ip=74.125.229.135 Received: from mail-dl2-f7.google.com (mail-dl2-f7.google.com [74.125.229.135]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE2AC606A327 for ; Wed, 11 Nov 2026 22:25:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org CE2AC606A327 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=WRxwN8/y Received: by mail-dl2-f7.google.com with SMTP id a92af1059eb24-13985f8229aso3309024c88.1 for ; Wed, 11 Nov 2026 14:25:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794435916; x=1795040716; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=LcIgSNREManU20T5ds32E1qosC1xbF0e9vbPmoZw/SM=; b=WRxwN8/yRQXnBMs79H4zEYpeGEdBg8BnKhaHIb1pRpEfUeouvtNDop9d5/n4XDIsTE bS+RCTNz2dFaoNvhaPgORvboxzRWa6ylYl/nYhEZ5DewOd9+xQHb3ySenQgqSb3A3aAB EQy827yfXzHAx0VVyQT/26oNznABcK6D66SnLGHhy387O11NbSMNyPxIFHGmHX1Mix2l 6mNwh1bPwiaWQ0K4p5tC9qsb/pgi0MigrZTf6G2BFqiTQ/4H1N8FfNfOVZccC6GSxP3g +lo10dqt1ZyMjXI9qhOjp9SauzZgLfWXaLHu1tPrqDh+qWL6hHkpxkqYzy3Mq2Asx7sU qu8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794435916; x=1795040716; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LcIgSNREManU20T5ds32E1qosC1xbF0e9vbPmoZw/SM=; b=nkmnuH6uIhrpJo8giOo0BEj4U62L/bi18rrtRhyI/qEtBPMQhMhEwmSOy7OLQogCqC OLpJxXm5pHPoPUXKfl/nXJLYx7Wm0eTw6wwVFgOn5wLIF9vv/arlYQpzPAbh0H9aTVZm rHW8AiEyGRQBC+B3CdAV1NOsQCa22mpw8vduDvmMupHsOIttxbRzi2hEOOm7Zu7OUQkw gj8FjuHGDjGsnIvtzW3Uzw2GjufXLaLLG5jqh/bUPzrCOd5TMvljt78idut9c1t0UIxE s+lZSlSRBygkD1JxjrXI0DTpCIEHTEkkSGX0F0iGUDkomqGzV33xcGJ3Av0TiXxR5I+K 6iYg== X-Forwarded-Encrypted: i=1; AL+hErFhGBS4yvSPue6Rxqws8ugVgryQpeSuH80L5ANbo+2LFl5Wb7MlO1PKok1IEC8G5AMziW7zFHvhxTA=@vger.kernel.org X-Gm-Message-State: APuU4Z+QsG/pcndeaYeuw6n0XAJvS1AOcqh4G1VvsPevKo08ZQtck9g4 xqxoN6Du4vbcaW6vAXO+bk8O+MeHvV8i59uvnjXGH9bKKHpHp75Kn++l X-Gm-Gg: AYBFou3AVNanc70ibaNIqQbGeZ9gqvP637mxRoiYXU2UCA3C6oQj/G+3UG0vhcrZaJJ W4OlYGKqqfAY+rmNHZWnknFg6FkgYGtgPQDuw3rVlR+QfK/+3p3DzAVGnk/S2ZeXObC1bAHa1ao RLFiFA1jYzuVMlZx+2bdPX1566ZfeNVUUJF3Co7A01LLmAV9eEIi7PgvLyTHn3FofE/qkA+ZM2g 1AoYN2XYSeo24wIf8uu/no2/jz+Qun705NkBKeupzIqoXnZqKTE4wNYUDB/OZf9wPUrAn/0Cgl/ mikmPUugnqnEwQ+XdcitpVDJeK9wxZeU6pFX9TYCZV6WVkecV7gvnegspkU+AeCHDneQAC9FrLb TexMLJ3U6zp+VzbDPwOQxQZJKIZ7blMGQGFz6JPDZiZyj/O+kRkMgmaRiOYtH7i3pBghN+Ghj8y 3PO+pvG/mztNzRkjc+ni6HD8In2p/xN4Uf7lvrI+sQuadlMhSL/NpxqY33VR/5Fh0D5nfzxirZd gC1vaLXVuAYQf72TtIUQhvNfBtLTVPFgBdWcXf0p3VSRfJU7eVUemfa7JUUvO8wjp1qjEhycN1S 2+1LbFZesmqZUeH03mfvesw= X-Received: by 2002:a05:7022:286:10b0:1b3:a23a:d1f3 with SMTP id a92af1059eb24-1b3c03037a9mr3351998c88.18.1794435915687; Wed, 11 Nov 2026 14:25:15 -0800 (PST) Received: from localhost ([2a03:2880:9ff:43::]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1b3b5890584sm20682923c88.3.2026.11.11.14.25.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2026 14:25:15 -0800 (PST) Date: Wed, 11 Nov 2026 14:25:09 -0800 From: Stanislav Fomichev To: Tianyi Gao Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Lorenzo Bianconi , Vladimir Vdovin , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Andrew Lunn , Donald Hunter , Eduard Zingerman , Kumar Kartikeya Dwivedi , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Ihor Solodrai , Tony Nguyen , Przemek Kitszel , Maciej Fijalkowski , Alexander Lobakin , Magnus Karlsson , Tushar Vyavahare , Jason Xing , Nikolay Aleksandrov , Madalin Bucur , Ioana Ciornei , Jonathan Corbet , Shuah Khan , Shuah Khan , Randy Dunlap , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Chris J Arges , Jakub Sitnicki , linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, intel-wired-lan@lists.osuosl.org, llvm@lists.linux.dev, kernel-team@cloudflare.com Subject: Re: [PATCH bpf-next 00/15] xdp: add SKB core extensions to keep RX metadata until skb creation Message-ID: References: X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On 11/11, Tianyi Gao wrote: > Hi Stanislav, > > On 11/10, Stanislav Fomichev wrote: > > Awhile ago we discussed the alternative of adding setters for xdp > > metadata. Then the veth (or whoever turns xdp frame into an skb) can > > apply whatever metadata it needs (and there is some magic behind the > > scenes that takes it into account when creating an skb). That keeps > > the layout and most of the code outside of kernel. Have we considered > > that here? > > Thanks for the reminder. Yes, we considered [1] and [2], and took > parts of them. > > The alternative setter model in [1] requires a program on veth or > cpumap to call the setters for the RX metadata. We want to avoid that: > > - On veth, an XDP program removes software GSO from the peer, limits > its MTU, and can copy skbs from the peer. > - On cpumap, each entry would need a program only for this. > > This series achieves the same with only the XDP program on the NIC, > which stores the values with kfuncs in the skb core extension area > after the xdp_frame. cpumap and veth take this area into account when > they create the skb, which is the "magic behind the scenes". > > [1] https://lore.kernel.org/all/20250616145523.63bd2577@kernel.org/ > [2] https://lore.kernel.org/all/aGvcb53APFXR8eJb@mini-arch/ My main concern is that we are adding a lot of code and one more special way to plumb the metadata (and another metadata area), another set of kfuncs and slowly creeping more features into xdp making it more and more like skb. For containers in general, and for fast af_/xdp, we seem to have been moving into netkit with queue leasing. Maybe that's something that can help with your veth performance?