From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.46 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794551022; b=r+NGtTpinGjHG11joIFySE9fMMf55/TkOU2YSbrlBs83QAiZMKwZGTI8PboqEM3AzDrM jh/PKvsZ7HA/pEjZ3jquCgrZbXXCDrpk6Bnto6KTkyhhV3u3/cSD+2wx2O8/0msg+XXRg ev5SAQB/vP2Oph/tR3SZx91iHffQ8BlriYdmZKH8FH9L2WSTq7+3QCL+wLsI2vVtJfe2E zs/VvuUMzAR3V2kbQTdaarHuAcFsm4fHd1wrBPTpcrtiFOkIlbAn+x0f/60rMgb9InFWY NaFB0O1DC3TlbjiGyjv6ASc+aWtCUl6vrUk0hMtfSohOufsqdha+PgLArAzRCrSuLPw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794551022; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=scTX0bumEv05AQNebNSsHg/mOW7TqFZSq25FZEyaOcI=; b=EaDUezZJuYdvDHaI3kC8khdkYP9g4C2xWZb5vI+tgF7RRLHE7iv0gzG55LF+C9G7u9bI HNxuJ+gb6+bSv94K0/fitE+BLwYtrTmkvq2yHurwu2+TOyJrAlBzw/Tirz3zMSEDCsTF1 vjlnsSRmBi3OrXcJ64K1EupKaFk1qr7fbH8x/N1hO+4da5Zk7TBaj8g6nUI8LXiw7zr9M 3HbZm7ypj/8OuHgzqMEoUsFcUkxxi3HPR8p+fFwWWkaUevwqLttzPmt6JU99jyvMf9bRt 15w8EulP62XTrlHupVno7rWk6o59kiAbhAatzkLrP07AMWEcuCOIn/b7W+qlqxQC38A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=FPkWGBpk; arc=none smtp.remote-ip=209.85.128.46 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 803AC606A321 for ; Fri, 13 Nov 2026 06:23:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 803AC606A321 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=FPkWGBpk Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4a20bde60a0so4155565e9.3 for ; Thu, 12 Nov 2026 22:23:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1794551020; x=1795155820; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=scTX0bumEv05AQNebNSsHg/mOW7TqFZSq25FZEyaOcI=; b=FPkWGBpk/+uXvN7d8744zAwrLdMCouM1Hpl9aCBeyVo4Fs/0Pj1xsLJvubN9r3GJXc 1gxiErW2ve2M3VfoTM3SoKFurchZBNdkD3dgwNrN3+8YrjE0FP+fjOZM7GlZ1bUqg/6k ioT+xge4GPeCMFg55Dg/XJVBqL4M2zBNdc6n1XO8p5HtIy1hp+PjvgeNjv69HGQjkkbJ /mHRayRZBQyoMk30pBOOm5OzWKwG0HoJNS20TBTz8P7M28axuxf96ZcFMxgCU2ljVX34 L9xI/Ibuz4YIq8MYIJU7S57SIWQ6m18ACVwlUNoGUjKSRTxEKMtSz2feydcXhA+GIH6C 3/QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794551020; x=1795155820; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=scTX0bumEv05AQNebNSsHg/mOW7TqFZSq25FZEyaOcI=; b=2JuwsAwg9YAHTT5A3IzR8wTuck6t5+Y4MszW1MqsQvmr+mE2hmAX+8EYpGw9RNNBYD Pz6yUS9/saaB/FMgftDthqRcBZLAvkz1w9s3fvkALl0zVzqrX2+4svK97W7VN73TTbdn +Rvyg6DnnHWFCPjMqgFEyXk2KxjaLFLqbliK9dWkGlU8PTYuYu9dZkxwdF3JU6ByF+Lt WnCj/AXHJqOP59aS90jwOWTGPTQHvmM/ajUuru6FmNQb1ZAkomqAQgc87Y62HRd3FnnL p+LxBmxAHD4yOLw6dPiywGP5x7QPSJoXiOHIqZzaJbrSBFEV+guKctF2+xRL4icwekSR mqHw== X-Forwarded-Encrypted: i=1; AL+hErHnHLCphCquZd0Oi+HDE0Cr+wRmeUZ3+eJIaGlmZI5k7nKgJcCJXqHCXEzWCVIbrlqeTLMmNzlpvZw=@vger.kernel.org X-Gm-Message-State: APuU4Z82Us1hWrp4lx9A/tJ/CnkCWvuIZfb8WLW7z7se+hWb8qAEdsVb AghTeM4swq66sZBFKzvTpOzmsBP/D47uJ/+ya6ZragDSlh5IoiO1Dp1EK8tGOTK5Z/4= X-Gm-Gg: AYBFou30oSUywMaPvtURSr6acWznfUhaP8UyJ852numdV8+wvhHLEW+aFN+QizE4RHf +eZcccUZQVypSMx4F7kSFB6A8kwn/+gZi2XN2kVNecKTbREJyUuAVqMYW3Gy2K54iva0JpipSrk iFFLx2u33jR/qkcUQCH7y3gpv4mhg41vh3CFvv9lno7Djki7cS7iWzOoDTOT9xk6ZAPSge+zttb ub81b+XQE+9dF3NnXCzmJDYh4DHlhjpj0wKorolX1KpZBvt/k5FmfSowk+bl5++NCzZQa8E2UqA +1oOj4Y47NOkW3CHyzx0BpdLHxzEWl0spZNjbi/hdIf3Z77mrQyDSTY8pfv9NfzSkjbY1jX5HR8 vJ041lK+zTX9ndC0L81b+hDuEAqJK1AzMpHDAbb2g3WTDLJ9eEhqDr4mbFiFDtbqSON5K2N86O0 o99Jqe9LFjzOwsSH+t/ri7dZ9Jhw2tWJlenzzmyr+5bjTsmlWZZpwmxB6+vvJgWT5Reff6JVKR7 e+hQH6K3MSBYi6zBS4aMsnGysJtWfo0NTWymSPCKIaFTZQVJ9WOnrh0z4x8KS0AOC8OJSXU9IRE +3iuF+7IfYNV5razZJN5hojitSadUa5kTmJbsOlcjHpVkfNmCZwlnyOLWeGSpYlyKq6oOOFpgA1 OHTdFzfSJq5Tx6y/Zm5k= X-Received: by 2002:a05:600c:1daa:b0:4ba:2bfc:c8ab with SMTP id 5b1f17b1804b1-4bb55a4801bmr29639465e9.15.1794551019876; Thu, 12 Nov 2026 22:23:39 -0800 (PST) Received: from localhost (ip-091-089-005-024.um28.pools.vodafone-ip.de. [91.89.5.24]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4bb56f8d054sm16744035e9.3.2026.11.12.22.23.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 22:23:37 -0800 (PST) Date: Fri, 13 Nov 2026 07:23:36 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Joseph Telaak Cc: dri-devel@lists.freedesktop.org, Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Alessio Belle , Luigi Santivetti , Christian =?utf-8?B?S8O2bmln?= , Thomas =?utf-8?Q?Hellstr=C3=B6m?= , imagination@lists.freedesktop.org, Frank Binns , Gabriel Gama , Matthew Brost , Danilo Krummrich , Philipp Stanner , Sumit Semwal , linux-media@vger.kernel.org, Jonathan Corbet , Shuah Khan , Randy Dunlap , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC 12/13] drm/powervr_sgx: Add the DRM driver, power management and debugging Message-ID: References: <20261112-powervr-sgx-v1-0-c69b84bac011@telaak.dev> <20261112-powervr-sgx-v1-12-c69b84bac011@telaak.dev> X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="q3fovxmny7pd3sxx" Content-Disposition: inline In-Reply-To: <20261112-powervr-sgx-v1-12-c69b84bac011@telaak.dev> --q3fovxmny7pd3sxx Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH RFC 12/13] drm/powervr_sgx: Add the DRM driver, power management and debugging MIME-Version: 1.0 On Thu, Nov 12, 2026 at 05:59:02PM -0500, Joseph Telaak wrote: > +static const struct pci_device_id pvrsgx_pci_ids[] =3D { > + { PCI_VDEVICE(INTEL, 0x089b), 545 }, /* CE5300 family: SGX545 */ Please make this { PCI_VDEVICE(INTEL, 0x089b), .driver_data =3D 545 }, /* CE5300 family: SG= X545 */ > + { } > +}; > +MODULE_DEVICE_TABLE(pci, pvrsgx_pci_ids); > [...] > diff --git a/drivers/gpu/drm/powervr_sgx/pvrsgx_of.c b/drivers/gpu/drm/po= wervr_sgx/pvrsgx_of.c > new file mode 100644 > index 000000000..e347a3699 > --- /dev/null > +++ b/drivers/gpu/drm/powervr_sgx/pvrsgx_of.c > @@ -0,0 +1,119 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* Copyright =A9 2026 Joseph Telaak */ > + > +/* > + * An SGX on a device tree SoC (Documentation/devicetree/bindings/gpu/ > + * img,powervr-sgx.yaml). On TI parts the GPU node has no clocks or power > + * domain of its own: its ti-sysc parent module enables both, and applie= s the > + * SGX interrupt quirk, when the GPU device is runtime-resumed. Every re= gister > + * access happens with the parent held awake. > + */ > + > +#include > +#include > +#include Don't include . of_device_id is already provided by and also by without the useless dependencies that introduces. > +#include > +#include > +#include > +#include > +#include Best regards Uwe --q3fovxmny7pd3sxx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmr2rOQACgkQj4D7WH0S /k653gf/auhko2qaNS4BWJKPTZ0U6dpwzMZplMcZygr/SRNkqB4rtNEr7cniJb/w 6HZVwgsx6EXyuiQ3Fznzch9R+5VAoHbqY1QrjaycWAttOem37Sm+3FGHqoG0zW8R XSea37dwrl441qCF8WonzOU9YK8dbo2CV5Bi6SGvtf/fnaj1F3smvAws5CmtB5yq KEPdVWFNnVGqV95nEDkgb09I3EgkCZRkYmBn3bEN+VrJRvYJOfNdGX8AkBDjog3e D6eh7mRm1yDdkHd8zrpKf9tAAaS784qhDz6YzqobHn/DSybseU7VEV+6gsajSEWE tJ7bUnZyLTpFf7SLsE8ghAOQ8KSLmQ== =uMBo -----END PGP SIGNATURE----- --q3fovxmny7pd3sxx--