From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11013023.outbound.protection.outlook.com [52.101.83.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F82F377566; Mon, 1 Jun 2026 12:06:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.83.23 ARC-Seal:i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780315576; cv=fail; b=SOJEqtBVfu8PGpM0pQnnc5ynn40PxFfXeiicR6aifFwlVS1el1C74Rva0a+KwVEBJtnOR++6SnjiULFOIQfmRzvlnVG+VB0Tzk5v++Jz09SRc7ACoxef7nBIAoRjiciHm2GEJdhvFJxg1OVMdd+wtjwiKrErXw2Yzj5QzXI9M68= ARC-Message-Signature:i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780315576; c=relaxed/simple; bh=+R1pZvYgAujMlaT4UxGutFo+5V9ab06BARqTJy3U6vs=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=cnhBw5QT1m7AUpVK6al3zJuKppBPkWDWcNa14HF3ME/aXE4hynYLnEjLfRD3EI6hC4hVoc768ZLErlRLMXTtpVA49ru51mbbtDdY+rfBfaoaQ9zrEKa+RyHya+35DSVEw5jdBANCDLVJMhyecLW4l51ILoGdcDh521TNkV7BYuM= ARC-Authentication-Results:i=3; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=W/h2Zymk; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=W/h2Zymk; arc=fail smtp.client-ip=52.101.83.23 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="W/h2Zymk"; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="W/h2Zymk" ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=C81Gy5DQKLpSpVpDVIrwqYGiOlDbFZ6kUNC17MJjMd9ErYfQhYyjZxvlBwD47eFUEg7hOn77C+o8Xma7kJQVOSUxk8bVgudMd8rGVBADP8Gyka8YGLpytx2IewMAp+O/wWNgz1czKlKBOXJ+m0qngenMwJIs2bGAiHzDxFp/LEkmZ3qRpG3R3cRoRMich9xAvQxgN0eosMbebsfGwwJdJNVURw8LPfzcpLf6pQnx2S2FXrb6bLlgxSkPkLWUjAGMukU9OxvIij90yUP2oBKOelkcvu6/FAfQgjOV3r5qXA5WH9D8y28Q+Hhs2ME/2OXJ9mt7SswsvnYQpYSM4g0ZhQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YAwtx8iXkBZ35HE+VZNm/0vvO4oCQSSXH+5v98gjC3E=; b=lVDr+D5ppyKgAJsZOSzIVLU1E6yoy17Ed6eQleU1NtHlX4E8WfPja2xtviyArMn0o+pNJISaLx7aOZZEVK4jfnlLdcFpbfUHKs+uGiTaIWp9zlcnq5SomaxdbT0oqJPB3tuheGqYHkdfPmovKzUvEefXwLGwyznrCXCpavkcXP0oeQNQ448XUdOI9mNttzTXaz3LHNjiy7yUAorA8L0Sq/MjB+VoHczFu4Eu+AE8tTDTzMbbTglCWEmy9+RCDcPceZUbd+e80rnweqJ/wecjnblCfSJfRx/el/nPI37Zg++4pSTXCWus9aUvAZ3jKYITDtPF0nMIIUUCXnYilZzbUA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=nvidia.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YAwtx8iXkBZ35HE+VZNm/0vvO4oCQSSXH+5v98gjC3E=; b=W/h2ZymkgTVFi/r7dSxhibzOg+RVUQuPHBPwmr+v07gJzynNAzhnV6/KrdHXqnGVHvJMOLsLPoyg7XkZyuJ9lKpQXU4AIguc6vAMdo6253t6PSpnHK+2kCEncFVfQCJLM8RenPyvJhgNkVw5Kg/PIc4V83gBV7vWPj+SzTlUP9E= Received: from AS4P192CA0031.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:658::24) by AS2PR08MB9739.eurprd08.prod.outlook.com (2603:10a6:20b:605::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.16; Mon, 1 Jun 2026 12:06:07 +0000 Received: from AM3PEPF0000A79A.eurprd04.prod.outlook.com (2603:10a6:20b:658:cafe::15) by AS4P192CA0031.outlook.office365.com (2603:10a6:20b:658::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.71.16 via Frontend Transport; Mon, 1 Jun 2026 12:06:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AM3PEPF0000A79A.mail.protection.outlook.com (10.167.16.105) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Mon, 1 Jun 2026 12:06:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VZrcX3xbUjMD/On4sElS7rfjpLgiAlMJ0YD5IRe+zRvQxIk0VoGG4LGvQJEiHlmwFx8fGkBEIBGt4bZhACaokOveW9Z1m/XtUPOpU/vCovwQqkb5bbmqvowr63l/FxeBQ3erGs5sgsNccjQT7AoPHWbx6I9zf938/G24G3WIj8uYNG7jbXX6Acl2dE0/VGAE32q4xIJMPmha9zubmoP9ifR4MT4Ff89K6PEcg7XEeiAP9AjXkiDacnGStkM3vQEJ3445BRNTfY83AJ7aOtQMQaPQo+7H+mQomSfh65R2GoKWrY1+CFvDCEBxMMoA9VMVnzinorPyblVl9CJ4/314qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YAwtx8iXkBZ35HE+VZNm/0vvO4oCQSSXH+5v98gjC3E=; b=wt1RiEtoUx4e1+zavwHmqNKFVbKu0gobFq2IQvCYY5XiIaMz+yFXByQ6vpNFeCqKudsMnzEEflUEikuxq7h4CKEWxLn29/BwXojwrjSD/PELTDl5nJjG+eZrb6PqNflknNyYlULT4GL0LI1shu/fgXu2h1fdEo6c6p812Ggd1pictq3IwtaOBSAmjNvW4yLOQY/A+LLTan5wNi/UjpS0/EMAUB4z+etwOSciPIYcsDfpS53951PHWO9/VNrpBvQK38siWfESP3PuGAmINhKL3Cd29UHLcbc42x/Zl3vjhOFQOYV4oPSOHi2MWggpQkqPexzljB6OPztPATSj6gEevg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YAwtx8iXkBZ35HE+VZNm/0vvO4oCQSSXH+5v98gjC3E=; b=W/h2ZymkgTVFi/r7dSxhibzOg+RVUQuPHBPwmr+v07gJzynNAzhnV6/KrdHXqnGVHvJMOLsLPoyg7XkZyuJ9lKpQXU4AIguc6vAMdo6253t6PSpnHK+2kCEncFVfQCJLM8RenPyvJhgNkVw5Kg/PIc4V83gBV7vWPj+SzTlUP9E= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DU0PR08MB9203.eurprd08.prod.outlook.com (2603:10a6:10:417::12) by PR3PR08MB5644.eurprd08.prod.outlook.com (2603:10a6:102:86::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.16; Mon, 1 Jun 2026 12:05:04 +0000 Received: from DU0PR08MB9203.eurprd08.prod.outlook.com ([fe80::f1e:73f2:57df:4047]) by DU0PR08MB9203.eurprd08.prod.outlook.com ([fe80::f1e:73f2:57df:4047%5]) with mapi id 15.21.0071.014; Mon, 1 Jun 2026 12:05:04 +0000 Message-ID: Date: Mon, 1 Jun 2026 17:34:55 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/5] selftests/mm: separate GUP microbenchmarking from functional testing To: John Hubbard , Andrew Morton Cc: David Hildenbrand , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Jason Gunthorpe , Peter Xu , Leon Romanovsky , Jonathan Corbet , Shuah Khan , Mark Brown , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260527142432.230127-1-sarthak.sharma@arm.com> <20260527114752.cf4dd3e1bda93fb8ebab5a76@linux-foundation.org> <3b4176f4-e099-490c-a5e2-6a36d00b1207@arm.com> <13b63b4f-6a4b-4433-93e8-78035ab62b83@nvidia.com> From: Sarthak Sharma Content-Language: en-US In-Reply-To: <13b63b4f-6a4b-4433-93e8-78035ab62b83@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MA5P287CA0009.INDP287.PROD.OUTLOOK.COM (2603:1096:a01:176::13) To DU0PR08MB9203.eurprd08.prod.outlook.com (2603:10a6:10:417::12) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DU0PR08MB9203:EE_|PR3PR08MB5644:EE_|AM3PEPF0000A79A:EE_|AS2PR08MB9739:EE_ X-MS-Office365-Filtering-Correlation-Id: 95c0a2c7-256c-4498-de9d-08debfd6295b x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|7416014|376014|366016|1800799024|22082099003|18002099003|56012099006|4143699003|5023799004|11063799006; X-Microsoft-Antispam-Message-Info-Original: 0/UCGDkV18pw1rqlCv8/v3c395BjlZi1XIiaKBCfN66Ra7MGSp6D6Q8PsII135EQTkPhTf+mUe31ui+vzK/wX350Wf1VUuG3RdjaoiKdL9T+5Pp7UifYPvKYm7voVLLoZvElkflff6Dnb4fn0Oo06DsjO6tvD9b++Axa2JzcqjDXsCtR5SRgEUUMaVNd05NIcv0zK+AvJz+E7FUG9itLk6WHEb8swToNZWAQ/v9XELV702ykHdRILAFHWFhHU2/DufFwIe+3KnWZhN6WX+uIxx3Tts8fgmAFC4mDcpW69dQtMfGZjG8SiXVWFgf6EUwyWg9DQgy51PwhdxDhXNXjHEQPfejtAMHTRPr/5yeheCG9MKd9Kk/0c1qHDUttMr3w0ZWtjSMmRd0pQ+Rvj1fu+d8ct9VGa7R/z/dYajx7WWXWk07H4/7gFL6dLy8S0JECThwxnhC8eRTr9VD2THaM61hbV1LL8erXzELuNEnXD/WFGiVqvXOoNXSgSQDYn7I9oMFvmKenwI8LEYsq8aJPBROiV3iYtu1ZCvmCFHUSfUfnOlrXXwhgh7qEBzidYgyFMJ0tIXPBPIASAC98hqXDS8XO5mgCWbTtf7uasCZ8aenXmSbdWolhkQ/TY5QCRYcWxZO/Y0+rdlltIoBMsICoA9aka+XCraKF0c5Tj9tCwb8IA+B7E8k4PxYkrDrYJEKLXVpRgIv3EcTnOZiPU/ydUQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB9203.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024)(22082099003)(18002099003)(56012099006)(4143699003)(5023799004)(11063799006);DIR:OUT;SFP:1101; X-Exchange-RoutingPolicyChecked: oUqGST2JVM/UdGTwr2bnCrwo36HB+Hi3jdVCjcMYGHlGzQ13yS1vMWwGSXIS0E1zKz9maokA28ZOG0GaHIoI95Ahh1EkklHzPHcnv6lkFXydU4roonAB97MumFy+5HBKKamnKp5KTgiHWvyRL+AOsr1YKwrc1DErWK9slGTPOBeixZppFt9D5YeGLHyYJWuXcLGlPptyDQOW6vYBdxuEEhURWxwuRWOJ3DMJaBJmYshfYQR87NjZ+jg3nLPTtdumn5jncVUyfVq1rCy2Uobhm2oyA3BAz8BhulmYGUmXVUk15rM8Atsn//m4lHqQo6NuxqU/EHYqjCRXqaNOexKkfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5644 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM3PEPF0000A79A.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c65a5cba-439f-4549-e91d-08debfd6039f X-Microsoft-Antispam: BCL:0;ARA:13230040|14060799003|7416014|376014|1800799024|35042699022|36860700016|82310400026|18002099003|22082099003|56012099006|4143699003|11063799006|5023799004; X-Microsoft-Antispam-Message-Info: WzRgc7lnt7gKXubh0BrABrW05+1l/GyzL50WrBfRLErWYYTDsMUtUGFY23Jqj8m2WmHSSzx84ufh4sThG5b+Vka8qYU4RwcL/tRUtTRjCMhkhML+L6OQ0GmNUJz7/I613dHTpmyfzxXolqKvdpt+8l4fNZGOE7EWgt38Qus0uigvtpaK/9UlmidETZIR8G6C4TTPbZcTVVfdAWovVlthqBLrg5cgs2MajIGCgSi0mewOdLrmxtKJnYnak10Xl4VH4Otj7hkJlM37Q762yVzxZey8DbRqyuG/g/rH4u7KaXF75Lk3DU/7l56ViQHkkkJ19ocJCZs2kce8op9rRCW6CBRizH4tR2/f9BuI1w/gY5RKVO4CupHX9cUyupnggz73Y+9aFUAj15eFJ5zhbSxygiAU3VW+GhTUxln9Tl1i7o4ZOitfXnqMoDRSXpfTd1blsLwb03ypegN4EP1kMw2ZPeqC14nREXquTczkAH1Ej87Vs+5/EfR4CJrESdstvRNKwEBqKmgVOG9SdE+GrSaFaxQLADG5mHzfFMQPCdsHxMDwDqNpNpymh7W7JbYsSRS1khc4T36gN/sctjXx9/yaKEmvMpz74aMQgO2I8YpYX4oojrCJZrgTgBcam/r5260O6aPv0gKT+m+TV88UCovi2UOke8oBV6oxGiWEzyd+1xKjptg/xzSERKUm7RYmBflJ0BdWr240+Fz9Lo5ADsvmrg0S86Su4YiQ6nT1P7EKhZg= X-Forefront-Antispam-Report: CIP:4.158.2.129;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:outbound-uk1.az.dlp.m.darktrace.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(14060799003)(7416014)(376014)(1800799024)(35042699022)(36860700016)(82310400026)(18002099003)(22082099003)(56012099006)(4143699003)(11063799006)(5023799004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: EKTCTmWJHEvcXecrMO1hKdVaYxRttGGs9BP3642dDeaMnWb4fsE6eI+4s9oeJG0H6CmdR+tFFFW2J48mIm4Hwisela8+EsC/jhJYK255VZA0JORRFNbMU5M+yWKiUHSHaolsHAhvhvNboUmiXSJTwO9IRBmldvAz8j1aCyFuN8OD46huxM0xTkUSUX8TrUYLbFY1BvPGAJsKz1RBmL69gQe1aAyOEwWprOnQn1ThkBw/IRC8Di7R84rSgu0G1/6psJwjEMMZMy3gjcoZ0t/G+ljYNdQyhksbDBeoYQpPBWPGnaME6s6Nw5NJL/BagC8CarElzbMokkb0UYvO8JHeN9xcauZMDKpgURkwlnr+huSyoIoyEr17YgUDnUEDuTQ6OIYJKX7aoST2Qwf8O3ExSdN8wc4Wtx5GZxdIZn3KhhWwL5xgtoCuOQ4l/J2fKbs0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2026 12:06:06.9443 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 95c0a2c7-256c-4498-de9d-08debfd6295b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[4.158.2.129];Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF0000A79A.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9739 Hi John! On 5/30/26 1:04 AM, John Hubbard wrote: > On 5/28/26 10:57 PM, Sarthak Sharma wrote: >> On 5/28/26 12:17 AM, Andrew Morton wrote: >>> On Wed, 27 May 2026 19:54:27 +0530 Sarthak Sharma wrote: > ... >> Thanks! I went through Sashiko's review. >> >> Both the points are valid but look very minor to me: one is a temporary >> x86 build issue fixed by the next patch and the other is stricter > > This is the sort of claim that an AI will make, in kernel code: "it's > just a temporary build issue". I've seen this happen during sessions > when I'm interrogating an AI about something. > > Don't be misled by AI's evaluations, as unless it is guided very > firmly (sashiko for example has fairly firm guidance, although still > a work in progress) it will provide routinely terrible advice about > how to deal with the kernel. > > I'm sure we have something in the "how to contribute" docs that > explain that patchsets must be bisectable and that there are no > "minor" build "issues"! > > I'd request that you study those docs and the surrounding ones, > it won't take long and it will help immunize you against the > various AI suggestions that seem to be unavoidable problems in > 2026. > > thanks, Thanks for the guidance. You're right, I shouldn't have called it a minor issue just because it was fixed in the next patch. I have sent a fixup that moves the Makefile hunk from patch 3 to patch 2, so every patch is buildable on its own. If I need to send a v5 after reviewer feedback, I'll fold this fixup into patch 2 directly.