Linux Documentation
 help / color / mirror / Atom feed
From: Dave Jiang <dave.jiang@intel.com>
To: Gregory Price <gourry@gourry.net>,
	Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: linux-doc@vger.kernel.org, linux-cxl@vger.kernel.org,
	corbet@lwn.net, dave@stgolabs.net, jonathan.cameron@huawei.com,
	alison.schofield@intel.com, vishal.l.verma@intel.com,
	ira.weiny@intel.com, dan.j.williams@intel.com,
	linux-kernel@vger.kernel.org, darren.kenny@oracle.com
Subject: Re: [PATCH] cxl: docs/devices Fix typos and clarify wording in device-types.rst
Date: Mon, 16 Jun 2025 15:32:44 -0700	[thread overview]
Message-ID: <b2acd80e-38ce-488f-a6d8-8bdad425534c@intel.com> (raw)
In-Reply-To: <aFBUGTM4fpwU749k@gourry-fedora-PF4VCD3F>



On 6/16/25 10:27 AM, Gregory Price wrote:
> On Sun, Jun 15, 2025 at 11:07:32PM -0700, Alok Tiwari wrote:
>>  Documentation/driver-api/cxl/devices/device-types.rst | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
> ...
>>  
>>  A Multi-Logical Device (MLD) is a device which may present multiple devices
>> -to one or more devices.
>> +to one or more hosts.
> 
> This is subtly incorrect.
> 
> A *Multi-Headed* MLD presents one or more devices to one or more hosts.
> 
> A *Multi-logical Device* presents one or more devices to one or more
> upstream devices (such as a switch).
> 
> You can have a Single-Headed Multi-Logical Device that presents 2
> "Logical Devices" to a single upstream device (host or switch).
> 
> So please change "one or more hosts" to "one or more upstream devices".
> 
> 
> With that change you may add
> 
> Reviewed-by: Gregory Price <gourry@gourry.net>

I fixed it up with your suggestion and applied to cxl/next. Please check and make sure the fix is correct. Thanks!

> 
> ~Gregory


  reply	other threads:[~2025-06-16 22:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-16  6:07 [PATCH] cxl: docs/devices Fix typos and clarify wording in device-types.rst Alok Tiwari
2025-06-16 17:27 ` Gregory Price
2025-06-16 22:32   ` Dave Jiang [this message]
2025-06-17  0:10     ` Gregory Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2acd80e-38ce-488f-a6d8-8bdad425534c@intel.com \
    --to=dave.jiang@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=alok.a.tiwari@oracle.com \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=darren.kenny@oracle.com \
    --cc=dave@stgolabs.net \
    --cc=gourry@gourry.net \
    --cc=ira.weiny@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox