From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 211827D2F0 for ; Mon, 1 Jul 2019 15:19:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728099AbfGAPSx (ORCPT ); Mon, 1 Jul 2019 11:18:53 -0400 Received: from mga14.intel.com ([192.55.52.115]:6226 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727423AbfGAPSx (ORCPT ); Mon, 1 Jul 2019 11:18:53 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jul 2019 08:18:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,439,1557212400"; d="scan'208";a="174254068" Received: from spandruv-desk.jf.intel.com ([10.54.75.31]) by orsmga002.jf.intel.com with ESMTP; 01 Jul 2019 08:18:52 -0700 Message-ID: Subject: Re: [UPDATE][PATCH 10/10] tools/power/x86: A tool to validate Intel Speed Select commands From: Srinivas Pandruvada To: Andy Shevchenko Cc: Darren Hart , Andy Shevchenko , Andriy Shevchenko , Jonathan Corbet , "Rafael J. Wysocki" , Alan Cox , Len Brown , prarit@redhat.com, darcari@redhat.com, Linux Documentation List , Linux Kernel Mailing List , Platform Driver Date: Mon, 01 Jul 2019 08:18:52 -0700 In-Reply-To: References: <20190630171408.8673-1-srinivas.pandruvada@linux.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-3.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, 2019-07-01 at 14:32 +0300, Andy Shevchenko wrote: > On Sun, Jun 30, 2019 at 8:14 PM Srinivas Pandruvada > wrote: > > > > The Intel(R) Speed select technologies contains four features. > > > > Performance profile:An non architectural mechanism that allows > > multiple > > optimized performance profiles per system via static and/or dynamic > > adjustment of core count, workload, Tjmax, and TDP, etc. aka ISS > > in the documentation. > > > > Base Frequency: Enables users to increase guaranteed base frequency > > on > > certain cores (high priority cores) in exchange for lower base > > frequency > > on remaining cores (low priority cores). aka PBF in the > > documenation. > > > > Turbo frequency: Enables the ability to set different turbo ratio > > limits > > to cores based on priority. aka FACT in the documentation. > > > > Core power: An Interface that allows user to define per core/tile > > priority. > > > > There is a multi level help for commands and options. This can be > > used > > to check required arguments for each feature and commands for the > > feature. > > > > To start navigating the features start with > > > > $sudo intel-speed-select --help > > > > For help on a specific feature for example > > $sudo intel-speed-select perf-profile --help > > > > To get help for a command for a feature for example > > $sudo intel-speed-select perf-profile get-lock-status --help > > > > Signed-off-by: Srinivas Pandruvada < > > srinivas.pandruvada@linux.intel.com> > > --- > > Updates: > > - Copied Makefile from tools/gpio and moified the Makefile here > > - Added entry to tools/build/Makefile > > - Rename directory to match the executable name > > - Fix one error message > > Thanks! > I pushed to my review and testing queue, while still waiting for some > ACKs. > > It seems I can promote the driver itself now,w/o tools, if you want > me to do so. I am fine with driver only push if we don't get ACK by your deadline for the next kernel. Thanks, Srinivas