From: Guillaume Tucker <gtucker@gtucker.io>
To: Nicolas Schier <n.schier@fritz.com>
Cc: "Nathan Chancellor" <nathan@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Onur Özkan" <work@onurozkan.dev>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
linux-doc@vger.kernel.org, workflows@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
kernelci@lists.linux.dev,
automated-testing@lists.yoctoproject.org
Subject: Re: [PATCH RESEND v3 1/3] scripts: add TOML config to container tool
Date: Mon, 7 Sep 2026 13:19:32 +0200 [thread overview]
Message-ID: <b2e8fda1-c41b-4b75-8d00-b38d8ed5be60@gtucker.io> (raw)
In-Reply-To: <20260904-invaluable-nifty-salmon-cf7767@l-nschier-aarch64>
On 04/09/2026 21:19, Nicolas Schier wrote:
> On Wed, Sep 02, 2026 at 11:33:00AM +0200, Guillaume Tucker wrote:
>> Add support for a TOML configuration file to the scripts/container
>> tool. This improves user experience by not having to keep passing the
>> same command line options all the time or overly relying on built-in
>> default values. Include the concept of 'profiles' with different
>> named sections in the file to cover various use cases.
>>
>> Command line options take precedence over the config file, and values
>> defined in profile sections take precedence over the default one.
>>
>> Add a -c option to override the location of the .container.toml config
>> file which should otherwise be located in the current working
>> directory. If not found, the file is silently ignored as it is not
>> strictly required unless the -c option is used.
>>
>> Add a -p option to choose a particular profile section in the config
>> file rather than the default.
>>
>> Signed-off-by: Guillaume Tucker <gtucker@gtucker.io>
>> ---
>>
>> Notes:
>> Changes in v2:
>> - fix uid / gid handling when set to 0 (root)
>>
>> Changes in v3:
>> - fix logic when loading config profiles using None
>> - fix typo with missing whitespace in help message
>> - clarify how UID gets used as default value for GID
>>
>> scripts/container | 89 ++++++++++++++++++++++++++++++++++++++++-------
>> 1 file changed, 77 insertions(+), 12 deletions(-)
>>
>
> Acked-by: Nicolas Schier <n.schier@fritz.com>
Thanks. Please note that I carried your Acked-by in the v4 I just
sent which drops the 'registry' option from the TOML config as it was
causing ambiguous situations when providing a full image name that
contained a registry. The rest of the patch was left as-is.
Best wishes,
Guillaume
prev parent reply other threads:[~2026-09-07 11:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 9:33 [PATCH RESEND v3 1/3] scripts: add TOML config to container tool Guillaume Tucker
2026-09-02 9:33 ` [PATCH RESEND v3 2/3] Documentation: dev-tools: update container.rst with config file Guillaume Tucker
2026-09-02 9:33 ` [PATCH RESEND v3 3/3] Documentation: dev-tools: refer to user ID rather than id Guillaume Tucker
2026-09-04 19:19 ` [PATCH RESEND v3 1/3] scripts: add TOML config to container tool Nicolas Schier
2026-09-07 11:19 ` Guillaume Tucker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2e8fda1-c41b-4b75-8d00-b38d8ed5be60@gtucker.io \
--to=gtucker@gtucker.io \
--cc=automated-testing@lists.yoctoproject.org \
--cc=corbet@lwn.net \
--cc=kernelci@lists.linux.dev \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=n.schier@fritz.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=ojeda@kernel.org \
--cc=work@onurozkan.dev \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox