From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 889E7223DD0; Tue, 15 Jul 2025 18:59:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752605944; cv=none; b=G9FGGf1Cmo3hIDP7pok19GQcLjkG7Ix/5wDRYPCCoxAHvCIeeWa+sI3PvESCuIg+7Ngsf/CPDCLPcRSJwm/Z63RWaJcQEdbdt6zUJzPDxuJkChbHUjxkwZk7AzdwPYaEa2vH0Gp77LTcAT5VSptkEyHrTHgqYWfVB2F3N6u9CMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752605944; c=relaxed/simple; bh=CvItC95DS+pbvx0GKSq0P7nNfXOXqmBFL0Kobkkiv8A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JaB1k2cGp11q/7Fg8D63/xg5BLc3ZDmNscTr/BOu+CpAOfMdvJm6Z7LMK0ldhjW61Qm4Ui5rRuyvQVZSuW5MtD6xv6hLiz3bQ+jXxeCbITnu8zE1Sbvzl0da8AWDGzaO3EbIzty2PjwWHq5WhWI+jwnCvqeht8df6DrlMRlTHNI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=na0gU3ju; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="na0gU3ju" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CD51C4CEE3; Tue, 15 Jul 2025 18:58:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752605944; bh=CvItC95DS+pbvx0GKSq0P7nNfXOXqmBFL0Kobkkiv8A=; h=Date:Reply-To:Subject:To:Cc:References:From:In-Reply-To:From; b=na0gU3ju6BrACgT56hXjDIK69gVbLb5PiNaKhAZOoEba9LTN4FExx7cfAlvFlV3Cg f4DbD59n23aS+dnmdfJskEfg+ljAFAZMtFt9HVh7y25YLEI4Xd6sEN0ajME1BGX35y um4aMP9s4MaiHzUs11/+puhm33+60IPMx2/eI38sS7JUtIQet0y7zBnSNmCwgho017 jznW4zFfDGPq+6BOxPUpWE42BA34ZSci3qiiqhoBASf2BHqNOemRy6hJqh4SqAO01i /DMg5bpGKk5ljmIEOhvhHd3D/veEQIPZ0Nt/MnbZCdxUXL9HjsM685OIr37Expfey6 +bSVK+N9VpUyQ== Message-ID: Date: Tue, 15 Jul 2025 20:58:57 +0200 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Daniel Gomez Subject: Re: [PATCH v3] module: Rename EXPORT_SYMBOL_GPL_FOR_MODULES to EXPORT_SYMBOL_FOR_MODULES To: Vlastimil Babka , Daniel Gomez , Matthias Maennich , Jonathan Corbet , Luis Chamberlain , Petr Pavlu , Sami Tolvanen , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Alexander Viro , Christian Brauner , Jan Kara Cc: Christoph Hellwig , Peter Zijlstra , David Hildenbrand , Shivank Garg , Greg Kroah-Hartman , "Jiri Slaby (SUSE)" , Stephen Rothwell , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20250715-export_modules-v3-1-11fffc67dff7@suse.cz> Content-Language: en-US From: Daniel Gomez Organization: kernel.org In-Reply-To: <20250715-export_modules-v3-1-11fffc67dff7@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 15/07/2025 10.43, Vlastimil Babka wrote: > Christoph suggested that the explicit _GPL_ can be dropped from the > module namespace export macro, as it's intended for in-tree modules > only. It would be possible to restrict it technically, but it was > pointed out [2] that some cases of using an out-of-tree build of an > in-tree module with the same name are legitimate. But in that case those > also have to be GPL anyway so it's unnecessary to spell it out in the > macro name. > > Link: https://lore.kernel.org/all/aFleJN_fE-RbSoFD@infradead.org/ [1] > Link: https://lore.kernel.org/all/CAK7LNATRkZHwJGpojCnvdiaoDnP%2BaeUXgdey5sb_8muzdWTMkA@mail.gmail.com/ [2] > Suggested-by: Christoph Hellwig > Reviewed-by: Shivank Garg > Acked-by: David Hildenbrand > Acked-by: Nicolas Schier > Reviewed-by: Daniel Gomez > Reviewed-by: Christian Brauner > Signed-off-by: Vlastimil Babka > --- > Daniel, please clarify if you'll take this via module tree or Christian > can take it via vfs tree? Patch 707f853d7fa3 ("module: Provide EXPORT_SYMBOL_GPL_FOR_MODULES() helper") from Peter was merged through Masahiro in v6.16-rc1. Since this is a related fix/rename/cleanup, it'd make sense for it to go through his kbuild tree as well. Masahiro, please let me know if you'd prefer otherwise. If not, I'll queue it up in the modules tree.