From: David Ahern <dsahern@kernel.org>
To: Mina Almasry <almasrymina@google.com>
Cc: "Paolo Abeni" <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, virtualization@lists.linux.dev,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
"Donald Hunter" <donald.hunter@gmail.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Simon Horman" <horms@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"Jeroen de Borst" <jeroendb@google.com>,
"Harshitha Ramamurthy" <hramamurthy@google.com>,
"Kuniyuki Iwashima" <kuniyu@amazon.com>,
"Willem de Bruijn" <willemb@google.com>,
"Neal Cardwell" <ncardwell@google.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Stefano Garzarella" <sgarzare@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Shuah Khan" <shuah@kernel.org>,
sdf@fomichev.me, asml.silence@gmail.com, dw@davidwei.uk,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
"Victor Nogueira" <victor@mojatatu.com>,
"Pedro Tammela" <pctammela@mojatatu.com>,
"Samiullah Khawaja" <skhawaja@google.com>,
"Kaiyuan Zhang" <kaiyuanz@google.com>
Subject: Re: [PATCH net-next v5 3/9] net: devmem: Implement TX path
Date: Wed, 26 Feb 2025 08:20:02 -0700 [thread overview]
Message-ID: <b4029bcd-3d47-4f24-956e-04033853c667@kernel.org> (raw)
In-Reply-To: <CAHS8izMc0NCMPvCGg-uAOeWaf+K-_EfHnK7+4i205dPUy9JBFA@mail.gmail.com>
On 2/25/25 11:54 AM, Mina Almasry wrote:
>
> Will do, although I think maybe I'll add that comment above the
> refcount_t definition in net_devmem_dmabuf_binding, if that's OK with
> you. That was meant to explain how the refcounting on the binding
> works.
>
That is fine, I just think the lifecycle of the dmabuf and what the
unbinding is really doing should be clearly documented to avoid surprises.
> Maybe worthy of note, this is not that new, in fact something similar
> is happening in the RX path. In the RX path each skb waiting in the
> receive queue to be recvmsg()'d will hold a reference on the
> underlying page_pool, which in-turn holds a reference on the
> underlying dmabuf. It's just that a similar thing is happening in the
> TX path.
>
next prev parent reply other threads:[~2025-02-26 15:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-22 19:15 [PATCH net-next v5 0/9] Device memory TCP TX Mina Almasry
2025-02-22 19:15 ` [PATCH net-next v5 1/9] net: add get_netmem/put_netmem support Mina Almasry
2025-02-22 19:15 ` [PATCH net-next v5 2/9] net: devmem: TCP tx netlink api Mina Almasry
2025-02-22 19:15 ` [PATCH net-next v5 3/9] net: devmem: Implement TX path Mina Almasry
2025-02-24 17:38 ` Stanislav Fomichev
2025-02-25 13:04 ` Paolo Abeni
2025-02-25 17:41 ` Mina Almasry
2025-02-25 18:03 ` David Ahern
2025-02-25 18:54 ` Mina Almasry
2025-02-26 15:20 ` David Ahern [this message]
2025-02-22 19:15 ` [PATCH net-next v5 4/9] net: devmem: make dmabuf unbinding scheduled work Mina Almasry
2025-02-25 13:08 ` Paolo Abeni
2025-02-22 19:15 ` [PATCH net-next v5 5/9] net: add devmem TCP TX documentation Mina Almasry
2025-02-22 19:15 ` [PATCH net-next v5 6/9] net: enable driver support for netmem TX Mina Almasry
2025-02-24 17:15 ` Stanislav Fomichev
2025-02-22 19:15 ` [PATCH net-next v5 7/9] gve: add netmem TX support to GVE DQO-RDA mode Mina Almasry
2025-02-22 19:15 ` [PATCH net-next v5 8/9] net: check for driver support in netmem TX Mina Almasry
2025-02-22 19:15 ` [PATCH net-next v5 9/9] selftests: ncdevmem: Implement devmem TCP TX Mina Almasry
2025-02-24 17:15 ` Stanislav Fomichev
2025-02-24 17:19 ` Mina Almasry
2025-02-24 17:54 ` Stanislav Fomichev
2025-02-25 2:53 ` [PATCH net-next v5 0/9] Device memory " Lei Yang
2025-02-25 3:19 ` Mina Almasry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4029bcd-3d47-4f24-956e-04033853c667@kernel.org \
--to=dsahern@kernel.org \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=asml.silence@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=horms@kernel.org \
--cc=hramamurthy@google.com \
--cc=jasowang@redhat.com \
--cc=jeroendb@google.com \
--cc=jhs@mojatatu.com \
--cc=kaiyuanz@google.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mst@redhat.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=sdf@fomichev.me \
--cc=sgarzare@redhat.com \
--cc=shuah@kernel.org \
--cc=skhawaja@google.com \
--cc=stefanha@redhat.com \
--cc=victor@mojatatu.com \
--cc=virtualization@lists.linux.dev \
--cc=willemb@google.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).