[PATCH] tools/docs/checktransupdate.py: fix missing prefix in f-string

[PATCH] tools/docs/checktransupdate.py: fix missing prefix in f-string

[LIU Haoyang]

Add a f prefix to f-string in checktransupdate.py.

Fixes: 63e96ce050e5 ("scripts: fix all issues reported by pylint")
Signed-off-by: LIU Haoyang <tttturtleruss@gmail.com>
---
 tools/docs/checktransupdate.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/docs/checktransupdate.py b/tools/docs/checktransupdate.py
index e894652369a5..bf735562aeeb 100755
--- a/tools/docs/checktransupdate.py
+++ b/tools/docs/checktransupdate.py
@@ -131,7 +131,7 @@ def check_per_file(file_path):
     opath = get_origin_path(file_path)
 
     if not os.path.isfile(opath):
-        logging.error("Cannot find the origin path for {file_path}")
+        logging.error(f"Cannot find the origin path for {file_path}")
         return
 
     o_from_head = get_latest_commit_from(opath, "HEAD")
-- 
2.53.0

Re: [PATCH] tools/docs/checktransupdate.py: fix missing prefix in f-string

[Dongliang Mu]

On 3/8/26 6:41 PM, LIU Haoyang wrote:
> Add a f prefix to f-string in checktransupdate.py.
>
> Fixes: 63e96ce050e5 ("scripts: fix all issues reported by pylint")
> Signed-off-by: LIU Haoyang <tttturtleruss@gmail.com>

Hi Haoyang,

could you help fix all the issues mentioned by pylint? There is another 
issue reported by pylint.


tools/docs/checktransupdate.py:79:4: C0103: Variable name "HASH" doesn't 
conform to snake_case naming style (invalid-name)

Dongliang Mu

> ---
>   tools/docs/checktransupdate.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/docs/checktransupdate.py b/tools/docs/checktransupdate.py
> index e894652369a5..bf735562aeeb 100755
> --- a/tools/docs/checktransupdate.py
> +++ b/tools/docs/checktransupdate.py
> @@ -131,7 +131,7 @@ def check_per_file(file_path):
>       opath = get_origin_path(file_path)
>   
>       if not os.path.isfile(opath):
> -        logging.error("Cannot find the origin path for {file_path}")
> +        logging.error(f"Cannot find the origin path for {file_path}")
>           return
>   
>       o_from_head = get_latest_commit_from(opath, "HEAD")

[PATCH v2] tools/docs/checktransupdate.py: fix all issues reported by pylint

[Haoyang LIU]

This patch fixes all issues reported by pylint, including:
1. Format issue in logging.
2. Variable name style issue.

Fixes: 63e96ce050e5 ("scripts: fix all issues reported by pylint")
Signed-off-by: Haoyang LIU <tttturtleruss@gmail.com>
---
V1 -> V2: fix variable name style name and keep the format consistent with other logging format

 tools/docs/checktransupdate.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/docs/checktransupdate.py b/tools/docs/checktransupdate.py
index e894652369a5..cc07cda667fc 100755
--- a/tools/docs/checktransupdate.py
+++ b/tools/docs/checktransupdate.py
@@ -76,11 +76,11 @@ def get_origin_from_trans_smartly(origin_path, t_from_head):
     (2) Update the translation through commit HASH (TITLE)
     """
     # catch flag for 12-bit commit hash
-    HASH = r'([0-9a-f]{12})'
+    hash_re = r'([0-9a-f]{12})'
     # pattern 1: contains "update to commit HASH"
-    pat_update_to = re.compile(rf'update to commit {HASH}')
+    pat_update_to = re.compile(rf'update to commit {hash_re}')
     # pattern 2: contains "Update the translation through commit HASH"
-    pat_update_translation = re.compile(rf'Update the translation through commit {HASH}')
+    pat_update_translation = re.compile(rf'Update the translation through commit {hash_re}')
 
     origin_commit_hash = None
     for line in t_from_head["message"]:
@@ -131,7 +131,7 @@ def check_per_file(file_path):
     opath = get_origin_path(file_path)
 
     if not os.path.isfile(opath):
-        logging.error("Cannot find the origin path for {file_path}")
+        logging.error("Cannot find the origin path for %s", file_path)
         return
 
     o_from_head = get_latest_commit_from(opath, "HEAD")
-- 
2.53.0

Re: [PATCH v2] tools/docs/checktransupdate.py: fix all issues reported by pylint

[Jonathan Corbet]

Haoyang LIU <tttturtleruss@gmail.com> writes:

> This patch fixes all issues reported by pylint, including:
> 1. Format issue in logging.
> 2. Variable name style issue.

I'm somewhat unconvinced about that second change.  We haven't come up
with a coding style for Python code in the kernel, but I think we do
want it to look at least a bit like kernel code and not just defer all
decisions to tools like pylint.  I'm not really opposed to this change
either, mind you, but the process of getting there worries me a bit.

> Fixes: 63e96ce050e5 ("scripts: fix all issues reported by pylint")
> Signed-off-by: Haoyang LIU <tttturtleruss@gmail.com>
> ---
> V1 -> V2: fix variable name style name and keep the format consistent with other logging format
>
>  tools/docs/checktransupdate.py | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/docs/checktransupdate.py b/tools/docs/checktransupdate.py
> index e894652369a5..cc07cda667fc 100755
> --- a/tools/docs/checktransupdate.py
> +++ b/tools/docs/checktransupdate.py
> @@ -76,11 +76,11 @@ def get_origin_from_trans_smartly(origin_path, t_from_head):
>      (2) Update the translation through commit HASH (TITLE)
>      """
>      # catch flag for 12-bit commit hash
> -    HASH = r'([0-9a-f]{12})'
> +    hash_re = r'([0-9a-f]{12})'
>      # pattern 1: contains "update to commit HASH"
> -    pat_update_to = re.compile(rf'update to commit {HASH}')
> +    pat_update_to = re.compile(rf'update to commit {hash_re}')
>      # pattern 2: contains "Update the translation through commit HASH"
> -    pat_update_translation = re.compile(rf'Update the translation through commit {HASH}')
> +    pat_update_translation = re.compile(rf'Update the translation through commit {hash_re}')
>  
>      origin_commit_hash = None
>      for line in t_from_head["message"]:
> @@ -131,7 +131,7 @@ def check_per_file(file_path):
>      opath = get_origin_path(file_path)
>  
>      if not os.path.isfile(opath):
> -        logging.error("Cannot find the origin path for {file_path}")
> +        logging.error("Cannot find the origin path for %s", file_path)

Why was this change made?  The first time around, you'd simply added the
obviously missing "f", which seems better?

Thanks,

jon

Re: [PATCH v2] tools/docs/checktransupdate.py: fix all issues reported by pylint

[Haoyang Liu]

On 3/9/2026 11:54 PM, Jonathan Corbet wrote:
> Haoyang LIU <tttturtleruss@gmail.com> writes:
>
>> This patch fixes all issues reported by pylint, including:
>> 1. Format issue in logging.
>> 2. Variable name style issue.
> I'm somewhat unconvinced about that second change.  We haven't come up
> with a coding style for Python code in the kernel, but I think we do
> want it to look at least a bit like kernel code and not just defer all
> decisions to tools like pylint.  I'm not really opposed to this change
> either, mind you, but the process of getting there worries me a bit.

Dear Jon,

My initial thought was that 'HASH' looks like a global-style constant, 
while it's actually a local variable. However, the lowercase 'hash' has 
conflict with python built-in hash function, so I renamed it to hash_re 
to indicate that it's a regular expression.

>
>> Fixes: 63e96ce050e5 ("scripts: fix all issues reported by pylint")
>> Signed-off-by: Haoyang LIU <tttturtleruss@gmail.com>
>> ---
>> V1 -> V2: fix variable name style name and keep the format consistent with other logging format
>>
>>   tools/docs/checktransupdate.py | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/tools/docs/checktransupdate.py b/tools/docs/checktransupdate.py
>> index e894652369a5..cc07cda667fc 100755
>> --- a/tools/docs/checktransupdate.py
>> +++ b/tools/docs/checktransupdate.py
>> @@ -76,11 +76,11 @@ def get_origin_from_trans_smartly(origin_path, t_from_head):
>>       (2) Update the translation through commit HASH (TITLE)
>>       """
>>       # catch flag for 12-bit commit hash
>> -    HASH = r'([0-9a-f]{12})'
>> +    hash_re = r'([0-9a-f]{12})'
>>       # pattern 1: contains "update to commit HASH"
>> -    pat_update_to = re.compile(rf'update to commit {HASH}')
>> +    pat_update_to = re.compile(rf'update to commit {hash_re}')
>>       # pattern 2: contains "Update the translation through commit HASH"
>> -    pat_update_translation = re.compile(rf'Update the translation through commit {HASH}')
>> +    pat_update_translation = re.compile(rf'Update the translation through commit {hash_re}')
>>   
>>       origin_commit_hash = None
>>       for line in t_from_head["message"]:
>> @@ -131,7 +131,7 @@ def check_per_file(file_path):
>>       opath = get_origin_path(file_path)
>>   
>>       if not os.path.isfile(opath):
>> -        logging.error("Cannot find the origin path for {file_path}")
>> +        logging.error("Cannot find the origin path for %s", file_path)
> Why was this change made?  The first time around, you'd simply added the
> obviously missing "f", which seems better?
I used the "%s" style mainly to keep the logging format consistent with 
the other logging statements in this file, which follow the same 
pattern. To me, using f-string or lazy format.

Sincerely,
Haoyang

>
> Thanks,
>
> jon

Re: [PATCH v2] tools/docs/checktransupdate.py: fix all issues reported by pylint

[刘浩阳]

Sent from my iPhone

> On 10 Mar 2026, at 00:56, Haoyang Liu <tttturtleruss@gmail.com> wrote:
> 
> 
>> On 3/9/2026 11:54 PM, Jonathan Corbet wrote:
>> Haoyang LIU <tttturtleruss@gmail.com> writes:
>> 
>>> This patch fixes all issues reported by pylint, including:
>>> 1. Format issue in logging.
>>> 2. Variable name style issue.
>> I'm somewhat unconvinced about that second change.  We haven't come up
>> with a coding style for Python code in the kernel, but I think we do
>> want it to look at least a bit like kernel code and not just defer all
>> decisions to tools like pylint.  I'm not really opposed to this change
>> either, mind you, but the process of getting there worries me a bit.
> 
> Dear Jon,
> 
> My initial thought was that 'HASH' looks like a global-style constant, while it's actually a local variable. However, the lowercase 'hash' has conflict with python built-in hash function, so I renamed it to hash_re to indicate that it's a regular expression.
> 
>> 
>>> Fixes: 63e96ce050e5 ("scripts: fix all issues reported by pylint")
>>> Signed-off-by: Haoyang LIU <tttturtleruss@gmail.com>
>>> ---
>>> V1 -> V2: fix variable name style name and keep the format consistent with other logging format
>>> 
>>>  tools/docs/checktransupdate.py | 8 ++++----
>>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>> 
>>> diff --git a/tools/docs/checktransupdate.py b/tools/docs/checktransupdate.py
>>> index e894652369a5..cc07cda667fc 100755
>>> --- a/tools/docs/checktransupdate.py
>>> +++ b/tools/docs/checktransupdate.py
>>> @@ -76,11 +76,11 @@ def get_origin_from_trans_smartly(origin_path, t_from_head):
>>>      (2) Update the translation through commit HASH (TITLE)
>>>      """
>>>      # catch flag for 12-bit commit hash
>>> -    HASH = r'([0-9a-f]{12})'
>>> +    hash_re = r'([0-9a-f]{12})'
>>>      # pattern 1: contains "update to commit HASH"
>>> -    pat_update_to = re.compile(rf'update to commit {HASH}')
>>> +    pat_update_to = re.compile(rf'update to commit {hash_re}')
>>>      # pattern 2: contains "Update the translation through commit HASH"
>>> -    pat_update_translation = re.compile(rf'Update the translation through commit {HASH}')
>>> +    pat_update_translation = re.compile(rf'Update the translation through commit {hash_re}')
>>>        origin_commit_hash = None
>>>      for line in t_from_head["message"]:
>>> @@ -131,7 +131,7 @@ def check_per_file(file_path):
>>>      opath = get_origin_path(file_path)
>>>        if not os.path.isfile(opath):
>>> -        logging.error("Cannot find the origin path for {file_path}")
>>> +        logging.error("Cannot find the origin path for %s", file_path)
>> Why was this change made?  The first time around, you'd simply added the
>> obviously missing "f", which seems better?
> I used the "%s" style mainly to keep the logging format consistent with the other logging statements in this file, which follow the same pattern. To me, using f-string or lazy format.
To me, using f-string or lazy format are the same. ( sorry for the unfinished message)

Haoyang
> 
> Sincerely,
> Haoyang
> 
>> 
>> Thanks,
>> 
>> jon

Re: [PATCH] tools/docs/checktransupdate.py: fix missing prefix in f-string

[Jonathan Corbet]

LIU Haoyang <tttturtleruss@gmail.com> writes:

> Add a f prefix to f-string in checktransupdate.py.
>
> Fixes: 63e96ce050e5 ("scripts: fix all issues reported by pylint")
> Signed-off-by: LIU Haoyang <tttturtleruss@gmail.com>
> ---
>  tools/docs/checktransupdate.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/docs/checktransupdate.py b/tools/docs/checktransupdate.py
> index e894652369a5..bf735562aeeb 100755
> --- a/tools/docs/checktransupdate.py
> +++ b/tools/docs/checktransupdate.py
> @@ -131,7 +131,7 @@ def check_per_file(file_path):
>      opath = get_origin_path(file_path)
>  
>      if not os.path.isfile(opath):
> -        logging.error("Cannot find the origin path for {file_path}")
> +        logging.error(f"Cannot find the origin path for {file_path}")
>          return

Applied, thanks.

jon