From: Markus Elfring <Markus.Elfring@web.de>
To: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>,
linux-sound@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [RFC PATCH] ALSA: pci: add PreSonus Quantum PCI driver
Date: Fri, 21 Aug 2026 20:10:55 +0200 [thread overview]
Message-ID: <b4e9a02d-4f48-4dd5-a6cc-2f98242151b2@web.de> (raw)
In-Reply-To: <20260820083646.11383-2-nicholas.johnson-opensource@outlook.com.au>
…
> +++ b/sound/pci/quantum/quantum_dma.c
> @@ -0,0 +1,853 @@
…
> +static void quantum_free_stream_pages(struct quantum_chip *chip,
> + struct quantum_stream *stream)
> +{
> + u32 i;
I suggest to move this variable declaration into the subsequent for loop header.
> + bool gone = pci_dev_is_disconnected(chip->pci);
I suggest to omit this variable definition. The mentioned function call
can be applied directly for a subsequent condition check (like it is also performed
in the implementation of the function “quantum_free_page_table”).
> +
> + if (!stream->owns_pages)
> + goto reset;
…
> + if (!gone) {
> + for (i = 0; i < stream->num_pages; i++)
…
Regards,
Markus
next prev parent reply other threads:[~2026-08-21 18:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 8:36 [RFC PATCH 0/1] ALSA: add PreSonus Quantum PCI driver Nicholas Johnson
2026-08-20 8:36 ` [RFC PATCH 1/1] ALSA: pci: " Nicholas Johnson
2026-08-21 12:44 ` [RFC PATCH] " Markus Elfring
2026-08-21 13:00 ` Markus Elfring
2026-08-21 13:34 ` [RFC PATCH 1/1] " Markus Elfring
2026-08-21 14:24 ` [RFC PATCH] " Markus Elfring
2026-08-21 18:10 ` Markus Elfring [this message]
2026-08-22 14:20 ` Markus Elfring
2026-08-22 15:21 ` [RFC PATCH 1/1] " Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4e9a02d-4f48-4dd5-a6cc-2f98242151b2@web.de \
--to=markus.elfring@web.de \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nicholas.johnson-opensource@outlook.com.au \
--cc=perex@perex.cz \
--cc=skhan@linuxfoundation.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox