From: Randy Dunlap <rdunlap@infradead.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Jonathan Corbet <corbet@lwn.net>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Arnd Bergmann <arnd@kernel.org>, Hans de Goede <hansg@kernel.org>,
linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Documentation: gpio: add documentation about using software nodes
Date: Sat, 16 Aug 2025 16:17:32 -0700 [thread overview]
Message-ID: <b69d92aa-2d41-4b79-ad15-75b73897e263@infradead.org> (raw)
In-Reply-To: <f93c26c6-c390-46d4-bdd1-4d2f0e03e63d@infradead.org>
On 8/16/25 3:21 PM, Randy Dunlap wrote:
>
>
> On 8/16/25 3:08 PM, Randy Dunlap wrote:
>> Hi,
>>
>> On 8/15/25 10:30 AM, Dmitry Torokhov wrote:
>>> Introduce documentation regarding use of software nodes to describe
>>> GPIOs on legacy boards that have not been converted to device tree.
>>>
>>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>>> ---
>>>
>>> v2: Addressed Randy's comments.
>>>
>>> Documentation/driver-api/gpio/board.rst | 65 ++++
>>> Documentation/driver-api/gpio/index.rst | 1 +
>>> .../driver-api/gpio/legacy-boards.rst | 298 ++++++++++++++++++
>>> 3 files changed, 364 insertions(+)
Hi Dmitry,
There are a few build errors with the example code. It's OK to leave that
as an exercise for the reader. :)
There are a few missing header files, but the biggest build warning/error
is a Section mismatch:
WARNING: modpost: gpio-swnodes: section mismatch in reference: myboard_exit+0x1f (section: .exit.text) -> myboard_swnodes (section: .init.rodata)
so myboard_swnodes should not be marked as __initconst.
cheers.
--
~Randy
next prev parent reply other threads:[~2025-08-16 23:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 17:30 [PATCH v2] Documentation: gpio: add documentation about using software nodes Dmitry Torokhov
2025-08-16 22:08 ` Randy Dunlap
2025-08-16 22:21 ` Randy Dunlap
2025-08-16 23:17 ` Randy Dunlap [this message]
2025-08-17 20:28 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b69d92aa-2d41-4b79-ad15-75b73897e263@infradead.org \
--to=rdunlap@infradead.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@kernel.org \
--cc=brgl@bgdev.pl \
--cc=corbet@lwn.net \
--cc=dmitry.torokhov@gmail.com \
--cc=hansg@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).