From: Julian Braha <julianbraha@gmail.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: nsc@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org,
jani.nikula@linux.intel.com, arnd@arndb.de,
stefan.hengelein@fau.de, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
nico@fluxnic.net, officialnaumansabir@gmail.com,
rdunlap@infradead.org, vegard.nossum@oracle.com, kees@kernel.org,
tj@kernel.org
Subject: Re: [PATCH] Documentation: warn against using int, hex, string options as expressions in Kconfig
Date: Fri, 31 Jul 2026 10:43:34 +0100 [thread overview]
Message-ID: <b756801d-873a-4b77-9385-d4a43f7dd28e@gmail.com> (raw)
In-Reply-To: <178545753473.3004192.2499981065379649802.b4-review@b4>
On 7/31/26 01:25, Nathan Chancellor wrote:
> Drop this quoting of y for clarity?
Sure, I'll send a v2.
>> This 'if FOO' will always be false, regardless of FOO's value (even when
>> FOO=1). The same goes for strings and hex.
> Hmmm, it might be kind of nice to either:
>
> 1. Warn about this in Kconfig directly (if possible)
> 2. Support this usage in Kconfig how one would intuitively expect from
> either C or Python where symbols with values of 0, 0x0, and '' would
> be treated as false and every other value set as true.
Agreed, an interpreter change for this is on my roadmap. Though I was
also considering to make this error out.
Would be good to get some more feedback from others on which approach is
preferred (Jani, Arnd?)
> That said, until either of those potentially happen, this patch seems
> fine.
Thanks for your review!
- Julian Braha
next prev parent reply other threads:[~2026-07-31 9:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 14:01 [PATCH] Documentation: warn against using int, hex, string options as expressions in Kconfig Julian Braha
2026-07-31 0:25 ` Nathan Chancellor
2026-07-31 9:43 ` Julian Braha [this message]
2026-07-31 10:33 ` Arnd Bergmann
2026-07-31 0:32 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b756801d-873a-4b77-9385-d4a43f7dd28e@gmail.com \
--to=julianbraha@gmail.com \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=jani.nikula@linux.intel.com \
--cc=kees@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=nico@fluxnic.net \
--cc=nsc@kernel.org \
--cc=officialnaumansabir@gmail.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=stefan.hengelein@fau.de \
--cc=tj@kernel.org \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox