linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Akira Yokosawa <akiyks@gmail.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: pdfdocs: Fix typo in CJK-language specific font settings
Date: Sat, 4 Sep 2021 14:20:17 +0900	[thread overview]
Message-ID: <bb148975-2839-7ad7-8bd0-b3b844820c9a@gmail.com> (raw)
In-Reply-To: <ad7615a5-f8fa-2bc3-de6b-7ed49d458964@gmail.com>

Hi Jon, [most CCs dropped]

Just a reminder in case you have missed this fix.

On Sun, 29 Aug 2021 11:06:16 +0900, Akira Yokosawa wrote:
> There were typos in the fallback definitions of dummy LaTeX macros
> for systems without CJK fonts.
> They cause build errors in "make pdfdocs" on such systems.
> Fix them.
> 
> Fixes: e291ff6f5a03 ("docs: pdfdocs: Add CJK-language-specific font settings")
> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
> ---
> Hi Jon,
> 
> I thought I had tested the v4 patch on a container image
> without any CJK fonts, but apparently I had not.
> 
> These typos affect "make pdfdocs" of all the English documents
> as well.
> So, if this doesn't make the initial pull request for v5.15,
> please consider sending it as an urgent pull request during
> -rc stages of v5.15.

I think this regression fix should go to v5.15.
What do you think?

        Thanks, Akira

> 
> Apologies for the lack of test on my side. 
> 
>         Thanks, Akira
> --
>  Documentation/conf.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/conf.py b/Documentation/conf.py
> index 75650f6443af..948a97d6387d 100644
> --- a/Documentation/conf.py
> +++ b/Documentation/conf.py
> @@ -463,8 +463,8 @@ latex_elements['preamble']  += '''
>  	\\newcommand{\\kerneldocEndTC}{}
>  	\\newcommand{\\kerneldocBeginKR}{}
>  	\\newcommand{\\kerneldocEndKR}{}
> -	\\newcommand{\\kerneldocBeginSC}{}
> -	\\newcommand{\\kerneldocEndKR}{}
> +	\\newcommand{\\kerneldocBeginJP}{}
> +	\\newcommand{\\kerneldocEndJP}{}
>      }
>  '''
>  
> 

  reply	other threads:[~2021-09-04  5:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-29  2:06 [PATCH] docs: pdfdocs: Fix typo in CJK-language specific font settings Akira Yokosawa
2021-09-04  5:20 ` Akira Yokosawa [this message]
2021-09-06 22:55   ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb148975-2839-7ad7-8bd0-b3b844820c9a@gmail.com \
    --to=akiyks@gmail.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).