From: "Chuck Lever" <cel@kernel.org>
To: "Jeff Layton" <jlayton@kernel.org>,
"Chuck Lever" <chuck.lever@oracle.com>,
NeilBrown <neil@brown.name>,
"Olga Kornievskaia" <okorniev@redhat.com>,
"Dai Ngo" <Dai.Ngo@oracle.com>, "Tom Talpey" <tom@talpey.com>,
"Trond Myklebust" <trondmy@kernel.org>,
"Anna Schumaker" <anna@kernel.org>
Cc: "Alexander Aring" <alex.aring@gmail.com>,
"Amir Goldstein" <amir73il@gmail.com>, "Jan Kara" <jack@suse.cz>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Christian Brauner" <brauner@kernel.org>,
"Calum Mackay" <calum.mackay@oracle.com>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH v4 20/21] nfsd: track requested dir attributes
Date: Fri, 22 May 2026 09:24:20 -0400 [thread overview]
Message-ID: <be0feab5-5be2-495f-beb4-bae9cd876e30@app.fastmail.com> (raw)
In-Reply-To: <20260522-dir-deleg-v4-20-2acb883ac6bc@kernel.org>
On Fri, May 22, 2026, at 8:29 AM, Jeff Layton wrote:
> Track the union of requested and supported dir attributes in the
> delegation, and only encode the attributes in that union when sending
> add/remove/rename updates.
Nit: The encode-time use of dl_notify_mask for NOTIFY4_CHANGE_DIR_ATTRS
is wired up in 21/21. This patch adds only the tracking; the per-event
encoder change lives in the subsequent patch.
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> fs/nfsd/nfs4proc.c | 9 ++++++---
> fs/nfsd/nfs4state.c | 14 +++++++++++++-
> fs/nfsd/state.h | 2 ++
> 3 files changed, 21 insertions(+), 4 deletions(-)
--
Chuck Lever
next prev parent reply other threads:[~2026-05-22 13:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 12:28 [PATCH v4 00/21] nfsd: add support for CB_NOTIFY callbacks in directory delegations Jeff Layton
2026-05-22 12:28 ` [PATCH v4 01/21] nfsd: check fl_lmops in nfsd_breaker_owns_lease() Jeff Layton
2026-05-22 12:28 ` [PATCH v4 02/21] nfsd: add protocol support for CB_NOTIFY Jeff Layton
2026-05-22 12:28 ` [PATCH v4 03/21] nfs_common: add new NOTIFY4_* flags proposed in RFC8881bis Jeff Layton
2026-06-08 16:23 ` Chuck Lever
2026-06-08 16:37 ` Jeff Layton
2026-05-22 12:28 ` [PATCH v4 04/21] nfsd: allow nfsd to get a dir lease with an ignore mask Jeff Layton
2026-05-22 12:28 ` [PATCH v4 05/21] nfsd: update the fsnotify mark when setting or removing a dir delegation Jeff Layton
2026-05-22 12:28 ` [PATCH v4 06/21] nfsd: make nfsd4_callback_ops->prepare operation bool return Jeff Layton
2026-05-22 12:28 ` [PATCH v4 07/21] nfsd: add callback encoding and decoding linkages for CB_NOTIFY Jeff Layton
2026-05-22 12:28 ` [PATCH v4 08/21] nfsd: use RCU to protect fi_deleg_file Jeff Layton
2026-05-22 12:28 ` [PATCH v4 09/21] nfsd: add data structures for handling CB_NOTIFY Jeff Layton
2026-05-22 12:28 ` [PATCH v4 10/21] nfsd: add notification handlers for dir events Jeff Layton
2026-05-22 12:29 ` [PATCH v4 11/21] nfsd: add tracepoint to dir_event handler Jeff Layton
2026-05-22 14:31 ` Steven Rostedt
2026-05-22 14:37 ` Jeff Layton
2026-05-22 12:29 ` [PATCH v4 12/21] nfsd: apply the notify mask to the delegation when requested Jeff Layton
2026-05-22 12:29 ` [PATCH v4 13/21] nfsd: add helper to marshal a fattr4 from completed args Jeff Layton
2026-05-22 12:29 ` [PATCH v4 14/21] nfsd: allow nfsd4_encode_fattr4_change() to work with no export Jeff Layton
2026-05-22 12:29 ` [PATCH v4 15/21] nfsd: send basic file attributes in CB_NOTIFY Jeff Layton
2026-05-22 12:29 ` [PATCH v4 16/21] nfsd: allow encoding a filehandle into fattr4 without a svc_fh Jeff Layton
2026-05-22 12:29 ` [PATCH v4 17/21] nfsd: add a fi_connectable flag to struct nfs4_file Jeff Layton
2026-05-22 12:29 ` [PATCH v4 18/21] nfsd: add the filehandle to returned attributes in CB_NOTIFY Jeff Layton
2026-05-22 12:29 ` [PATCH v4 19/21] nfsd: properly track requested child attributes Jeff Layton
2026-05-22 12:29 ` [PATCH v4 20/21] nfsd: track requested dir attributes Jeff Layton
2026-05-22 13:24 ` Chuck Lever [this message]
2026-05-22 12:29 ` [PATCH v4 21/21] nfsd: add support to CB_NOTIFY for dir attribute changes Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be0feab5-5be2-495f-beb4-bae9cd876e30@app.fastmail.com \
--to=cel@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=alex.aring@gmail.com \
--cc=amir73il@gmail.com \
--cc=anna@kernel.org \
--cc=brauner@kernel.org \
--cc=calum.mackay@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox