From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A44933A9E2; Mon, 8 Jun 2026 16:24:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780935855; cv=none; b=IqqfjjfnC53wbnmBEKRxQydEPifGr4tD5RcZTeISYjDjrlzA013kxiNLTopds80mbPqQPAVqzfshYTKB/BOg7fxwz2yN2fEG1lN+rDBTcLhDZbYk7uX0/qcUeg8lzyDtLvvzJoZAdKoagrCEjxF+KdlnGB5Lkm3VRVZ2Te1fbBA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780935855; c=relaxed/simple; bh=Za+kVPKa2AwiJlfvCP8JXIj/JufkaNptoX+jtK/OG4U=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=qn0t0IXVcn2eGKLT/2gRAZlE9eClM668XQbmhtBZLz0wM+RWWFRxtBHcEHbm4dGSx9XBQdA650sk3ewFDd9HfTI5CTBBgzEC+T95suIK3/d3tVy/CAwLaW+434zwcmjWbMFlw07cs0EOv31UPOGGTwwQ5tbQzgAIR6Q3KQv1jqg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Et3aoZm+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Et3aoZm+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 100771F00899; Mon, 8 Jun 2026 16:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780935854; bh=ugksCuZC6wpT8aoAPTtnEfz1vWdw++QWxPb73hfX0tE=; h=Date:From:To:Cc:In-Reply-To:References:Subject; b=Et3aoZm+WNr1t39h4ncJiaJl6w6jdfnKOfEqb8+vRZj8vRQFaHjffWdbQC3rA/pCy w4ASbpQvNjxdBtmDE+AnQXqO1V2b0PE6iAmtaLlgIDXynAtN+m2/K/HPrK89YvrPkl tBPnp/2Dk0hQn4bHrdedeMpS5Szoemj8wClyu/RpwxX74PnmLoO1HNdoTI8Tdx9HEV d9ugxVJLdK0cBa+7rfQc6Oadx8wGDCDVpWPfEROikE7cboEhr5/1BpikHDUpjeCb/G xKG6Gr286DalFeoUsNz1tqWNvAHz1zUUqVNRF8lioXF9avjviiZLhEvGiO91VgJwB0 pRhy4xqiraSMg== Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfauth.phl.internal (Postfix) with ESMTP id 401A7F40074; Mon, 8 Jun 2026 12:24:13 -0400 (EDT) Received: from phl-imap-15 ([10.202.2.104]) by phl-compute-10.internal (MEProxy); Mon, 08 Jun 2026 12:24:13 -0400 X-ME-Sender: X-ME-Proxy-Cause: dmFkZTGQmWP4SITDFdMmfoDJDOuHGc1AaRMxLeXAu25kBSoaFZUGyn073Z/HvyUkjm7D0b fmLdunJCKPvgIljEQxSn3ir84MvS4jmma0tlBYTFyCmx7vmi0dcslya/La3iii/TW+kKj9 0OqtBp4mwrB4XUVf+p3QHZMGO0HS8q1i6RESaNM1qy9rWA0QKx7kk/dcEZZ9aGpsr5H6ac ogdi2FKNtuHja0VDvt2mZ2Z71je/WPat2NF3nAp8gjjVYRWP9qpe495LGuShoudO4JSybg 7HpBSQuxmYL74PK/sKLgZcVEuWgVYtG/tJdhFxVOJwr8OEX7tnd+e2MYUvaQMjQ7xc7HDe R+29UGY8yNLkdyys4YRDpxM8yCS0AwRsq1U9jBtUFJ05hVMbBZohJQB7Ktl2B8+V+5yyQZ MTn0tbgEOkjodLc+Wm+TK/aLU1JowvIwSE7uaZ6A5U3Srw8wEcsjFWowxlKtZEEtW8hNZb c8G3gUK0AaRo+gYhMDz4hzpYTGems7UC1mNb3tftTvD9Gz1Ldt4nFWe0dHODDpCFb8UJZd V5tdbvwA2XicxlH3/o+jcBxZTicSIOsZ/KUVjcaSmIL8AV6lEu04xIgkbe6xfujgdBML0j YR6DfweizacgTnpCE7OVtjBzVZRGQjJ+2+Y8035Nmslii09OTGx2WUDeZdBw X-ME-Proxy: Feedback-ID: ifa6e4810:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 11D81780075; Mon, 8 Jun 2026 12:24:13 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AD4ixzKPKzqo Date: Mon, 08 Jun 2026 12:23:52 -0400 From: "Chuck Lever" To: "Jeff Layton" , "Chuck Lever" , NeilBrown , "Olga Kornievskaia" , "Dai Ngo" , "Tom Talpey" , "Trond Myklebust" , "Anna Schumaker" Cc: "Alexander Aring" , "Amir Goldstein" , "Jan Kara" , "Alexander Viro" , "Christian Brauner" , "Calum Mackay" , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-nfs@vger.kernel.org Message-Id: In-Reply-To: <20260522-dir-deleg-v4-3-2acb883ac6bc@kernel.org> References: <20260522-dir-deleg-v4-0-2acb883ac6bc@kernel.org> <20260522-dir-deleg-v4-3-2acb883ac6bc@kernel.org> Subject: Re: [PATCH v4 03/21] nfs_common: add new NOTIFY4_* flags proposed in RFC8881bis Content-Type: text/plain Content-Transfer-Encoding: 7bit Unfortunately, reviewing this series slipped off my radar. I'm just now getting to it. I'm going to do this in order and some of the earlier reviews are cosmetic. But there are some significant changes needed later on, so I expect we'll need to redrive this series and punt it to v7.3. One thing you might update before you repost is to remove the "Acked-by: Chuck Lever" throughout the series. Nit: the Subject: prefix should be "nfsd:" not "nfs_common:" On Fri, May 22, 2026, at 8:28 AM, Jeff Layton wrote: > RFC8881bis adds some new flags to GET_DIR_DELEGATION that we very much > need to support. Nit: Let's say: "RFC8881bis adds new flags to GET_DIR_DELEGATION that later patches consume." One recent private comment to me was a question about whether we can trust the stability of the specification, which is still a WG document and has been for years. This patch's commit message should address that. > diff --git a/Documentation/sunrpc/xdr/nfs4_1.x > b/Documentation/sunrpc/xdr/nfs4_1.x > index 632f5b579c39..aa14b590b524 100644 > --- a/Documentation/sunrpc/xdr/nfs4_1.x > +++ b/Documentation/sunrpc/xdr/nfs4_1.x > @@ -416,7 +416,21 @@ enum notify_type4 { > NOTIFY4_REMOVE_ENTRY = 2, > NOTIFY4_ADD_ENTRY = 3, > NOTIFY4_RENAME_ENTRY = 4, > - NOTIFY4_CHANGE_COOKIE_VERIFIER = 5 > + NOTIFY4_CHANGE_COOKIE_VERIFIER = 5, > + /* > + * Added in NFSv4.1 bis document > + */ I clarified this comment: "/* Proposed in RFC8881bis */" I rebuilt the generated source to confirm that it hasn't been altered by recent changes to xdrgen or this comment change. The only thing that changed in the output was the header's timestamp. -- Chuck Lever