From: Randy Dunlap <rdunlap@infradead.org>
To: Manuel Ebner <manuelebnerli@mailbox.org>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] Documentation: trace: histogram-design: fix bracket
Date: Wed, 2 Sep 2026 10:17:17 -0700 [thread overview]
Message-ID: <c0edc549-7dd1-4d96-a4d2-55ec6fee5caf@infradead.org> (raw)
In-Reply-To: <20260902151032.706407-2-manuelebnerli@mailbox.org>
On 9/2/26 8:10 AM, Manuel Ebner wrote:
> Remove needless ')' from sentence.
>
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
> ---
> Documentation/trace/histogram-design.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/trace/histogram-design.rst b/Documentation/trace/histogram-design.rst
> index 41a726cd3..b757afa22 100644
> --- a/Documentation/trace/histogram-design.rst
> +++ b/Documentation/trace/histogram-design.rst
> @@ -876,7 +876,7 @@ next_pid field on this sched_switch event, we retrieve the
> variables specified in the wakeup_latency() trace action, and use
> them to generate a new wakeup_latency event into the trace stream.
>
> -Note that the way the trace handlers such as wakeup_latency() (which
> +Note that the way the trace handlers such as wakeup_latency() which
> could equivalently be written trace(wakeup_latency,$wakeup_lat,next_pid)
> are implemented, the parameters specified to the trace handler must be
> variables. In this case, $wakeup_lat is obviously a variable, but
Seems to me that the "which ..." should be a parenthetical phrase,
i.e., with parentheses at both ends of it. IMO.
But let's see the the TRACE maintainers have an opinion about it.
--
~Randy
next prev parent reply other threads:[~2026-09-02 17:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 15:10 [PATCH] Documentation: trace: histogram-design: fix bracket Manuel Ebner
2026-09-02 17:17 ` Randy Dunlap [this message]
2026-09-02 18:15 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0edc549-7dd1-4d96-a4d2-55ec6fee5caf@infradead.org \
--to=rdunlap@infradead.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=manuelebnerli@mailbox.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox