From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85EDD245022 for ; Tue, 1 Jul 2025 12:29:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751372987; cv=none; b=bQEv0CxvR4zbuewRBdXc5S2xyXocVCfpAIC2reHuM+G+xZJruZsWuIXqT1q4Ty9SYIVZBYla+kmp/4AkC0t/hJH3qXvYrFAtKjzkIyX/pjmEAS9wx7A59txKSdrhm5BOYuqhpwXW7wAo/0gtpVmr+pT2MoMNYlj2Br4evqZBw8k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751372987; c=relaxed/simple; bh=HA/IaYAtviTzbiEGMrzWF/n5gDTxFeZ2JLbcBiPxXXw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tlYEi4wTAvu2KMnYcCvPo1Hw9E/KR5i23jVUHKT4JMokz/5b1mDlAmby/2FGq8txhSsztaqKQAm/UfRoyGBKKzybgAio1meoYq/vMBfGyDfgOJR/ZHa4bUeU62NgznBUevKdcJH7mh/xfY1kGlKuPlmuIUAyu+rAadCZ9ynxCsg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SNKS3zgr; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SNKS3zgr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751372984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TrbuVM+ppzwgXrUIdBEtP31BskfLOvpW3vqC5pXRcG0=; b=SNKS3zgrUzusj3ybA6nB6YclNJLP9PT7mfgjn+xMKPsHKRcQqaYxb2mvaPV7TbMfL+Q2pm hrMEkQ9I7bawO1RdZIxJuLIh7FurnJ52PBbqHAEhsFpFm+CNg0wECMhX/cPm/wDOvdNdfI Txj12u8dasK6rPugsNCAquCgCOfvc7I= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-3-ADOlVCotP7ewSN96DDIOhQ-1; Tue, 01 Jul 2025 08:29:43 -0400 X-MC-Unique: ADOlVCotP7ewSN96DDIOhQ-1 X-Mimecast-MFC-AGG-ID: ADOlVCotP7ewSN96DDIOhQ_1751372982 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-45311704cdbso22018575e9.1 for ; Tue, 01 Jul 2025 05:29:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751372982; x=1751977782; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=TrbuVM+ppzwgXrUIdBEtP31BskfLOvpW3vqC5pXRcG0=; b=K0cToTMxcyTflVEt6dB6LMiA9lSirCn2HD//jhKbiMuwao0QvF7uRlmNvrF72kCfkl 7gm8JYnMFTBFeRhMIs/Hg3ra/d3H0EPOI5v/IUqUHNBYGl96d5vr99Xv2dAcJm1G7WmO 4U9VHaXPXCpGHOzLB0imbtj/Gies/vkWyM9SqYG0FAjVB3I0F5/sZc0fHc+GiE0BAu1D fkb5662CkFF6ENfhqMX7uQiy/kBCGRz1zlSGA7MDDBzjw3GLn+ttHUhr4Cl0fiI54gas sovJ3K1PIuh/YbhcFsExZwftvPxc6i5sYZ2EOOx6dy+r0ALLDEwvaOmsE6MtOKvqnBI1 1Rog== X-Forwarded-Encrypted: i=1; AJvYcCVXz34qcDbfzBUPQbdDqPcm/VQeTcgKIuhd6l/YYKp212hQuQ6Yelyq73yWB/8pcH8cX3dNN/s8/lY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzky+9cfL80CRca+8ERSCXEpzmam4bHyeloaw3LAKztYiFsSh9P /dVSd+PH1OK494j4aJ2WBZz1d5A0IuCtns6i7O+VDI9kkG0wqGuiqOlrWDv5XRfmpscaYDbZm1G +bFiJPCBdFH5pv3fmo4HbkWzspOuuQmoCpdHxqYmGdzyjS1YOOtMNbo1KstIFIQ== X-Gm-Gg: ASbGncus7bNcLt0LVimzmhlrITrRNKAGpDKyoN5A0Ul38vn2Bbq3XISY7b/EsLKqFaz WvSJwvrtc+2bAOmEa4GQaNI7LhBHuS/o/W+e6mKb8FuQ3VoyYxE/fRlaGLWxjqxA/KGneIx/Sy8 TaUakhUxntGyvn4tPcrO6Dk3B9HybF9nkhSQJyX+7dx75TzDhlp6CzjAfiarLZqOVn6fUn4kyLa 2KorJPWrGg/zSvarrcPXN2QYDRsgaxkWL777RNxerrFyXecQCAxNh2LYIKynPCbQnPv2ey56LLA hKFcDBfmUc5kuV++o+U6sUxynQxo/+XQ4hYo1D7isorq2svYoX2EQpKzGJlBHqdJdyRv7SZgROa S0XM6f8KeHYkkyBxzsgqjTrRHJMfSktIfTuA8ejKjxF4cmLG1oA== X-Received: by 2002:a05:600c:470a:b0:43d:878c:7c40 with SMTP id 5b1f17b1804b1-4538ee5d02dmr227232525e9.10.1751372981718; Tue, 01 Jul 2025 05:29:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEWGLUM6qAW2QhCkuZ0jAVZEDYU8qdTgiLFCHykWjvjhd9I7XaZDJCAwUz6gENIyzN0qXG81w== X-Received: by 2002:a05:600c:470a:b0:43d:878c:7c40 with SMTP id 5b1f17b1804b1-4538ee5d02dmr227232065e9.10.1751372981213; Tue, 01 Jul 2025 05:29:41 -0700 (PDT) Received: from ?IPV6:2003:d8:2f18:7500:202e:b0f1:76d6:f9af? (p200300d82f187500202eb0f176d6f9af.dip0.t-ipconnect.de. [2003:d8:2f18:7500:202e:b0f1:76d6:f9af]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453823c42e1sm193198075e9.37.2025.07.01.05.29.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 05:29:40 -0700 (PDT) Message-ID: Date: Tue, 1 Jul 2025 14:29:38 +0200 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 16/29] mm: rename __PageMovable() to page_has_movable_ops() To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250630130011.330477-1-david@redhat.com> <20250630130011.330477-17-david@redhat.com> <9a6b403e-ac92-4e4a-8d72-86dade5b9653@lucifer.local> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <9a6b403e-ac92-4e4a-8d72-86dade5b9653@lucifer.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01.07.25 12:59, Lorenzo Stoakes wrote: > On Mon, Jun 30, 2025 at 02:59:57PM +0200, David Hildenbrand wrote: >> Let's make it clearer that we are talking about movable_ops pages. >> >> While at it, convert a VM_BUG_ON to a VM_WARN_ON_ONCE_PAGE. > > <3 > >> >> Reviewed-by: Zi Yan >> Signed-off-by: David Hildenbrand > > Great, love it. > > Reviewed-by: Lorenzo Stoakes > > I noticed that the Simplified Chinese documentation has references for this, but > again we have to defer to somebody fluent in this of course! > > but also in mm/memory_hotplug.c in scan_movable_pages(): > > /* > * PageOffline() pages that are not marked __PageMovable() and > > Trivial one but might be worth fixing that up also? Ah, yes, missed that, burried under the the Chinese doc occurrences. diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 5fad126949d08..69a636e20f7bb 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1763,7 +1763,7 @@ static int scan_movable_pages(unsigned long start, unsigned long end, goto found; /* - * PageOffline() pages that are not marked __PageMovable() and + * PageOffline() pages that do not have movable_ops and * have a reference count > 0 (after MEM_GOING_OFFLINE) are * definitely unmovable. If their reference count would be 0, * they could at least be skipped when offlining memory. -- Cheers, David / dhildenb