From: Randy Dunlap <rdunlap@infradead.org>
To: Yunsheng Lin <linyunsheng@huawei.com>,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Lorenzo Bianconi <lorenzo@kernel.org>,
Alexander Duyck <alexander.duyck@gmail.com>,
Liang Chen <liangchen.linux@gmail.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Eric Dumazet <edumazet@google.com>,
Jonathan Corbet <corbet@lwn.net>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
linux-doc@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH net-next v6 5/6] page_pool: update document about frag API
Date: Tue, 15 Aug 2023 08:12:47 -0700 [thread overview]
Message-ID: <c52210ab-48a5-d6bf-26ee-b828df0f9408@infradead.org> (raw)
In-Reply-To: <0cbf592e-2f21-30ca-799e-5cc15e89c3f8@huawei.com>
On 8/15/23 05:24, Yunsheng Lin wrote:
> On 2023/8/15 6:42, Randy Dunlap wrote:
>> Hi--
> Thanks for the reviewing.
>
> ...
>
>>> @@ -100,6 +115,14 @@ static inline struct page *page_pool_alloc_frag(struct page_pool *pool,
>>> return __page_pool_alloc_frag(pool, offset, size, gfp);
>>> }
>>> +/**
>>> + * page_pool_dev_alloc_frag() - allocate a page frag.
>>> + * @pool[in] pool from which to allocate
>>> + * @offset[out] offset to the allocated page
>>> + * @size[in] requested size
>> Please use kernel-doc syntax/notation here.
> Will change to:
Thanks. Those look good.
--
~Randy
prev parent reply other threads:[~2023-08-15 15:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230814125643.59334-1-linyunsheng@huawei.com>
2023-08-14 12:56 ` [PATCH net-next v6 5/6] page_pool: update document about frag API Yunsheng Lin
2023-08-14 22:42 ` Randy Dunlap
2023-08-15 12:24 ` Yunsheng Lin
2023-08-15 15:12 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c52210ab-48a5-d6bf-26ee-b828df0f9408@infradead.org \
--to=rdunlap@infradead.org \
--cc=aleksander.lobakin@intel.com \
--cc=alexander.duyck@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=liangchen.linux@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).