From: Guenter Roeck <linux@roeck-us.net>
To: Brian Chiang <chiang.brian@inventec.com>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: (pmbus/lx1308) Add LX1308 support
Date: Mon, 27 Apr 2026 06:35:59 -0700 [thread overview]
Message-ID: <c59f9d11-d79d-46f8-b48d-9a2cd7921510@roeck-us.net> (raw)
In-Reply-To: <bnyp2ct63m2p2ln52lnmrxjrh7bgwfcelekeptbj6j3vgygpae@og4y7ul7gumz>
On 4/27/26 04:15, Brian Chiang wrote:
...
>> No properties? Looks like suitable for trivial bundings.
>
> Agreed. Since there are no device-specific properties and software-wise
> this is a single device, I will drop the standalone binding in v2 and
> add a single entry to trivial-devices.yaml:
>
> - description: Luxshare LX1308 12V/860W digital DC/DC power module
> compatible: luxshare,lx1308
>
> The mechanical variant information will be documented in
> Documentation/hwmon/lx1308.rst (sent in patch 2/2) so integrators can
> still find it, without polluting the ABI.
>
Mechanical variants are irrelevant for the driver, and may change over time.
Please drop entirely, or maybe just state that multiple mechanical variants
are available and refer to the datasheet for details.
Thanks,
Guenter
next prev parent reply other threads:[~2026-04-27 13:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 12:06 [PATCH 0/2] Add support for LX1308 Brian Chiang
2026-04-22 12:06 ` [PATCH 1/2] dt-bindings: (pmbus/lx1308) Add LX1308 support Brian Chiang
2026-04-23 8:41 ` Krzysztof Kozlowski
2026-04-27 11:15 ` Brian Chiang
2026-04-27 13:35 ` Guenter Roeck [this message]
2026-04-22 12:06 ` [PATCH 2/2] hwmon: (pmbus/lx1308) Add support for LX1308 Brian Chiang
2026-04-23 8:43 ` Krzysztof Kozlowski
2026-04-27 11:15 ` Brian Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c59f9d11-d79d-46f8-b48d-9a2cd7921510@roeck-us.net \
--to=linux@roeck-us.net \
--cc=chiang.brian@inventec.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox