From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-6.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id EA65B7D089 for ; Wed, 26 Dec 2018 06:14:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725950AbeLZGOy (ORCPT ); Wed, 26 Dec 2018 01:14:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39658 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725869AbeLZGOx (ORCPT ); Wed, 26 Dec 2018 01:14:53 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A68DFA4042; Wed, 26 Dec 2018 06:14:53 +0000 (UTC) Received: from localhost.localdomain (ovpn-12-27.pek2.redhat.com [10.72.12.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B20606111A; Wed, 26 Dec 2018 06:14:44 +0000 (UTC) Subject: Re: [PATCH 1/2 v3] kdump: add the vmcoreinfo documentation To: Dave Young Cc: Borislav Petkov , bhe@redhat.com, linux-doc@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, mingo@redhat.com, tglx@linutronix.de, akpm@linux-foundation.org, anderson@redhat.com, Kazuhito Hagio References: <20181216131617.2612-1-lijiang@redhat.com> <20181216131617.2612-2-lijiang@redhat.com> <20181217130024.GD12165@zn.tnic> <826c1a6b-41da-bc1a-f9c2-0d52e774b572@redhat.com> <20181226032433.GB13556@dhcp-128-65.nay.redhat.com> <20181226033658.GB13822@dhcp-128-65.nay.redhat.com> From: lijiang Message-ID: Date: Wed, 26 Dec 2018 14:14:40 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181226033658.GB13822@dhcp-128-65.nay.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 26 Dec 2018 06:14:53 +0000 (UTC) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org 在 2018年12月26日 11:36, Dave Young 写道: > On 12/26/18 at 11:24am, Dave Young wrote: >>>>> + >>>>> +KERNEL_IMAGE_SIZE >>>>> +================= >>>>> +The size of 'KERNEL_IMAGE_SIZE', currently unused. >>>> >>>> So remove? >>>> >>> >>> I'm not sure whether it should be removed, so i keep it. >> >> Just remove it. It was added by Baoquan for KASLR issues, later >> makedumpfile reverted the userspace part and added other implementation. >> >> In case old makedumpfile does not support new kernel, it has some kernel >> versions support list in code, thus no worry about the compatibility >> issue. > > Ah, it is not unused actually, clone crash tool git: > $ git grep KERNEL_IMAGE_SIZE > x86_64.c: if ((string = pc->read_vmcoreinfo("NUMBER(KERNEL_IMAGE_SIZE)"))) { > > So in the documentation, the use cases of crash tool should also be > covered. > Sure, maybe only this one was ignored. I will improve this variable in the documentation. > Lianbo, it would be good to cc Dave and Kazu for these patches, could > you cc them in your next post? > Yes, i will add Dave and Kazu, and also resend patch v4. Thanks. >> >> Thanks >> Dave > > Thanks > Dave >